From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Ricardo Ribalda <ribalda@chromium.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Yong Zhi <yong.zhi@intel.com>, Bingbu Cao <bingbu.cao@intel.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>
Subject: Re: [PATCH 4/7] media: ipu3-cio2: VIDIOC_QUERYCAP: Fix bus_info
Date: Wed, 29 Sep 2021 08:55:16 +0800 [thread overview]
Message-ID: <0afce6fa-068d-2b66-e394-d9398e99069b@linux.intel.com> (raw)
In-Reply-To: <20210928211033.2415162-5-ribalda@chromium.org>
Besides the subject,
Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>
On 9/29/21 5:10 AM, Ricardo Ribalda wrote:
> bus_info field had a different value for the media entity and the video
> device.
>
> Fixes v4l2-compliance:
>
> v4l2-compliance.cpp(637): media bus_info 'PCI:0000:00:05.0' differs from
> V4L2 bus_info 'PCI:viewfinder'
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/staging/media/ipu3/ipu3-v4l2.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/ipu3/ipu3-v4l2.c b/drivers/staging/media/ipu3/ipu3-v4l2.c
> index 66995c6f15808..2594ac4eb0763 100644
> --- a/drivers/staging/media/ipu3/ipu3-v4l2.c
> +++ b/drivers/staging/media/ipu3/ipu3-v4l2.c
> @@ -592,11 +592,12 @@ static const struct imgu_fmt *find_format(struct v4l2_format *f, u32 type)
> static int imgu_vidioc_querycap(struct file *file, void *fh,
> struct v4l2_capability *cap)
> {
> - struct imgu_video_device *node = file_to_intel_imgu_node(file);
> + struct imgu_device *imgu = video_drvdata(file);
>
> strscpy(cap->driver, IMGU_NAME, sizeof(cap->driver));
> strscpy(cap->card, IMGU_NAME, sizeof(cap->card));
> - snprintf(cap->bus_info, sizeof(cap->bus_info), "PCI:%s", node->name);
> + snprintf(cap->bus_info, sizeof(cap->bus_info), "PCI:%s",
> + pci_name(imgu->pci_dev));
>
> return 0;
> }
>
--
Best regards,
Bingbu Cao
next prev parent reply other threads:[~2021-09-29 0:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 21:10 [PATCH 0/7] media: ipu3 i2c: Fix v4l2-compliance issues Ricardo Ribalda
2021-09-28 21:10 ` [PATCH 1/7] media: ipu3-cio2: Check num_planes and sizes in queue_setup Ricardo Ribalda
2021-09-29 0:54 ` Bingbu Cao
2021-09-28 21:10 ` [PATCH 2/7] media: ipu3-cio2: Set valid initial format Ricardo Ribalda
2021-10-01 9:15 ` Sakari Ailus
2021-09-28 21:10 ` [PATCH 3/7] media: ipu3-cio2: imgu_fmt: Handle properly try Ricardo Ribalda
2021-09-28 21:10 ` [PATCH 4/7] media: ipu3-cio2: VIDIOC_QUERYCAP: Fix bus_info Ricardo Ribalda
2021-09-29 0:55 ` Bingbu Cao [this message]
2021-09-28 21:10 ` [PATCH 5/7] media: dw9714: Add implementation for events Ricardo Ribalda
2021-09-28 21:10 ` [PATCH 6/7] media: ov13858: " Ricardo Ribalda
2021-09-28 21:10 ` [PATCH 7/7] media: ov5670: " Ricardo Ribalda
2021-09-29 0:53 ` [PATCH 0/7] media: ipu3 i2c: Fix v4l2-compliance issues Bingbu Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0afce6fa-068d-2b66-e394-d9398e99069b@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=ribalda@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=yong.zhi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).