From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755651AbdEHPK5 (ORCPT ); Mon, 8 May 2017 11:10:57 -0400 Received: from mout.web.de ([212.227.17.11]:56996 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754822AbdEHPKz (ORCPT ); Mon, 8 May 2017 11:10:55 -0400 Subject: [PATCH 3/3] mtdswap: Improve a size determination in mtdswap_erase_block() From: SF Markus Elfring To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Marek Vasut , Richard Weinberger Cc: LKML , kernel-janitors@vger.kernel.org References: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Message-ID: <0afe37eb-71fe-2a40-7ed5-24b910906671@users.sourceforge.net> Date: Mon, 8 May 2017 17:10:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <82e905b5-3958-be81-b0ee-d0a2805154df@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:NdvGUknW/r7si2Ci0jQ0XRsyyn8FM1szSxlvjtVxchQ6iyGqhhG ZyTOdniGjEdsUl2h+SkvprB7xRBblBiZwrucjosLx3jxpdGZNUIHaw/xz10eYxQOwlprFiJ lg5VeQ06TtRDEf2snBpqytYv2TaIN9Z5MpIpsqih4LAwTs4BmcXV4dgLBVNhHTEusdWiWG6 rnboHYtQ5+qQ+kuAPuIww== X-UI-Out-Filterresults: notjunk:1;V01:K0:8uKEueQCGe4=:KJv8iCO0XPwISo0XqTyC9f BkmLa8qorDTXkrWoH1sljcGcPzw+ilKipYsSgZLGdb+xX9A61llInEhK4MfgUB4EAP+1xST8U 3AvZktFq7vhRJBJ1rHnlLuCdjBHh/gF4Tv79WUiPYrhDRg8c1uDfPzmKR/ZYun/S7MTcIQl58 4VoUlNysBj28CKNxVk4vHV7o3blDaGPQYVh67x4qZHaDhMNl744nHFQEmJuah8x2usqsguxg6 fqwuJxbaLG5EigaKCrlHIfpyE3llt371gckHmEkwmoWSWnwENSxUTNMrV9FHD92IeGqaSCClP 0yMu3fVu+k2CBmeDcy7eqnwwgy814Lg6VMbfe5d9QS2nfAnwcsfyryrF7cP8Kcb9jDa6lp9Mn fM1T8x5RNuM7VUKvdCT2blCBwswJzmySWC3/mU1glQtUu9Y6i/uFjZYi8RVnMKhl0RuM9fPPT Xzsl2rmNpvHENiuNKcWRRw3UwxCNHElJAS4bdVUdkxeKN3FYyKo8iXGzP8xiIMo8nxB9yui/x nFz5PdtmdUKtBGlJJEV/sANaDuVooP4FyTvFoUmXAdwbstNeiG/I0qkmFYJbyBk58MOB0Wvg2 FBN0lRRBdsO7LJ68aLQpcROWP/q3kwMxW7KHfMkxMiYTn7Ag3lmUhurmYLBKAGtw1R45itcY8 95EVBQ6AOFuf2/m3RKvriWZbGJDnEOamNhJ4xI+IUSYad2K2f9l3pliBdWeapgFqKjouEDD6r 5MO4XDhRcvPiflRVFYyDKryFOEtcZ/E7Z38xG4F9a4Y7J8c1Q94TXd0c5CC5HupjLd/AQSWzW av62ZrC Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 8 May 2017 16:51:30 +0200 Replace the specification of a data structure by a name for a local variable as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- drivers/mtd/mtdswap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mtd/mtdswap.c b/drivers/mtd/mtdswap.c index f73fb0909b0c..c748515f8533 100644 --- a/drivers/mtd/mtdswap.c +++ b/drivers/mtd/mtdswap.c @@ -559,8 +559,7 @@ static int mtdswap_erase_block(struct mtdswap_dev *d, struct swap_eb *eb) retry: init_waitqueue_head(&wq); - memset(&erase, 0, sizeof(struct erase_info)); - + memset(&erase, 0, sizeof(erase)); erase.mtd = mtd; erase.callback = mtdswap_erase_callback; erase.addr = mtdswap_eb_offset(d, eb); -- 2.12.2