From: Javier Martinez Canillas <javierm@redhat.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
James Ettle <james@ettle.org.uk>
Cc: linux-integrity@vger.kernel.org, azhar.shaikh@intel.com,
linux-kernel@vger.kernel.org, james.l.morris@oracle.com
Subject: Re: [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system
Date: Thu, 14 Dec 2017 13:05:49 +0100 [thread overview]
Message-ID: <0b46ecfe-8b6c-e169-bff6-e7ce01693a8c@redhat.com> (raw)
In-Reply-To: <20171214112124.7t2oxch2gadyfqsr@linux.intel.com>
Hello Jarkko,
On 12/14/2017 12:21 PM, Jarkko Sakkinen wrote:
> On Mon, Dec 11, 2017 at 07:37:29PM +0000, James Ettle wrote:
>> Hello,
>>
>> [First: Apologies if cross-posting from Kernel.org BZ is bad form; my
>> distro BZ advised I post this to your mailing list as well.]
>>
>> Situation: enabling TPM on a Clevo W510LU with an Intel N3160 CPU
>> breaks PS/2 keyboard and mouse. They just don't respond until after a
>> suspend/resume cycle, and after that they later stop after a while.
>>
>> I have confirmed this by blacklisting tpm modules. I noticed this
>> first with kernel 4.13, and have bisected it down to:
>
> In my GIT tree there is now:
>
> commit db3248e8a036c39141c8f7e9f1cf5c5ae6815f76 (HEAD -> next, origin/next, origin/master, master)
> Author: Azhar Shaikh <azhar.shaikh@intel.com>
> Date: Wed Dec 6 17:38:10 2017 -0800
>
> tpm: Keep CLKRUN enabled throughout the duration of transmit_cmd()
>
> Commit 5e572cab92f0bb5 ("tpm: Enable CLKRUN protocol for Braswell
> systems") disabled CLKRUN protocol during TPM transactions and re-enabled
> once the transaction is completed. But there were still some corner cases
> observed where, reading of TPM header failed for savestate command
> while going to suspend, which resulted in suspend failure.
> To fix this issue keep the CLKRUN protocol disabled for the entire
> duration of a single TPM command and not disabling and re-enabling
> again for every TPM transaction. For the other TPM accesses outside
> TPM command flow, add a higher level of disabling and re-enabling
> the CLKRUN protocol, instead of doing for every TPM transaction.
>
> Fixes: 5e572cab92f0bb5 ("tpm: Enable CLKRUN protocol for Braswell systems")
>
> Signed-off-by: Azhar Shaikh <azhar.shaikh@intel.com>
> Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Tested-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
> Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
>
> Can you try this?
>
I already suggested the same [0], but James said that made no difference [1].
> /Jarkko
>
[0]: https://lkml.org/lkml/2017/12/12/268
[1]: https://lkml.org/lkml/2017/12/12/1127
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
prev parent reply other threads:[~2017-12-14 12:05 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 19:37 [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system James Ettle
2017-12-12 11:38 ` Javier Martinez Canillas
2017-12-12 18:57 ` Jason Gunthorpe
2017-12-12 19:12 ` Javier Martinez Canillas
2017-12-12 21:17 ` James Ettle
2017-12-14 19:08 ` Javier Martinez Canillas
2017-12-14 19:10 ` Jason Gunthorpe
2017-12-15 14:56 ` Jarkko Sakkinen
2017-12-15 17:38 ` Jason Gunthorpe
2017-12-16 17:01 ` Jarkko Sakkinen
2017-12-16 20:59 ` Javier Martinez Canillas
2017-12-18 11:11 ` Javier Martinez Canillas
2018-01-02 20:53 ` Pavel Machek
2017-12-18 12:22 ` Javier Martinez Canillas
2017-12-18 12:29 ` Javier Martinez Canillas
2017-12-18 17:55 ` Jason Gunthorpe
2017-12-18 19:29 ` Javier Martinez Canillas
2017-12-18 19:34 ` Shaikh, Azhar
2017-12-18 20:04 ` Shaikh, Azhar
2017-12-18 20:19 ` Jason Gunthorpe
2017-12-18 23:34 ` Javier Martinez Canillas
2017-12-19 2:08 ` Jason Gunthorpe
2017-12-19 13:10 ` Jarkko Sakkinen
2017-12-19 13:12 ` Javier Martinez Canillas
2017-12-19 13:04 ` Jarkko Sakkinen
2017-12-19 20:20 ` Jason Gunthorpe
2017-12-18 23:06 ` Javier Martinez Canillas
2017-12-18 20:17 ` Jason Gunthorpe
2017-12-19 13:02 ` Jarkko Sakkinen
2017-12-18 18:26 ` James Ettle
2017-12-18 19:34 ` Javier Martinez Canillas
2017-12-19 13:00 ` Jarkko Sakkinen
2017-12-19 13:18 ` James Ettle
2017-12-22 18:30 ` Jarkko Sakkinen
2017-12-19 12:59 ` Jarkko Sakkinen
2017-12-19 13:10 ` Javier Martinez Canillas
2017-12-19 21:08 ` [PATCH 1/1] tpm: only attempt to disable the LPC CLKRUN if is already kbuild test robot
2017-12-14 11:21 ` [BISECTED] tpm CLKRUN breaks PS/2 keyboard and touchpad on Braswell system Jarkko Sakkinen
2017-12-14 12:05 ` Javier Martinez Canillas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b46ecfe-8b6c-e169-bff6-e7ce01693a8c@redhat.com \
--to=javierm@redhat.com \
--cc=azhar.shaikh@intel.com \
--cc=james.l.morris@oracle.com \
--cc=james@ettle.org.uk \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).