From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87467C433FE for ; Fri, 29 Apr 2022 17:09:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379431AbiD2RMf (ORCPT ); Fri, 29 Apr 2022 13:12:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244469AbiD2RMb (ORCPT ); Fri, 29 Apr 2022 13:12:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 68F6AD4477 for ; Fri, 29 Apr 2022 10:09:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1651252152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bR7U7XKW06Rd0hYKWp18hOYc2jittIlTjeGYl3Ta7P4=; b=W13b87P3pFr732ZFQveWPdzWf62N3ITf3u/TtUy8X5S+9SvER+6iKuTMh6kqROmpmy+80d vBGgQfhZ9NBD+6YxvzXjrRDUerOxm9HF2icQOxYmn/fsqBHJP04jdOD3RqyhSVXJpKhehP sZgl8UtNXdWVbganIgFkkxswCdSNXOc= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-392-5XKkvI33OV65GhqwI1iG1Q-1; Fri, 29 Apr 2022 13:09:09 -0400 X-MC-Unique: 5XKkvI33OV65GhqwI1iG1Q-1 Received: by mail-ej1-f70.google.com with SMTP id hs26-20020a1709073e9a00b006f3b957ebb4so4842856ejc.7 for ; Fri, 29 Apr 2022 10:09:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=bR7U7XKW06Rd0hYKWp18hOYc2jittIlTjeGYl3Ta7P4=; b=0+qQ4fwMma1Hy9tDXhYXa8JxGJSL3oh+kzYxL4NMAgXrnY0SEoVERiBIzEieLUQOos a4NQnTE4bb/ZsIoW8gF2jQU5sjTue8EB9rLvtF39LRgiNaIx0m63sQp6l5TIOMG3+eq8 y8xL/9X0JZjMpio52mJ3yzGsBSK+TzKyRdrDfTDTiYOArMam63lv0vLLUhJWD4huWEOc ad5tqvycBxJU1D4e8B/zHEaq+lG5quQ/6dMkUCPDG5Qqp9XZvO4Ty0erMYy6RYUCuC+8 CkAasze7QL8gyRHnmQ+A3QGys/Sa+k1Vm50B2mNZbIzy7bQJcdeH3iWzfUacobZ/1zbt 5y7w== X-Gm-Message-State: AOAM532sctMSixWTSPrjXAdcWRSTnVmCSY0x7gC7dB4H3R5pApX/SZib nrA6HKQtGMCteKXq93C4WesKDaBpq24a1p+zV/2K+jPhOLDNWHGVMD3resCbwekZzLgq3Z3za+l 4SIv/a/gQMpEmCMEM1frbDyzB X-Received: by 2002:a05:6402:5114:b0:423:f33d:b3c with SMTP id m20-20020a056402511400b00423f33d0b3cmr196211edd.199.1651252148302; Fri, 29 Apr 2022 10:09:08 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwgSmtYizJefurAotPaAGKxQWAIKDpoKa9RhzQgBMvyNJAu2o8gugfd+deHOvkf9pb1W9NpYQ== X-Received: by 2002:a05:6402:5114:b0:423:f33d:b3c with SMTP id m20-20020a056402511400b00423f33d0b3cmr196192edd.199.1651252148063; Fri, 29 Apr 2022 10:09:08 -0700 (PDT) Received: from ?IPV6:2001:b07:6468:f312:1c09:f536:3de6:228c? ([2001:b07:6468:f312:1c09:f536:3de6:228c]) by smtp.googlemail.com with ESMTPSA id g14-20020a056402180e00b0042617ba6389sm3115953edy.19.2022.04.29.10.09.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Apr 2022 10:09:07 -0700 (PDT) Message-ID: <0b554e22-6766-8299-287c-c40240c08536@redhat.com> Date: Fri, 29 Apr 2022 19:09:06 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] KVM: x86: make vendor code check for all nested events Content-Language: en-US To: Sean Christopherson Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, mlevitsk@redhat.com, stable@vger.kernel.org References: <20220427173758.517087-1-pbonzini@redhat.com> <20220427173758.517087-2-pbonzini@redhat.com> From: Paolo Bonzini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/29/22 19:03, Sean Christopherson wrote: > This doesn't even compile... > > arch/x86/kvm/vmx/nested.c: In function ‘vmx_has_nested_events’: > arch/x86/kvm/vmx/nested.c:3862:61: error: ‘vmx’ undeclared (first use in this function) > 3862 | return nested_vmx_preemption_timer_pending(vcpu) || vmx->nested.mtf_pending; > | ^~~ > arch/x86/kvm/vmx/nested.c:3862:61: note: each undeclared identifier is reported only once for each function it appears in > CC [M] arch/x86/kvm/svm/svm_onhyperv.o > arch/x86/kvm/vmx/nested.c:3863:1: error: control reaches end of non-void function [-Werror=return-type] > 3863 | } > | ^ > cc1: all warnings being treated as errors > LD [M] arch/x86/kvm/kvm.o Yeah, it doesn't. Of course this will need a v2, also because there are failures in the vmx tests. What can I say, testing these patches on AMD hardware wasn't a great idea. Paolo