From: Andi Kleen <ak@linux.intel.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: syzbot <syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com>,
bp@alien8.de, hpa@zytor.com, inglorion@google.com,
linux-kernel@vger.kernel.org, mingo@redhat.com,
syzkaller-bugs@googlegroups.com, tglx@linutronix.de,
x86@kernel.org, Andy Lutomirski <luto@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [syzbot] KASAN: stack-out-of-bounds Read in profile_pc
Date: Thu, 3 Jun 2021 06:52:19 -0700 [thread overview]
Message-ID: <0b71d4f9-f707-3d39-c358-7c06c5689a9d@linux.intel.com> (raw)
In-Reply-To: <20210603133914.j2aeadmvhncnlk5q@treble>
> True, ftrace does have function profiling (function_profile_enabled).
>
> Steve, is there a way to enable that on the kernel cmdline?
That's not really comparable. function profiling has a lot more
overhead. Also there is various code which has ftrace instrumentation
disabled.
I don't think why you want to kill the old profiler. It's rarely used,
but when you need it usually works. It's always good to have simple fall
backs. And it's not that it's a lot of difficult code.
-Andi
next prev parent reply other threads:[~2021-06-03 13:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-31 7:15 [syzbot] KASAN: stack-out-of-bounds Read in profile_pc syzbot
2021-06-02 23:00 ` Josh Poimboeuf
2021-06-02 23:35 ` Andi Kleen
2021-06-03 13:29 ` Josh Poimboeuf
2021-06-03 13:30 ` Peter Zijlstra
2021-06-03 13:39 ` Josh Poimboeuf
2021-06-03 13:52 ` Andi Kleen [this message]
2021-10-11 13:07 ` Lee Jones
2021-10-11 14:43 ` Steven Rostedt
2021-10-11 17:10 ` Dmitry Vyukov
2021-10-11 17:30 ` Josh Poimboeuf
2021-06-03 8:02 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b71d4f9-f707-3d39-c358-7c06c5689a9d@linux.intel.com \
--to=ak@linux.intel.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=inglorion@google.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=syzbot+84fe685c02cd112a2ac3@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).