From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751748AbdLEUlA (ORCPT ); Tue, 5 Dec 2017 15:41:00 -0500 Received: from smtp3-g21.free.fr ([212.27.42.3]:38372 "EHLO smtp3-g21.free.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750740AbdLEUk5 (ORCPT ); Tue, 5 Dec 2017 15:40:57 -0500 Subject: Re: [PATCHv2 0/2] mtd: m25p80: restore the addressing mode when stop using the flash To: Zhiqiang Hou , linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, computersforpeace@gmail.com, dwmw2@infradead.org, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at References: <20171205053322.35823-1-Zhiqiang.Hou@nxp.com> From: Cyrille Pitchen Message-ID: <0b8fae88-cff4-41ac-2613-09bb671ec070@wedev4u.fr> Date: Tue, 5 Dec 2017 21:40:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171205053322.35823-1-Zhiqiang.Hou@nxp.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Hou, Le 05/12/2017 à 06:33, Zhiqiang Hou a écrit : > From: Hou Zhiqiang > > To be compatible with legacy device, reset the addressing mode > to the default mode. Such as Freescale eSPI boot, it copies the > images from SPI flash without firing a reset signal previously, > so the reboot command will fail without reseting the addressing > mode of SPI flash. > You should put this in one of the commit messages so it explains which issue is fixed by your patches. Otherwise, your series looks good to me :) Best regards, Cyrille > Hou Zhiqiang (2): > mtd: spi-nor: add an API to restore the status of SPI flash chip > mtd: m25p80: restore the status of SPI flash when stop using it > > Documentation/mtd/spi-nor.txt | 3 +++ > drivers/mtd/devices/m25p80.c | 9 +++++++++ > drivers/mtd/spi-nor/spi-nor.c | 10 ++++++++++ > include/linux/mtd/spi-nor.h | 6 ++++++ > 4 files changed, 28 insertions(+) >