From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
To: Markuss Broks <markuss.broks@gmail.com>, linux-kernel@vger.kernel.org
Cc: phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/2] dt-bindings: input/touchscreen: bindings for Imagis
Date: Tue, 15 Feb 2022 16:54:40 +0100 [thread overview]
Message-ID: <0bb07d0a-838d-b772-91ca-aa31b57b2f3c@canonical.com> (raw)
In-Reply-To: <20220215151527.84634-2-markuss.broks@gmail.com>
On 15/02/2022 16:15, Markuss Broks wrote:
> This patch adds device-tree bindings for the Imagis
> IST3038C touch screen IC.
>
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---
> .../input/touchscreen/imagis,ist3038c.yaml | 75 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 +
> 2 files changed, 77 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
>
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> new file mode 100644
> index 000000000000..7b127817e1f6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/touchscreen/imagis,ist3038c.yaml
> @@ -0,0 +1,75 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/input/touchscreen/imagis,ist3038c.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Imagis IST30XXC family touchscreen controller bindings
> +
> +maintainers:
> + - Markuss Broks <markuss.broks@gmail.com>
> +
> +allOf:
> + - $ref: touchscreen.yaml#
> +
> +properties:
> + $nodename:
> + pattern: "^touchscreen(@.*)?$"
reg is required, so @ is not optional:
^touchscreen@[0-9a-f]+$
> +
> + compatible:
> + items:
Do you expect here multiple compatibles? If not, the items are not needed.
> + - enum:
> + - imagis,ist3038c
> +
> + reg:
> + description: I2C address
You can skip description because it is fairly obvious, but instead you
need maxItems. Alternatively, a list (items) with description defines
max items.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-02-15 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 16:37 [PATCH v2 0/2] Add support for Imagis touchscreens Markuss Broks
2022-02-10 16:37 ` [PATCH v2 1/2] dt-bindings: input/touchscreen: bindings for Imagis Markuss Broks
2022-02-10 22:25 ` Rob Herring
2022-02-15 15:15 ` [PATCH v3 0/2] Add support for Imagis touchscreens Markuss Broks
2022-02-15 15:15 ` [PATCH v3 1/2] dt-bindings: input/touchscreen: bindings for Imagis Markuss Broks
2022-02-15 15:54 ` Krzysztof Kozlowski [this message]
2022-02-15 15:15 ` [PATCH v3 2/2] Input: add Imagis touchscreen driver Markuss Broks
2022-02-15 16:05 ` Krzysztof Kozlowski
2022-02-10 16:37 ` [PATCH v2 " Markuss Broks
2022-02-11 0:01 ` Jeff LaBundy
2022-02-11 0:50 ` Jeff LaBundy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb07d0a-838d-b772-91ca-aa31b57b2f3c@canonical.com \
--to=krzysztof.kozlowski@canonical.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=sfr@canb.auug.org.au \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).