From: "Brian Cain" <bcain@codeaurora.org>
To: "'Jiapeng Chong'" <jiapeng.chong@linux.alibaba.com>
Cc: <linux-hexagon@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] trap: Fix warning comparing pointer to 0
Date: Mon, 6 Sep 2021 21:23:01 -0500 [thread overview]
Message-ID: <0bcb01d7a38f$48dd1c20$da975460$@codeaurora.org> (raw)
In-Reply-To: <1630920794-81114-1-git-send-email-jiapeng.chong@linux.alibaba.com>
> -----Original Message-----
> From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> Sent: Monday, September 6, 2021 4:33 AM
> To: bcain@codeaurora.org
> Cc: linux-hexagon@vger.kernel.org; linux-kernel@vger.kernel.org;
> chongjiapeng <jiapeng.chong@linux.alibaba.com>
> Subject: [PATCH] trap: Fix warning comparing pointer to 0
>
> From: chongjiapeng <jiapeng.chong@linux.alibaba.com>
>
> Fix the following coccicheck warning:
>
> ./arch/hexagon/kernel/traps.c:138:6-7: WARNING comparing pointer to 0.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: chongjiapeng <jiapeng.chong@linux.alibaba.com>
> ---
> arch/hexagon/kernel/traps.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/hexagon/kernel/traps.c b/arch/hexagon/kernel/traps.c
> index edfc35d..3b6e0de 100644
> --- a/arch/hexagon/kernel/traps.c
> +++ b/arch/hexagon/kernel/traps.c
> @@ -135,7 +135,7 @@ static void do_show_stack(struct task_struct *task,
> unsigned long *fp,
> }
>
> /* Attempt to continue past exception. */
> - if (0 == newfp) {
> + if (!newfp) {
> struct pt_regs *regs = (struct pt_regs *) (((void
*)fp)
> + 8);
>
Reviewed-by: Brian Cain <bcain@codeaurora.org>
next prev parent reply other threads:[~2021-09-07 2:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-06 9:33 [PATCH] trap: Fix warning comparing pointer to 0 Jiapeng Chong
2021-09-07 2:23 ` Brian Cain [this message]
2023-01-28 9:39 Jiapeng Chong
2023-01-30 16:43 ` Brian Cain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0bcb01d7a38f$48dd1c20$da975460$@codeaurora.org' \
--to=bcain@codeaurora.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).