From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22F22C4167E for ; Fri, 1 Oct 2021 14:35:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0F00761A50 for ; Fri, 1 Oct 2021 14:35:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1354556AbhJAOhJ (ORCPT ); Fri, 1 Oct 2021 10:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231511AbhJAOhI (ORCPT ); Fri, 1 Oct 2021 10:37:08 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1435C061775; Fri, 1 Oct 2021 07:35:23 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id g41so39325432lfv.1; Fri, 01 Oct 2021 07:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=hmV8HiS2tOf7621YfFrxpYJRebZdp4NqBv255LyC2LE=; b=gVfVeWzlIRRZb5mmgFJpuc+Yfw2CJzBdf6wr0/B7EujBKlivLfiVtM/grTuqnXkqXG yL8Eg6rh9P6iXsBJY7WXnQN929pxP30S5RRlBov9cYfYTncN1DBpTAARGYHxLycdOQxq LoF/IhH7L2KT1pyRob0U6ByUrBDl1TmjVVkeH7+nYQQNTiStrkF1dM00+3fLFQJ8oXZE 7uXslh4Ukfr2j7Mb7RkORfFYa5ef8CKw5FEYlT3u3Ybu5fMh/Takf4SHFHwf5//hRg4G lyAxaTeJleP7SYkxCfJV6MSOmxbhUc3DqsYLGPw/q/v25xceW5ZUPvo1euKVX4OyRa4S tvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=hmV8HiS2tOf7621YfFrxpYJRebZdp4NqBv255LyC2LE=; b=nRVNgyFV3N0E85TU1wtZyntSBDhyiaMjGjGkZyxGtfpYuBd2VZB5wfqBdVR6DE+AKz 8aCZQc9APlFhgcrpBXk9o6sbHRPSOQT0W8JujmOlJwXInGgD44RAtf8HClbDpmK7QytM dpf4rBE5TuLfC3Wdr5Vz3pOyulFqUCwHZZPyrbj+FCspPNURT+BZSCo/u4RPOaW8lZzP betvtcFViT7L6sBuBSmX6Hcif61bn+nxjK0uBSJM11Wf/EkiSU5e1r5yY6T5AFIzllbK 5o/HjuKFWvnXZU5wDaS+Y2KLwErWF8hjF9x7iUhkf3ZHp42IBousTcAwOyx8es/uwrh6 dUgA== X-Gm-Message-State: AOAM533Oiv8xvTougdkdiEs7RE9ex2eY3N9vosijxIlmhli1snITI3le jyisdsolSu8km92dcOu5Rv8= X-Google-Smtp-Source: ABdhPJw//TuGFtjAUNUsrPnJxIYfZyV7+RdRH4nZbJDVr/PeCRJiHyUV+Xd9Z3J4jT4xr3JBkfK0Fw== X-Received: by 2002:a2e:9e87:: with SMTP id f7mr12283717ljk.413.1633098922043; Fri, 01 Oct 2021 07:35:22 -0700 (PDT) Received: from [192.168.2.145] (79-139-163-198.dynamic.spd-mgts.ru. [79.139.163.198]) by smtp.googlemail.com with ESMTPSA id m29sm752018lfo.191.2021.10.01.07.35.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 07:35:21 -0700 (PDT) Subject: Re: [PATCH v13 20/35] mtd: rawnand: tegra: Add runtime PM and OPP support To: Ulf Hansson Cc: Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Adrian Hunter , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-pwm@vger.kernel.org, linux-mmc , dri-devel , DTML , linux-clk , Mark Brown , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Mauro Carvalho Chehab , David Heidelberg References: <20210926224058.1252-1-digetx@gmail.com> <20210926224058.1252-21-digetx@gmail.com> From: Dmitry Osipenko Message-ID: <0bcbcd3d-2154-03d2-f572-dc9032125c26@gmail.com> Date: Fri, 1 Oct 2021 17:35:20 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 01.10.2021 17:24, Ulf Hansson пишет: > On Mon, 27 Sept 2021 at 00:42, Dmitry Osipenko wrote: >> >> The NAND on Tegra belongs to the core power domain and we're going to >> enable GENPD support for the core domain. Now NAND must be resumed using >> runtime PM API in order to initialize the NAND power state. Add runtime PM >> and OPP support to the NAND driver. >> >> Acked-by: Miquel Raynal >> Signed-off-by: Dmitry Osipenko >> --- >> drivers/mtd/nand/raw/tegra_nand.c | 55 ++++++++++++++++++++++++++----- >> 1 file changed, 47 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/mtd/nand/raw/tegra_nand.c b/drivers/mtd/nand/raw/tegra_nand.c >> index 32431bbe69b8..098fcc9cb9df 100644 >> --- a/drivers/mtd/nand/raw/tegra_nand.c >> +++ b/drivers/mtd/nand/raw/tegra_nand.c >> @@ -17,8 +17,11 @@ >> #include >> #include >> #include >> +#include >> #include >> >> +#include >> + >> #define COMMAND 0x00 >> #define COMMAND_GO BIT(31) >> #define COMMAND_CLE BIT(30) >> @@ -1151,6 +1154,7 @@ static int tegra_nand_probe(struct platform_device *pdev) >> return -ENOMEM; >> >> ctrl->dev = &pdev->dev; >> + platform_set_drvdata(pdev, ctrl); >> nand_controller_init(&ctrl->controller); >> ctrl->controller.ops = &tegra_nand_controller_ops; >> >> @@ -1166,14 +1170,22 @@ static int tegra_nand_probe(struct platform_device *pdev) >> if (IS_ERR(ctrl->clk)) >> return PTR_ERR(ctrl->clk); >> >> - err = clk_prepare_enable(ctrl->clk); >> + err = devm_pm_runtime_enable(&pdev->dev); >> + if (err) >> + return err; >> + >> + err = devm_tegra_core_dev_init_opp_table_common(&pdev->dev); >> + if (err) >> + return err; >> + >> + err = pm_runtime_resume_and_get(&pdev->dev); >> if (err) >> return err; >> >> err = reset_control_reset(rst); >> if (err) { >> dev_err(ctrl->dev, "Failed to reset HW: %d\n", err); >> - goto err_disable_clk; >> + goto err_put_pm; >> } >> >> writel_relaxed(HWSTATUS_CMD_DEFAULT, ctrl->regs + HWSTATUS_CMD); >> @@ -1188,21 +1200,19 @@ static int tegra_nand_probe(struct platform_device *pdev) >> dev_name(&pdev->dev), ctrl); >> if (err) { >> dev_err(ctrl->dev, "Failed to get IRQ: %d\n", err); >> - goto err_disable_clk; >> + goto err_put_pm; >> } >> >> writel_relaxed(DMA_MST_CTRL_IS_DONE, ctrl->regs + DMA_MST_CTRL); >> >> err = tegra_nand_chips_init(ctrl->dev, ctrl); >> if (err) >> - goto err_disable_clk; >> - >> - platform_set_drvdata(pdev, ctrl); >> + goto err_put_pm; >> > > There is no corresponding call pm_runtime_put() here. Is it > intentional to always leave the device runtime resumed after ->probe() > has succeeded? > > I noticed you included some comments about this for some other > drivers, as those needed more tweaks. Is that also the case for this > driver? Could you please clarify? There is pm_runtime_put() in both probe-error and remove() code paths here. I assume you're meaning pm_runtime_disable(), but this patch uses resource-managed devm_pm_runtime_enable(), and thus, explicit disable isn't needed. >> return 0; >> >> -err_disable_clk: >> - clk_disable_unprepare(ctrl->clk); >> +err_put_pm: >> + pm_runtime_put(ctrl->dev); >> return err; >> } >> > > [...] > > Kind regards > Uffe >