From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753630AbdKAKRu (ORCPT ); Wed, 1 Nov 2017 06:17:50 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:52931 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752400AbdKAKRt (ORCPT ); Wed, 1 Nov 2017 06:17:49 -0400 Subject: Re: [PATCH 2/2] perf record: Replace 'overwrite' by 'flightrecorder' for better naming To: Namhyung Kim References: <20171101055327.141281-1-wangnan0@huawei.com> <20171101055327.141281-3-wangnan0@huawei.com> <20171101100347.GC25146@danjae.aot.lge.com> CC: , , , , From: "Wangnan (F)" Message-ID: <0bd4363a-12f1-d9e1-12b2-82360d397ccb@huawei.com> Date: Wed, 1 Nov 2017 18:17:26 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20171101100347.GC25146@danjae.aot.lge.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.194.139] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/11/1 18:03, Namhyung Kim wrote: > On Wed, Nov 01, 2017 at 05:53:27AM +0000, Wang Nan wrote: >> The meaning of perf record's "overwrite" option and many "overwrite" in >> source code are not clear. In perf's code, the 'overwrite' has 2 meanings: >> 1. Make ringbuffer readonly (perf_evlist__mmap_ex's argument). >> 2. Set evsel's "backward" attribute (in apply_config_terms). >> >> perf record doesn't use meaning 1 at all, but have a overwrite option, its >> real meaning is setting backward. >> >> This patch separates these two concepts, introduce 'flightrecorder' mode >> which is what we really want. It combines these 2 concept together, wraps >> them into a record mode. In flight recorder mode, perf only dumps data before >> something happen. > I'm ok with the it but removing old name looks not good. How about > keeping them for a while (as deprecated)?. Is there a way to hide '--overwrite' from 'perf record --help' and print something when user really use it? > And 'flightrecorder' seems too long. Maybe you can use an acronym > like FDR or fdr-mode? fdr-mode is a good name. Thank you.