From: Samuel Holland <samuel@sholland.org>
To: "Clément Péron" <peron.clem@gmail.com>,
"Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] arm64: dts: allwinner: beelink-gs1: Enable GPU OPP
Date: Mon, 22 Aug 2022 22:07:12 -0500 [thread overview]
Message-ID: <0c028109-bb50-fbaa-de18-9876706a7477@sholland.org> (raw)
In-Reply-To: <20220821173051.155038-5-peron.clem@gmail.com>
On 8/21/22 12:30 PM, Clément Péron wrote:
> Enable GPU OPP table for Beelink GS1
>
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
> arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 6249e9e02928..20fc0584d1c6 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -5,6 +5,7 @@
>
> #include "sun50i-h6.dtsi"
> #include "sun50i-h6-cpu-opp.dtsi"
> +#include "sun50i-h6-gpu-opp.dtsi"
>
> #include <dt-bindings/gpio/gpio.h>
>
> @@ -261,6 +262,7 @@ reg_dcdca: dcdca {
> };
>
> reg_dcdcc: dcdcc {
> + regulator-always-on;
Why is this necessary? This file already has:
&gpu {
mali-supply = <®_dcdcc>;
status = "okay";
};
So there is a consumer for this regulator.
Regards,
Samuel
> regulator-enable-ramp-delay = <32000>;
> regulator-min-microvolt = <810000>;
> regulator-max-microvolt = <1080000>;
>
next prev parent reply other threads:[~2022-08-23 3:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-21 17:30 [PATCH v2 0/4] Allwinner H6 GPU devfreq Clément Péron
2022-08-21 17:30 ` [PATCH v2 1/4] arm64: defconfig: Enable devfreq cooling device Clément Péron
2022-08-25 20:53 ` Jernej Škrabec
2022-08-21 17:30 ` [PATCH v2 2/4] arm64: dts: allwinner: h6: Add cooling map for GPU Clément Péron
2022-08-23 3:16 ` Samuel Holland
2022-08-27 16:49 ` Clément Péron
2022-09-04 3:24 ` Samuel Holland
2022-08-21 17:30 ` [PATCH v2 3/4] arm64: dts: allwinner: h6: Add GPU OPP table Clément Péron
2022-08-23 3:13 ` Samuel Holland
2022-08-23 8:46 ` Krzysztof Kozlowski
2022-08-21 17:30 ` [PATCH v2 4/4] arm64: dts: allwinner: beelink-gs1: Enable GPU OPP Clément Péron
2022-08-23 3:07 ` Samuel Holland [this message]
2022-09-03 18:41 ` Clément Péron
2022-09-03 19:06 ` Clément Péron
2022-09-04 3:32 ` Samuel Holland
2022-09-04 14:23 ` Clément Péron
2022-09-04 14:29 ` Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c028109-bb50-fbaa-de18-9876706a7477@sholland.org \
--to=samuel@sholland.org \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).