linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Kauer <florian.kauer@linutronix.de>
To: Markus Elfring <Markus.Elfring@web.de>,
	intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
	kernel-janitors@vger.kernel.org,
	Aravindhan Gunasekaran <aravindhan.gunasekaran@intel.com>,
	"David S . Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>,
	Jesse Brandeburg <jesse.brandeburg@intel.com>,
	Kurt Kanzenbach <kurt@linutronix.de>,
	Mallikarjuna Chilakala <mallikarjuna.chilakala@intel.com>,
	Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Tan Tee Min <tee.min.tan@linux.intel.com>,
	Tony Nguyen <anthony.l.nguyen@intel.com>,
	Vinicius Costa Gomes <vinicius.gomes@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net v2 1/6] igc: Rename qbv_enable to taprio_offload_enable
Date: Sun, 2 Jul 2023 21:17:01 +0200	[thread overview]
Message-ID: <0c02e976-0da6-8ed8-4546-4df7af4ebed5@linutronix.de> (raw)
In-Reply-To: <36b57ea5-baff-f964-3088-e1b186532cfe@web.de>

Hi Markus,

On 02.07.23 18:55, Markus Elfring wrote:
>> The rename should reduce this confusion.
> 
> Would the wording “Reduce this confusion by renaming a variable at three places”
> be more appropriate for a subsequent change description?
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.4#n94

Thanks for pointing that out (also in your other mail for this series).
I will be more careful regarding the use of imperative mood.

> 
>>                                          Since it is a pure
>> rename, it has no impact on functionality.
>>
>> Fixes: e17090eb2494 ("igc: allow BaseTime 0 enrollment for Qbv")
> 
> How does such information fit together?

The referenced commit introduced an issue into the kernel by
introducing a variable that does not exactly describe its actual purpose.
It is not only a cosmetic change, but in my view this confusion
was related to other issues (see the other patches). So, it seemed to be worth
fixing alongside with the other fixes, even if it does not directly impact
functionality if it is applied or not (until someone else comes along,
also gets confused and introduces another bug...).

Thanks,
Florian

  parent reply	other threads:[~2023-07-02 19:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-19 10:08 [PATCH net v2 0/6] igc: Fix corner cases for TSN offload Florian Kauer
2023-06-19 10:08 ` [PATCH net v2 1/6] igc: Rename qbv_enable to taprio_offload_enable Florian Kauer
2023-07-02 13:42   ` [Intel-wired-lan] " naamax.meir
     [not found]   ` <36b57ea5-baff-f964-3088-e1b186532cfe@web.de>
2023-07-02 19:17     ` Florian Kauer [this message]
2023-06-19 10:08 ` [PATCH net v2 2/6] igc: Do not enable taprio offload for invalid arguments Florian Kauer
2023-07-03  8:34   ` [Intel-wired-lan] " naamax.meir
2023-06-19 10:08 ` [PATCH net v2 3/6] igc: Handle already enabled taprio offload for basetime 0 Florian Kauer
2023-07-04  5:28   ` [Intel-wired-lan] " naamax.meir
2023-06-19 10:08 ` [PATCH net v2 4/6] igc: No strict mode in pure launchtime/CBS offload Florian Kauer
2023-07-04  9:34   ` [Intel-wired-lan] " naamax.meir
2023-07-04  9:39   ` Paul Menzel
2023-06-19 10:08 ` [PATCH net v2 5/6] igc: Fix launchtime before start of cycle Florian Kauer
2023-07-05 11:06   ` [Intel-wired-lan] " naamax.meir
2023-06-19 10:08 ` [PATCH net v2 6/6] igc: Fix inserting of empty frame for launchtime Florian Kauer
2023-07-06 11:36   ` [Intel-wired-lan] " naamax.meir
2023-06-20 22:57 ` [PATCH net v2 0/6] igc: Fix corner cases for TSN offload Vinicius Costa Gomes
2023-06-21  0:17 ` Zulkifli, Muhammad Husaini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c02e976-0da6-8ed8-4546-4df7af4ebed5@linutronix.de \
    --to=florian.kauer@linutronix.de \
    --cc=Markus.Elfring@web.de \
    --cc=anthony.l.nguyen@intel.com \
    --cc=aravindhan.gunasekaran@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kuba@kernel.org \
    --cc=kurt@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mallikarjuna.chilakala@intel.com \
    --cc=muhammad.husaini.zulkifli@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tee.min.tan@linux.intel.com \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).