From: Javier Martinez Canillas <javierm@redhat.com>
To: Jani Nikula <jani.nikula@linux.intel.com>, linux-kernel@vger.kernel.org
Cc: "Michel Dänzer" <michel@daenzer.net>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Peter Robinson" <pbrobinson@gmail.com>,
"Pekka Paalanen" <pekka.paalanen@collabora.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Ben Skeggs" <bskeggs@redhat.com>,
"Chia-I Wu" <olvaffe@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Dave Airlie" <airlied@redhat.com>,
"David Airlie" <airlied@linux.ie>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Gurchetan Singh" <gurchetansingh@chromium.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"VMware Graphics" <linux-graphics-maintainer@vmware.com>,
"Zack Rusin" <zackr@vmware.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
intel-gfx@lists.freedesktop.org, nouveau@lists.freedesktop.org,
spice-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org
Subject: Re: [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled
Date: Thu, 4 Nov 2021 21:09:14 +0100 [thread overview]
Message-ID: <0c07f121-42d3-9f37-1e14-842fb685b501@redhat.com> (raw)
In-Reply-To: <87ilx7ae3v.fsf@intel.com>
Hello Jani,
On 11/4/21 20:57, Jani Nikula wrote:
> On Thu, 04 Nov 2021, Javier Martinez Canillas <javierm@redhat.com> wrote:
>> +/**
>> + * drm_drv_enabled - Checks if a DRM driver can be enabled
>> + * @driver: DRM driver to check
>> + *
>> + * Checks whether a DRM driver can be enabled or not. This may be the case
>> + * if the "nomodeset" kernel command line parameter is used.
>> + *
>> + * Return: 0 on success or a negative error code on failure.
>> + */
>> +int drm_drv_enabled(const struct drm_driver *driver)
>> +{
>> + if (vgacon_text_force()) {
>> + DRM_INFO("%s driver is disabled\n", driver->name);
>> + return -ENODEV;
>> + }
>> +
>> + return 0;
>> +}
>> +EXPORT_SYMBOL(drm_drv_enabled);
>
> The name implies a bool return, but it's not.
>
> if (drm_drv_enabled(...)) {
> /* surprise, it's disabled! */
> }
>
It used to return a bool in v2 but Thomas suggested an int instead to
have consistency on the errno code that was returned by the callers.
I should probably name that function differently to avoid confusion.
But I think you are correct and this change is caused too much churn
for not that much benefit, specially since is unclear that there might
be another condition to prevent a DRM driver to load besides nomodeset.
I'll just drop this patch and post only #2 but making drivers to test
using the drm_check_modeset() function (which doesn't have a name that
implies a bool return).
>
> BR,
> Jani.
>
>
>
Best regards,
--
Javier Martinez Canillas
Linux Engineering
Red Hat
next prev parent reply other threads:[~2021-11-04 20:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-04 16:07 [PATCH v2 0/2] Cleanups for the nomodeset kernel command line parameter logic Javier Martinez Canillas
2021-11-04 16:07 ` [PATCH v2 1/2] drm: Add a drm_drv_enabled() to check if drivers should be enabled Javier Martinez Canillas
2021-11-04 16:24 ` Jani Nikula
2021-11-04 16:44 ` Javier Martinez Canillas
[not found] ` <YYQaYsCr+piMlRpS@ravnborg.org>
2021-11-04 17:57 ` Jani Nikula
2021-11-04 18:20 ` Javier Martinez Canillas
[not found] ` <YYQ0doL/F3ULjXyr@ravnborg.org>
2021-11-04 19:54 ` Jani Nikula
2021-11-04 19:57 ` Jani Nikula
2021-11-04 20:09 ` Javier Martinez Canillas [this message]
2021-11-05 8:43 ` Thomas Zimmermann
2021-11-05 9:48 ` Javier Martinez Canillas
2021-11-05 10:04 ` Jani Nikula
2021-11-05 12:00 ` Javier Martinez Canillas
2021-11-05 13:00 ` Thomas Zimmermann
2021-11-05 10:15 ` Thomas Zimmermann
2021-11-04 16:07 ` [PATCH v2 2/2] drm: Move nomodeset kernel parameter to the DRM subsystem Javier Martinez Canillas
2021-11-05 9:00 ` Thomas Zimmermann
2021-11-05 9:22 ` Jani Nikula
2021-11-05 9:39 ` Thomas Zimmermann
2021-11-05 9:58 ` Javier Martinez Canillas
2021-11-05 9:55 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c07f121-42d3-9f37-1e14-842fb685b501@redhat.com \
--to=javierm@redhat.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=gurchetansingh@chromium.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=kraxel@redhat.com \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michel@daenzer.net \
--cc=mripard@kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=olvaffe@gmail.com \
--cc=pbrobinson@gmail.com \
--cc=pekka.paalanen@collabora.com \
--cc=rodrigo.vivi@intel.com \
--cc=spice-devel@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
--cc=virtualization@lists.linux-foundation.org \
--cc=zackr@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).