* [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc()
@ 2021-03-03 2:40 angkery
2021-03-03 7:54 ` Roi Dayan
0 siblings, 1 reply; 3+ messages in thread
From: angkery @ 2021-03-03 2:40 UTC (permalink / raw)
To: saeedm, leon, davem, kuba, vladbu, dlinkin, roid, dan.carpenter
Cc: netdev, linux-rdma, linux-kernel, Junlin Yang
From: Junlin Yang <yangjunlin@yulong.com>
It is allocated with kvzalloc(), the corresponding release function
should not be kfree(), use kvfree() instead.
Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
---
drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
index 6f6772b..3da7bec 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
@@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw,
err_ethertype:
kfree(rule);
out:
- kfree(rule_spec);
+ kvfree(rule_spec);
return err;
}
@@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
e->recirc_cnt = 0;
out:
- kfree(in);
+ kvfree(in);
return err;
}
@@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
if (!spec) {
- kfree(in);
+ kvfree(in);
return -ENOMEM;
}
@@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
}
err_out:
- kfree(spec);
- kfree(in);
+ kvfree(spec);
+ kvfree(in);
return err;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc()
2021-03-03 2:40 [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc() angkery
@ 2021-03-03 7:54 ` Roi Dayan
2021-03-11 23:26 ` Saeed Mahameed
0 siblings, 1 reply; 3+ messages in thread
From: Roi Dayan @ 2021-03-03 7:54 UTC (permalink / raw)
To: angkery, saeedm, leon, davem, kuba, vladbu, dlinkin, dan.carpenter
Cc: netdev, linux-rdma, linux-kernel, Junlin Yang
On 2021-03-03 4:40 AM, angkery wrote:
> From: Junlin Yang <yangjunlin@yulong.com>
>
> It is allocated with kvzalloc(), the corresponding release function
> should not be kfree(), use kvfree() instead.
>
> Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
>
> Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> index 6f6772b..3da7bec 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct mlx5_eswitch *esw,
> err_ethertype:
> kfree(rule);
> out:
> - kfree(rule_spec);
> + kvfree(rule_spec);
> return err;
> }
>
> @@ -328,7 +328,7 @@ static int mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
> e->recirc_cnt = 0;
>
> out:
> - kfree(in);
> + kvfree(in);
> return err;
> }
>
> @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
>
> spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
> if (!spec) {
> - kfree(in);
> + kvfree(in);
> return -ENOMEM;
> }
>
> @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct mlx5_eswitch *esw,
> }
>
> err_out:
> - kfree(spec);
> - kfree(in);
> + kvfree(spec);
> + kvfree(in);
> return err;
> }
>
>
thanks!
Reviewed-by: Roi Dayan <roid@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc()
2021-03-03 7:54 ` Roi Dayan
@ 2021-03-11 23:26 ` Saeed Mahameed
0 siblings, 0 replies; 3+ messages in thread
From: Saeed Mahameed @ 2021-03-11 23:26 UTC (permalink / raw)
To: Roi Dayan, angkery, leon, davem, kuba, vladbu, dlinkin, dan.carpenter
Cc: netdev, linux-rdma, linux-kernel, Junlin Yang
On Wed, 2021-03-03 at 09:54 +0200, Roi Dayan wrote:
>
>
> On 2021-03-03 4:40 AM, angkery wrote:
> > From: Junlin Yang <yangjunlin@yulong.com>
> >
> > It is allocated with kvzalloc(), the corresponding release function
> > should not be kfree(), use kvfree() instead.
> >
> > Generated by: scripts/coccinelle/api/kfree_mismatch.cocci
> >
> > Signed-off-by: Junlin Yang <yangjunlin@yulong.com>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c | 10
> > +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git
> > a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > index 6f6772b..3da7bec 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/esw/indir_table.c
> > @@ -248,7 +248,7 @@ static int mlx5_esw_indir_table_rule_get(struct
> > mlx5_eswitch *esw,
> > err_ethertype:
> > kfree(rule);
> > out:
> > - kfree(rule_spec);
> > + kvfree(rule_spec);
> > return err;
> > }
> >
> > @@ -328,7 +328,7 @@ static int
> > mlx5_create_indir_recirc_group(struct mlx5_eswitch *esw,
> > e->recirc_cnt = 0;
> >
> > out:
> > - kfree(in);
> > + kvfree(in);
> > return err;
> > }
> >
> > @@ -347,7 +347,7 @@ static int mlx5_create_indir_fwd_group(struct
> > mlx5_eswitch *esw,
> >
> > spec = kvzalloc(sizeof(*spec), GFP_KERNEL);
> > if (!spec) {
> > - kfree(in);
> > + kvfree(in);
> > return -ENOMEM;
> > }
> >
> > @@ -371,8 +371,8 @@ static int mlx5_create_indir_fwd_group(struct
> > mlx5_eswitch *esw,
> > }
> >
> > err_out:
> > - kfree(spec);
> > - kfree(in);
> > + kvfree(spec);
> > + kvfree(in);
> > return err;
> > }
> >
> >
>
> thanks!
>
> Reviewed-by: Roi Dayan <roid@nvidia.com>
>
applied to net-next-mlx5
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-11 23:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-03 2:40 [PATCH] net/mlx5: use kvfree() for memory allocated with kvzalloc() angkery
2021-03-03 7:54 ` Roi Dayan
2021-03-11 23:26 ` Saeed Mahameed
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).