From: Christian Lamparter <chunkeey@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
kvalo@codeaurora.org, davem@davemloft.net, kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] carl9170: remove get_tid_h
Date: Fri, 2 Apr 2021 23:52:34 +0200 [thread overview]
Message-ID: <0c1b2ce3-f599-e2cc-9c5d-c01d77486f44@gmail.com> (raw)
In-Reply-To: <68efad7a597159e22771d37fc8b4a8a613866d60.1617399010.git.christophe.jaillet@wanadoo.fr>
On 02/04/2021 23:31, Christophe JAILLET wrote:
> 'get_tid_h()' is the same as 'ieee80211_get_tid()'.
> So this function can be removed to save a few lines of code.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
> ---
> drivers/net/wireless/ath/carl9170/carl9170.h | 7 +------
> drivers/net/wireless/ath/carl9170/tx.c | 2 +-
> 2 files changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/carl9170/carl9170.h b/drivers/net/wireless/ath/carl9170/carl9170.h
> index 0d38100d6e4f..84a8ce0784b1 100644
> --- a/drivers/net/wireless/ath/carl9170/carl9170.h
> +++ b/drivers/net/wireless/ath/carl9170/carl9170.h
> @@ -631,14 +631,9 @@ static inline u16 carl9170_get_seq(struct sk_buff *skb)
> return get_seq_h(carl9170_get_hdr(skb));
> }
>
> -static inline u16 get_tid_h(struct ieee80211_hdr *hdr)
> -{
> - return (ieee80211_get_qos_ctl(hdr))[0] & IEEE80211_QOS_CTL_TID_MASK;
> -}
> -
> static inline u16 carl9170_get_tid(struct sk_buff *skb)
> {
> - return get_tid_h(carl9170_get_hdr(skb));
> + return ieee80211_get_tid(carl9170_get_hdr(skb));
> }
>
> static inline struct ieee80211_vif *
> diff --git a/drivers/net/wireless/ath/carl9170/tx.c b/drivers/net/wireless/ath/carl9170/tx.c
> index 6b8446ff48c8..88444fe6d1c6 100644
> --- a/drivers/net/wireless/ath/carl9170/tx.c
> +++ b/drivers/net/wireless/ath/carl9170/tx.c
> @@ -394,7 +394,7 @@ static void carl9170_tx_status_process_ampdu(struct ar9170 *ar,
> if (unlikely(!sta))
> goto out_rcu;
>
> - tid = get_tid_h(hdr);
> + tid = ieee80211_get_tid(hdr);
>
> sta_info = (void *) sta->drv_priv;
> tid_info = rcu_dereference(sta_info->agg[tid]);
>
next prev parent reply other threads:[~2021-04-02 21:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 21:31 [PATCH] carl9170: remove get_tid_h Christophe JAILLET
2021-04-02 21:52 ` Christian Lamparter [this message]
2021-04-18 6:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c1b2ce3-f599-e2cc-9c5d-c01d77486f44@gmail.com \
--to=chunkeey@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).