From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791FCC352A3 for ; Thu, 13 Feb 2020 06:17:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A70220848 for ; Thu, 13 Feb 2020 06:17:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=c-s.fr header.i=@c-s.fr header.b="ul2SKyzo" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729715AbgBMGRE (ORCPT ); Thu, 13 Feb 2020 01:17:04 -0500 Received: from pegase1.c-s.fr ([93.17.236.30]:29375 "EHLO pegase1.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726368AbgBMGRE (ORCPT ); Thu, 13 Feb 2020 01:17:04 -0500 Received: from localhost (mailhub1-int [192.168.12.234]) by localhost (Postfix) with ESMTP id 48J5rY33mTz9txqP; Thu, 13 Feb 2020 07:17:01 +0100 (CET) Authentication-Results: localhost; dkim=pass reason="1024-bit key; insecure key" header.d=c-s.fr header.i=@c-s.fr header.b=ul2SKyzo; dkim-adsp=pass; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at c-s.fr Received: from pegase1.c-s.fr ([192.168.12.234]) by localhost (pegase1.c-s.fr [192.168.12.234]) (amavisd-new, port 10024) with ESMTP id KvByieqdrI0U; Thu, 13 Feb 2020 07:17:01 +0100 (CET) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase1.c-s.fr (Postfix) with ESMTP id 48J5rY20wZz9txqN; Thu, 13 Feb 2020 07:17:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=c-s.fr; s=mail; t=1581574621; bh=t/2LmfZnIqpmtmv0ZE2LPqev+yZwDWjNkrZOcNsg5jA=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ul2SKyzo22RtsN1ENKBOu2/8T6zDA40eJJI01PExJ/53pjfxhhPeMtFc+b0szVLKJ Qk6CtH21vNnbEZDD1RH5IOJXHTVMN0ct4YgTznrIb72dG2KtN1scQujj5YtnVHBksO HVgdYFujtQ2MuNBQ8lcSaxAZihgRw1IhDFUcHduE= Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 1F69B8B793; Thu, 13 Feb 2020 07:17:02 +0100 (CET) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id TYSyMjnOf7yr; Thu, 13 Feb 2020 07:17:02 +0100 (CET) Received: from [192.168.4.90] (unknown [192.168.4.90]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 815C38B752; Thu, 13 Feb 2020 07:17:01 +0100 (CET) Subject: Re: [Regression 5.6-rc1][Bisected b6231ea2b3c6] Powerpc 8xx doesn't boot anymore To: Qiang Zhao , Rasmus Villemoes , Leo Li , Greg Kroah-Hartman Cc: Scott Wood , "linuxppc-dev@lists.ozlabs.org" , LKML , "linux-arm-kernel@lists.infradead.org" References: <0d45fa64-51ee-0052-cb34-58c770c5b3ce@c-s.fr> From: Christophe Leroy Message-ID: <0c217693-7c73-1696-8a86-e81dbabefe02@c-s.fr> Date: Thu, 13 Feb 2020 07:17:01 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: fr Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 13/02/2020 à 04:35, Qiang Zhao a écrit : > On 02/12/2020 22:50 PM, Christophe Leroy wrote: >> -----Original Message----- >> From: Christophe Leroy >> Sent: 2020年2月12日 22:50 >> To: Rasmus Villemoes ; Leo Li >> ; Qiang Zhao ; Greg >> Kroah-Hartman >> Cc: Scott Wood ; linuxppc-dev@lists.ozlabs.org; LKML >> ; linux-arm-kernel@lists.infradead.org >> Subject: Re: [Regression 5.6-rc1][Bisected b6231ea2b3c6] Powerpc 8xx doesn't >> boot anymore >> >> --- >> diff --git a/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> b/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> index 4cabded8390b..341d682ec6eb 100644 >> --- a/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> +++ b/drivers/tty/serial/cpm_uart/cpm_uart_core.c >> @@ -1351,6 +1351,7 @@ static int __init cpm_uart_console_setup(struct >> console *co, char *options) >> clrbits32(&pinfo->sccp->scc_gsmrl, SCC_GSMRL_ENR | >> SCC_GSMRL_ENT); >> } >> >> + cpm_muram_init(); >> ret = cpm_uart_allocbuf(pinfo, 1); >> >> if (ret) >> > How about the patch like below? Just a draft. Yes, I see the idea. I think we could go for something like that. But in the powerpc 8xx case, we are talking about cpm_init(), not qe_init(). And maybe the return code should be checked, because if it's not 0, cpm_muram_init() won't have been called. Thanks, Christophe