From: Tom Rix <trix@redhat.com>
To: richard.gong@linux.intel.com, gregkh@linuxfoundation.org
Cc: mdf@kernel.org, linux-kernel@vger.kernel.org,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
Date: Wed, 27 Jan 2021 14:00:06 -0800 [thread overview]
Message-ID: <0c4ec1b0-120e-5704-4b4f-d4255f2e84c0@redhat.com> (raw)
In-Reply-To: <1611783801-30766-2-git-send-email-richard.gong@linux.intel.com>
On 1/27/21 1:43 PM, richard.gong@linux.intel.com wrote:
> From: Richard Gong <richard.gong@intel.com>
>
> Clean up COMMAND_RECONFIG_FLAG_PARTIAL flag by resetting it to 0, which
> aligns with the firmware settings.
For fixes, you need to have a 'Fixes: ... ' line in the comment.
This lets folks doing the stable branch know how far back to apply the fix.
For this case, this is likely
Fixes: 36847f9e3e56 ("firmware: stratix10-svc: correct reconfig flag and timeout values")
This should go right above your signoff.
By stand alone patch, this change should be split out from your current
[PATCHv3 1/6] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
So the next rev out your patch set will have 7 patches, because 1/6 is being split into two patches.
I would recommend the fix be 1/7, to minimize chance of conflicts merging it with stable.
or
submit the split out fix first.
Tom
>
> Signed-off-by: Richard Gong <richard.gong@intel.com>
> ---
> include/linux/firmware/intel/stratix10-svc-client.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/firmware/intel/stratix10-svc-client.h b/include/linux/firmware/intel/stratix10-svc-client.h
> index ebc2956..1ffb982 100644
> --- a/include/linux/firmware/intel/stratix10-svc-client.h
> +++ b/include/linux/firmware/intel/stratix10-svc-client.h
> @@ -51,12 +51,12 @@
> #define SVC_STATUS_NO_SUPPORT 6
>
> /*
> - * Flag bit for COMMAND_RECONFIG
> + * Flag for COMMAND_RECONFIG, in bit number
> *
> * COMMAND_RECONFIG_FLAG_PARTIAL:
> - * Set to FPGA configuration type (full or partial).
> + * Set for partial configuration.
> */
> -#define COMMAND_RECONFIG_FLAG_PARTIAL 1
> +#define COMMAND_RECONFIG_FLAG_PARTIAL 0
>
> /*
> * Timeout settings for service clients:
next prev parent reply other threads:[~2021-01-27 22:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 21:43 [PATCHv1] firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0 richard.gong
2021-01-27 21:43 ` richard.gong
2021-01-27 22:00 ` Tom Rix [this message]
2021-01-28 8:01 ` Greg KH
2021-01-28 8:00 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4ec1b0-120e-5704-4b4f-d4255f2e84c0@redhat.com \
--to=trix@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).