From: hejianet <hejianet@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, linux-sctp@vger.kernel.org,
linux-kernel@vger.kernel.org, davem@davemloft.net,
Alexey Kuznetsov <kuznet@ms2.inr.ac.ru>,
James Morris <jmorris@namei.org>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
Patrick McHardy <kaber@trash.net>,
Vlad Yasevich <vyasevich@gmail.com>,
Neil Horman <nhorman@tuxdriver.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show
Date: Tue, 30 Aug 2016 16:15:36 +0800 [thread overview]
Message-ID: <0c4f4f45-ec27-d1d3-45f8-a7ed8a4ca667@gmail.com> (raw)
In-Reply-To: <1472488885.14381.260.camel@edumazet-glaptop3.roam.corp.google.com>
Hi Eric
On 8/30/16 12:41 AM, Eric Dumazet wrote:
> On Tue, 2016-08-30 at 00:03 +0800, Jia He wrote:
>> This patch exchanges the two loop for collecting the percpu statistics
>> data. This can aggregate the data by going through all the items of each
>> cpu sequentially. In snmp_seq_show, just use one buff copy to dislay the
>> Udp and UdpLite data because they are the same.
> This is obviously not true.
>
> On my laptop it seems it handled no UdpLite frames, but got plenty of
> Udp ones.
>
> $ grep Udp /proc/net/snmp
> Udp: InDatagrams NoPorts InErrors OutDatagrams RcvbufErrors SndbufErrors InCsumErrors
> Udp: 1555889 108318 0 3740780 0 0 0
> UdpLite: InDatagrams NoPorts InErrors OutDatagrams RcvbufErrors SndbufErrors InCsumErrors
> UdpLite: 0 0 0 0 0 0 0
Thanks, you are right. I misunderstand the comments of source codes.
Will resend it
B.R.
Jia
>
>
>
> .
>
next prev parent reply other threads:[~2016-08-30 8:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 16:03 [RFC PATCH 0/6] Reduce cache miss for snmp_fold_field Jia He
2016-08-29 16:03 ` [RFC PATCH 1/6] proc: Reduce cache miss in {snmp,netstat}_seq_show Jia He
2016-08-29 16:41 ` Eric Dumazet
2016-08-30 8:15 ` hejianet [this message]
2016-08-29 16:03 ` [RFC PATCH 2/6] proc: Reduce cache miss in snmp6_seq_show Jia He
2016-08-29 16:03 ` [RFC PATCH 3/6] proc: Reduce cache miss in sctp_snmp_seq_show Jia He
2016-08-29 16:03 ` [RFC PATCH 4/6] proc: Reduce cache miss in xfrm_statistics_seq_show Jia He
2016-08-29 16:03 ` [RFC PATCH 5/6] ipv6: Remove useless parameter in __snmp6_fill_statsdev Jia He
2016-08-29 16:04 ` [RFC PATCH 6/6] net: Suppress the "Comparison to NULL Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c4f4f45-ec27-d1d3-45f8-a7ed8a4ca667@gmail.com \
--to=hejianet@gmail.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sctp@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=steffen.klassert@secunet.com \
--cc=vyasevich@gmail.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).