linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: Yuya Kusakabe <yuya.kusakabe@gmail.com>
Cc: ast@kernel.org, daniel@iogearbox.net, davem@davemloft.net,
	hawk@kernel.org, john.fastabend@gmail.com, kafai@fb.com,
	mst@redhat.com, songliubraving@fb.com, yhs@fb.com,
	kuba@kernel.org, andriin@fb.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v4] virtio_net: add XDP meta data support
Date: Thu, 6 Feb 2020 11:20:24 +0800	[thread overview]
Message-ID: <0c5eaba2-dd5a-fc3f-0e8f-154f7ad52881@redhat.com> (raw)
In-Reply-To: <1100837f-075f-dc97-cd14-758c96f2ac1d@gmail.com>


On 2020/2/5 下午5:18, Yuya Kusakabe wrote:
>>>            case XDP_TX:
>>>                stats->xdp_tx++;
>>> +            xdp.data_meta = xdp.data;
>> Any reason for doing this?
> XDP_TX can not support metadata for now, because if metasize > 0, __virtnet_xdp_xmit_one() returns EOPNOTSUPP.
>
> static int __virtnet_xdp_xmit_one(struct virtnet_info *vi,
> 				   struct send_queue *sq,
> 				   struct xdp_frame *xdpf)
> {
> 	struct virtio_net_hdr_mrg_rxbuf *hdr;
> 	int err;
>
> 	/* virtqueue want to use data area in-front of packet */
> 	if (unlikely(xdpf->metasize > 0))
> 		return -EOPNOTSUPP;
>
>

I see.

Then I think it's better to fix __virtnet_xdp_xmit_one() instead.

Thanks



  reply	other threads:[~2020-02-06  3:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <8da1b560-3128-b885-b453-13de5c7431fb@redhat.com>
2020-02-04  7:16 ` [PATCH bpf-next v4] virtio_net: add XDP meta data support Yuya Kusakabe
2020-02-05  4:10   ` Jason Wang
2020-02-05  9:18     ` Yuya Kusakabe
2020-02-06  3:20       ` Jason Wang [this message]
2020-02-20  8:55         ` [PATCH bpf-next v5] " Yuya Kusakabe
2020-02-21  4:23           ` Jason Wang
2020-02-21  8:36             ` Yuya Kusakabe
2020-02-21 11:01               ` Michael S. Tsirkin
2020-02-23  8:14               ` Michael S. Tsirkin
2020-02-24  4:05                 ` Jason Wang
2020-02-25  0:52                   ` Yuya Kusakabe
2020-02-05  5:33   ` [PATCH bpf-next v4] " Michael S. Tsirkin
2020-02-05  9:19     ` Yuya Kusakabe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c5eaba2-dd5a-fc3f-0e8f-154f7ad52881@redhat.com \
    --to=jasowang@redhat.com \
    --cc=andriin@fb.com \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=john.fastabend@gmail.com \
    --cc=kafai@fb.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    --cc=yuya.kusakabe@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).