linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: James Hilliard <james.hilliard1@gmail.com>,
	dri-devel@lists.freedesktop.org
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>,
	David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] drm/gma500: depend on framebuffer
Date: Fri, 8 Apr 2022 21:12:55 -0700	[thread overview]
Message-ID: <0c679837-379a-c3be-9fe5-865b675410de@infradead.org> (raw)
In-Reply-To: <20220409034418.3182706-1-james.hilliard1@gmail.com>



On 4/8/22 20:44, James Hilliard wrote:
> This appears to be needed for video output to function correctly.
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> Changes v1 -> v2:
>   - use depends instead of select

Thanks.

> ---
>  drivers/gpu/drm/gma500/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/gma500/Kconfig b/drivers/gpu/drm/gma500/Kconfig
> index 0cff20265f97..8ea87bfa95f5 100644
> --- a/drivers/gpu/drm/gma500/Kconfig
> +++ b/drivers/gpu/drm/gma500/Kconfig
> @@ -2,6 +2,8 @@
>  config DRM_GMA500
>  	tristate "Intel GMA500/600/3600/3650 KMS Framebuffer"
>  	depends on DRM && PCI && X86 && MMU
> +	depends on FB
> +	depends on FB_EFI || !EFI

I'm OK with the second line of the first patch:

+	select FB_EFI if EFI

It's just that a single driver shouldn't enable an entire subsystem (like FB)
on its own. But once FB is set (depends on in this patch), selecting
FB_EFI would be OK IMO.

>  	select DRM_KMS_HELPER
>  	# GMA500 depends on ACPI_VIDEO when ACPI is enabled, just like i915
>  	select ACPI_VIDEO if ACPI

-- 
~Randy

      reply	other threads:[~2022-04-09  4:13 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-09  3:44 [PATCH v2] drm/gma500: depend on framebuffer James Hilliard
2022-04-09  4:12 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c679837-379a-c3be-9fe5-865b675410de@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=james.hilliard1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=patrik.r.jakobsson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).