From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030572AbdDSSE3 (ORCPT ); Wed, 19 Apr 2017 14:04:29 -0400 Received: from mail-sn1nam02on0065.outbound.protection.outlook.com ([104.47.36.65]:46322 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030255AbdDSSEY (ORCPT ); Wed, 19 Apr 2017 14:04:24 -0400 Authentication-Results: vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=none action=none header.from=cnexlabs.com; Subject: Re: [PATCH] lightnvm: assume 64-bit lba numbers To: Arnd Bergmann , Matias Bjorling References: <20170419173931.3902058-1-arnd@arndb.de> CC: =?UTF-8?Q?Javier_Gonz=c3=a1lez?= , Jens Axboe , , From: =?UTF-8?Q?Matias_Bj=c3=b8rling?= Message-ID: <0c7f0894-4817-09c4-93b9-8158bbc6a562@cnexlabs.com> Date: Wed, 19 Apr 2017 20:04:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <20170419173931.3902058-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [188.176.29.198] X-ClientProxiedBy: DB6PR0202CA0018.eurprd02.prod.outlook.com (10.169.218.28) To CY4PR06MB2775.namprd06.prod.outlook.com (10.175.117.143) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ad6530c6-6070-46d7-a99c-08d4874e81d0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(201703131423075)(201703031133081);SRVR:CY4PR06MB2775; X-Microsoft-Exchange-Diagnostics: 1;CY4PR06MB2775;3:J0HsJeYO7X0wYpM0fh11C/vt32CpCohHyvl88Bai3RBnF91rMB1hLLwkb4T8JSCz7skhQSRefddMQ2a2DJTuLedQbMPeTrnnwDLYOHJs8d7mCgiya8nNqtGbxe+rwMs1uOa+gBZucvx+S7zmR3EjSf9xrTZoAKdzef5UxKQXLyJ41oMN0DClxVhn6mgilKmfFVIjMuhT6SptSDZWvSzXazAi4AU+WD3SDij2+XAAq10wBncICy6GPeXQLvImRilAD0qMIxyiKvOHl9lP+KNvUNIW0CJgkXop+uDqWLmL84owOrtsFGelHdwNepzM/4r4CwuWsGkie/2g+B9GiAClhQ==;25:/rn2PALQdx3gndXt6iSXD3v18QasyYk4vZSOE4dL9uyQjONZ92OGhV6fBIAXT+C9c5eGiL7vCfGGp5rGBDnaYIsoVTQbW8VSPwLHiruANxMZeVWxDzS/Rk7lRFK5y4th4Q3/d3PosVe8tHIaIAwgshfwojJj2FSLBJT/a8ebVtb2ZKAtt/ovR9KufZUNmY87ve2XNcRxwCErd5eSOaQSB9unZ+IfuzdCnQHIk8AYh18k6o9lveB1aCcom2042ed1lGOohH3MIiz3lohDdYDyLTe7X6PaEr8adU8CLE/969yk9Qz3AsTIKp8tDBwkKJWsP5Ii3Zm7SSe8pqlYErM4rdmW3O0Y+0o8FBWXN6n+0zBHnWp5hzeK1IfVzypNUJ+eXiYi6Z+wME7qjiFENRgkazznoPu6P7p42joO7ebrgLmJ92rSAQEkoGnmG8SKeYMoL/Zku+WCersErUGbnfFIww== X-Microsoft-Exchange-Diagnostics: 1;CY4PR06MB2775;31:JmO9ZSipJ/9D7Z/G0lxbXXpckU1k6kCGx3hKT1cFSv/CDhMwgEvLrOkj0Bd8ANw6+VhTrYkmL3ujjjXuMWi18Ck2OHUGivMJHDyLmkgspLczd4Na7DWXkzBD3qRuoO3CvRtxssG1ziUw1KrNFngJO7L02Lc0V+/50X707tfGB2XAl5LnB0Z4+TxhcVw3mT6IEDwChUMcHa2H7QdMQjnWoscjGaUSZ2jcD89DAOcWTEjovdeY42MTBIElxzYS1CbrCoCHJx8cooX8z3r+roc1ig==;20:M1MiKsNW44NdzELBbh9Ww+wVKdJtpAxSwq/oR1HBnUhItWe7yhuygH8geU0mxequVrvegkzgvxlMlt2crMrITl3kqGsSq9hbV0VqYDZir05NZJ2Z3d9ikb7Eim0PsTGXbtAI4G835ompUU5D0+7ha1MNmoYhwEbse9vaqiL6Ib4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123564025)(20161123562025)(6072148);SRVR:CY4PR06MB2775;BCL:0;PCL:0;RULEID:;SRVR:CY4PR06MB2775; X-Microsoft-Exchange-Diagnostics: 1;CY4PR06MB2775;4:peDl2QPFXq5CUFwLMCfTC29makzBGLSs91R8dTlupCKiOA4WsaBem9JIt6oJ4vTC35+R2qGa2heSwZvdZrpxDMy7j2JNBIKsxhYdhrmQcgMgcHokpARHWGCW4y9NFtwGGhPelWB+Woe5Xc4YlskHqFl22z51tOrJUxV1+bautMH/xrImQZnoYXmYL/3juyKDrkDz0P3xHcMwkUWmUQiv9Z644vozrShKEkoAyGWSW/meruDzu9WeQPzMPRaaVdrr20wOgd7UEaomqkgWQSYwDuDQbuseG19PSNQVSjX7wVrWcj+k3epfeOJmiQ04DEB4DKMd9dpU8PyOkxnEwVqr2KL7uZ23TMfd8zFHygTsSqbq/84L1PZUcufx1iEQIb0zV6bZ4GRlRGu+u5HVjHI2Sate0o6bjCcCb3uETZoRKX7NqN4CGW7+jOTRCuJ2WOCu+LFi6R6oHRz4jsFuDtkXlWDNwAcCCtqd9nlvVRWNwJtXxNp0Of8PKwS1Ikr0K82NDBrqP4GxVW1AS/Tq2EztsfKNS+ZTcLX2k5yrRgINlXJv6Ys24ee4xjWPvplFUfWEuqktKOgz1Sf4U44mLC/dnMgZ5lp3ll39P5uTb8gDluJOlMxFrvJJTY5YFGEZ5npmfbzB+BD23Dn/YJDNXWrH9CqMIvgYpB8MNTxqUj0Ed9Zfm+GEJG6wZ7Kw2H4rLw3tr5rF/aW5boPdhzdQkDRbQg== X-Forefront-PRVS: 028256169F X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(6049001)(39830400002)(39450400003)(39410400002)(39400400002)(24454002)(377454003)(6116002)(3846002)(54906002)(6486002)(2950100002)(77096006)(90366009)(6666003)(305945005)(4001350100001)(50986999)(8676002)(54356999)(76176999)(86362001)(50466002)(189998001)(31696002)(81166006)(117156002)(65806001)(66066001)(65956001)(230700001)(53546009)(25786009)(36756003)(53936002)(229853002)(42186005)(2906002)(5660300001)(6246003)(83506001)(33646002)(4326008)(31686004)(65826007)(38730400002)(47776003);DIR:OUT;SFP:1101;SCL:1;SRVR:CY4PR06MB2775;H:[192.168.0.15];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY4PR06MB2775;23:v4TLMU3tbVYI7LJiEtA4MlSXcV9/ORTKKz2z8?= =?Windows-1252?Q?Q2DGtzsXhfmAOS5LDnPgHHRqgB/FiCrcYwZEs+1TvHSltBl1kxFd0XpN?= =?Windows-1252?Q?U7mHy3juUi+MLegJ8BRT5BfHZzTssnl1FbVxI+WuCo05nfjzPhl+6D/1?= =?Windows-1252?Q?/b2y86pSB5YWmk2Uj9nGPPn3IVhwlFYh2T/F6Y+bmGIFgSSv/5dckWhd?= =?Windows-1252?Q?4VhgshaEux2fm9gr1ncDdIW61634IKyL47l1xawQkYj0A49wz62UWRLw?= =?Windows-1252?Q?iJ8727NI6rlDwbwllZilJM/rDQGI+6TW7IFH/dHaPhPWfqyHDcDFAXk+?= =?Windows-1252?Q?4XyI8jI7a1odi5xiMuX/OAMFMeVpy2r/N/Jf54pEsvAp1GLg4f/UAU2J?= =?Windows-1252?Q?130Bl4RNo1kR3xmJpoJYezjg8jgKaHbgG+lHElt64aek+24lkPuMNAn8?= =?Windows-1252?Q?qrgd7enLttw7nCAQLpeIz5Z1v+bnr9mxTA1WjAvE8zYr0rYbfHiykMDW?= =?Windows-1252?Q?IEbcirTyKWHEyy/s9c08XidqwYLWgOdGwmp5QsH5ambL/MGab8n9dKka?= =?Windows-1252?Q?nN26H6PDHO4zIEWEM1npPKY9aVf6p/FS52VxnkBtrlKA7wSJPF51jfOJ?= =?Windows-1252?Q?Hve5I/W3d+3rxUI6utCx2wFIG68ZM0A7UJ/DkNsdj3ONg1W6xa6s0y5S?= =?Windows-1252?Q?QQqTRwpdc1GHuDjhhW2I18WMWa+gLRT1l5M8xt6zq9PwelmTn/q7lLCX?= =?Windows-1252?Q?KNOUTvomBTEdKiCerwh832GuxgyUCEIzS0GmWbHQTdxoEG26KQ3xSwQO?= =?Windows-1252?Q?2heTdSV/8B1cIdK30pof1BD7iFxBTefy8UD69gDRSXdSmjzokLdk81MR?= =?Windows-1252?Q?Kgy9x7VmHntpOwU6xs+tCzF+ax8mzBqvrn36ckJYX/ZhkVnMXKTnt1SS?= =?Windows-1252?Q?z3tUkAP+0+8lxNcfLEy1lQOT5Maty4hmpUCjo9b+h8BR60KvdoO6Fx0+?= =?Windows-1252?Q?fztL7XHoc0t6543PfHwFJ0N4ownYrlr1c045V6kqweAIelfLhGaFHi5/?= =?Windows-1252?Q?hPxuxjhJSGjDMcIZCnTs2JfrYTXCsFz7e5gNI3mh/khDK3JrwUxTt1cd?= =?Windows-1252?Q?pDiTfE8guHwJvvHgYudL3PDpCKJ1k+I4yT6lPUWXf6g/ApqUY5SDjXBL?= =?Windows-1252?Q?cqL7+Lvje/LvpMB94QMBpG6LMffiFMFobEfIvjEKcuAS8LgF4Zo7NfZ+?= =?Windows-1252?Q?jL/xu/KzQolEoKKiDHDNiNeMFqBijdsr3eZ/91D/p11F13sjJsLKCvIE?= =?Windows-1252?Q?gdveNaPlQ/kAj9c+EeQFY3yUg=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;CY4PR06MB2775;6:HzPDnAlB39FEGqbf087X/e4eSNzGH+dL9c/DssvnqF0cogJiTzwn4pMwG5ugS5UWZZl4eyCj5i2VhFsjBxvcgEScI8VifO9AKE+1P9vORhH/G0BM/16ctv1ankpXvyQw7lOqJGsUqcdWlWJ8mG+T8qFRCswhA4uTsNd/i1B+QIb3OYAAOaVCZcDVJ3f7FD7dNqEf7ASc5sMLc56QIADdtFgRxvVFsWCAmg5nqDUGYiIgHCKNGYokjlNZi60vBNH8shD9qMo8IQK46GJk0jrM4LwNz2suVvODDjKuHeZLO6BQxNhGHpPwiOnp/wezX5P63toQ1AduQNoUsiZBAc4yItAfjTlLpGR6Etsla7Zdr/o2esaV7F4YUVxGnPbrfR2yE3KDjOE54KlvcucEiUMcqgGcyluCzT1XaQcNIUjk1tuf9h28kzDBdzSsVJE1NrYUOt3QVNQhrjrV1As+lYxkBxgHoPnsQ1x7KRI4qjeKD3JhAGDm75XtHF+60LuJ/+4HtFRDOYuM7LZ/GDge1igRWg==;5:4Jow/xgKx4SHHiBoUvKDLDbxAzFAWF5HMiCygFQL1gsG1UlodtFvOgkcCgA5Q/EjeKnCVopNzaXwx+ieIJZhprJsUM6iw0tz86vchQxQ/0qIgLiR0bXsAZPKl8TRFYz4MC7IkR2tmv0RJxRgsGyCjA==;24:zMqXK59dKo9BeZgKk44F6ciG0W0FxzQhBS+yB5qzQ3p3o9WkdFUpBVTibfNjq+Sv3P444NkMfkkg+lZjyloEztIBWv4jcIIxEvdneJF3gKk= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY4PR06MB2775;7:+qiHNHro6Z6lkPb9RAJUyMa0edcKKTC9PxDdgZrRAyQr5W6OBUryu/8TJaVJ/GWwxb9ICmYRVxgJ6R2bNKRnbfQwqTsY++AHvdCwxgW1PP3r5Ew2XQBLzx5LgfcJ6+MoruFXkzy0kgogvZY5c5rESewRSK7+7cdM3IYcsPBGeIx+RJphJbwFTYQ0JCqYj1zSEO3N6dtSXHCeyo1z8LhLCIJj4VfA/2YFK98qSkuksnuqFK0gf7FjItkM0BwZKtT30O29TnQtGFWhvRyIZFKAfu8n17AMxtpDXk/UuyigqbZ+b//C0TkpPbYKg+OwPa+rL/KWwYKsKeUC9d6FBmGRkg== X-OriginatorOrg: cnexlabs.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Apr 2017 18:04:20.8406 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR06MB2775 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/19/2017 07:39 PM, Arnd Bergmann wrote: > The driver uses both u64 and sector_t to refer to offsets, and assigns between the > two. This causes one harmless warning when sector_t is 32-bit: > > drivers/lightnvm/pblk-rb.c: In function 'pblk_rb_write_entry_gc': > include/linux/lightnvm.h:215:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow] > drivers/lightnvm/pblk-rb.c:324:22: note: in expansion of macro 'ADDR_EMPTY' > > As the driver is already doing this inconsistently, changing the type > won't make it worse and is an easy way to avoid the warning. > > Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target") > Signed-off-by: Arnd Bergmann > --- > drivers/lightnvm/pblk.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/lightnvm/pblk.h b/drivers/lightnvm/pblk.h > index c82120ce3be5..11ed7d83f572 100644 > --- a/drivers/lightnvm/pblk.h > +++ b/drivers/lightnvm/pblk.h > @@ -119,7 +119,7 @@ struct pblk_w_ctx { > struct bio_list bios; /* Original bios - used for completion > * in REQ_FUA, REQ_FLUSH case > */ > - sector_t lba; /* Logic addr. associated with entry */ > + u64 lba; /* Logic addr. associated with entry */ > struct ppa_addr ppa; /* Physic addr. associated with entry */ > int flags; /* Write context flags */ > }; > Thanks Arnd. Jens, could you pick this up? Thank you