From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECF2CCA473 for ; Fri, 22 Jul 2022 18:47:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236438AbiGVSrc (ORCPT ); Fri, 22 Jul 2022 14:47:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236405AbiGVSra (ORCPT ); Fri, 22 Jul 2022 14:47:30 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 79A31A896B for ; Fri, 22 Jul 2022 11:47:28 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id u19so9109320lfs.0 for ; Fri, 22 Jul 2022 11:47:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=U22qzag195P6poqQ9YYa+uEVyc9cDqkoMr+eaz+PhMc=; b=Zci6tL+2Nmq6YTC9QHfY38requX/5zX5FmKQyas6HvycvQJ/OONELujZBadrdvTpXH btD6GQ9/nt/N7RjIrZa7GNxVhd03zCSP49VXmSVNGQRaVCJQFkY/wRQPAFFwB1OmqM71 q4URy+H5OwUOfgQrmhdDAqOinMX55+WeZxjHMy+95bI3T7Sfxlx8WzDkQcoB+8/pnaj8 VwZud/6ltJZ/6517h+UyWNqDSrDPWXz5lGd0rFgdF0l5yVmNfPfRSZJs3eL4NGV+i2Ra j/s4TKDWFUXqAG30+mVUzU2yjaxiXcfEoir6j4aRvxa2Bbd5kJhD0n013N86GqpCe2n9 6zUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=U22qzag195P6poqQ9YYa+uEVyc9cDqkoMr+eaz+PhMc=; b=6OWVYJRPw7qeT02wBBh2govo04wfL2rVz7z6XtNyi44CsIeWCFOsYJQ8Quv3XeiG/w 97wzd5hEBF0I+qCUZidqmASminrVDcVtzu5yRM5TBTgu6S+Fa8kliG7d/V7hjHJWUHAW 4XkUq2em/tWBSBZQfF/EgefwILXXvz4lsATbhEeiWB6wMsWuaFgC+KL+mCXgGuPEfvcy T9oJUGrrfLxAE/W4x3s8D7YRXgVg71Vsv/kdHfmjWMQRLR8nodLeau44B6QMsJ/PEz7J siHmFIsQmgDcfM0J9C534H1rkZL3T6kCuOpWTeBqe41kyL+1EiEkRHHg0Tu4hfWAwS4A KlYg== X-Gm-Message-State: AJIora9whOQnBRB8nScBKmasWQNoKeKESw7u89ce5tzETnmvuDw0wAx8 Hk9o8Ty3MiFwSOD+k+L3wSW6pw== X-Google-Smtp-Source: AGRyM1vB2jdgHrEy7sFIqTrDp31QM+2NOeu6hjTLq6AkzkWTmJMdLvT61byh7LBQKzk65KoRRkyVgw== X-Received: by 2002:a05:6512:a8e:b0:48a:7513:6d83 with SMTP id m14-20020a0565120a8e00b0048a75136d83mr539808lfu.56.1658515646850; Fri, 22 Jul 2022 11:47:26 -0700 (PDT) Received: from [192.168.10.173] (93.81-167-86.customer.lyse.net. [81.167.86.93]) by smtp.gmail.com with ESMTPSA id s13-20020a056512202d00b00489dedf1dcfsm1185377lfs.289.2022.07.22.11.47.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 11:47:26 -0700 (PDT) Message-ID: <0c8688d5-b0c1-8cc1-ec27-292acbb38dfc@linaro.org> Date: Fri, 22 Jul 2022 20:47:24 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support Content-Language: en-US To: Mark Brown Cc: Tomer Maimon , avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au, venture@google.com, yuenn@google.com, benjaminfair@google.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, openbmc@lists.ozlabs.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20220722114136.251415-1-tmaimon77@gmail.com> <20220722114136.251415-3-tmaimon77@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/07/2022 20:43, Mark Brown wrote: > On Fri, Jul 22, 2022 at 08:31:22PM +0200, Krzysztof Kozlowski wrote: >> On 22/07/2022 13:41, Tomer Maimon wrote: > >>> static const struct of_device_id npcm_pspi_match[] = { >>> { .compatible = "nuvoton,npcm750-pspi", .data = NULL }, >>> + { .compatible = "nuvoton,npcm845-pspi", .data = NULL }, > >> The devices look compatible, so why not reusing 750 compatible and >> adding more specific upfront only in the bindings instead? > > ...with a fallback list required by the bindings so the driver actually > binds. Note that bindings are currently not in YAML format so there'd > be even less enforcement of that than normal, and as they're currently > written the bindings don't require fallback. Yes, the bindings document should be rephrased but we were living like that for few years. :) Best regards, Krzysztof