From: Phillip Lougher <phillip@squashfs.org.uk>
To: Xiaoming Ni <nixiaoming@huawei.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Cc: wangle6@huawei.com, yi.zhang@huawei.com, zhongjubin@huawei.com,
chenjianguo3@huawei.com
Subject: Re: [PATCH v6 0/2] squashfs: Add the mount parameter "threads="
Date: Thu, 27 Oct 2022 23:44:31 +0100 [thread overview]
Message-ID: <0c8d66ee-af80-1569-69c5-0c28723e148c@squashfs.org.uk> (raw)
In-Reply-To: <20221019030930.130456-1-nixiaoming@huawei.com>
On 19/10/2022 04:09, Xiaoming Ni wrote:
> Currently, Squashfs supports multiple decompressor parallel modes. However, this
> mode can be configured only during kernel building and does not support flexible
> selection during runtime.
>
> In the current patch set, the mount parameter "threads=" is added to allow users
> to select the parallel decompressor mode and configure the number of decompressors
> when mounting a file system.
>
> "threads=<single|multi|percpu|1|2|3|...>"
> The upper limit is num_online_cpus() * 2.
>
> v6: fix opt->thread_ops unassigned if CONFIG_SQUASHFS_CHOICE_DECOMP_BY_MOUNT is not set.
>
This version looks good to me. Thanks.
Reviewed-by: Phillip Lougher <phillip@squashfs.org.uk>
> v5: https://lore.kernel.org/lkml/20220930091406.50869-1-nixiaoming@huawei.com/
> fix a low-level mistake in patching:
> fs/squashfs/super.c:492:7: warning: "CONFIG_SQUASHFS_DECOMP_MULTI" is
> not defined, evaluates to 0 [-Wundef]
>
> v4: https://lore.kernel.org/lkml/20220916083604.33408-1-nixiaoming@huawei.com/
> Based on Philip Lougher's suggestion, make the following updates:
> 1. Use static modifiers to avoid changing symbol names.
> 2. Fixed some formatting issues
>
> v3: https://lore.kernel.org/lkml/20220902094855.22666-1-nixiaoming@huawei.com/
> Based on Philip Lougher's suggestion, make the following updates:
> 1. The default configuration is the same as that before the patch installation.
> 2. Compile the three decompression modes when the new configuration is enabled.
> 3. "threads=1" supports only the SQUASHFS_DECOMP_SINGLE mode.
>
> v2: https://lore.kernel.org/lkml/20220816010052.15764-1-nixiaoming@huawei.com/
> fix warning: sparse: incorrect type in initializer (different address spaces)
> Reported-by: kernel test robot <lkp@intel.com>
>
> v1: https://lore.kernel.org/lkml/20220815031100.75243-1-nixiaoming@huawei.com/
> *** BLURB HERE ***
>
> Xiaoming Ni (2):
> squashfs: add the mount parameter theads=<single|multi|percpu>
> squashfs: Allows users to configure the number of decompression
> threads
>
> fs/squashfs/Kconfig | 51 +++++++++++--
> fs/squashfs/block.c | 2 +-
> fs/squashfs/decompressor.c | 2 +-
> fs/squashfs/decompressor_multi.c | 20 +++--
> fs/squashfs/decompressor_multi_percpu.c | 23 ++++--
> fs/squashfs/decompressor_single.c | 15 +++-
> fs/squashfs/squashfs.h | 23 ++++--
> fs/squashfs/squashfs_fs_sb.h | 4 +-
> fs/squashfs/super.c | 97 ++++++++++++++++++++++++-
> 9 files changed, 203 insertions(+), 34 deletions(-)
>
prev parent reply other threads:[~2022-10-27 22:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 3:10 [PATCH 0/2] squashfs: Add the mount parameter "threads=" Xiaoming Ni
2022-08-15 3:10 ` [PATCH 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-08-15 11:19 ` kernel test robot
2022-08-15 3:11 ` [PATCH 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-08-16 1:00 ` [PATCH v2 0/2] squashfs: Add the mount parameter "threads=" Xiaoming Ni
2022-08-16 1:00 ` [PATCH v2 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-08-16 1:00 ` [PATCH v2 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-08-26 6:19 ` ping //Re: [PATCH v2 0/2] squashfs: Add the mount parameter "threads=" Xiaoming Ni
2022-08-28 23:18 ` Phillip Lougher
2022-08-30 13:38 ` Xiaoming Ni
2022-08-30 18:08 ` Phillip Lougher
2022-08-30 18:34 ` Phillip Lougher
2022-08-31 1:09 ` Xiaoming Ni
2022-09-02 9:48 ` [PATCH v3 " Xiaoming Ni
2022-09-02 9:48 ` [PATCH v3 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-09-09 15:44 ` Phillip Lougher
2022-09-13 2:46 ` Xiaoming Ni
2022-09-09 15:50 ` Phillip Lougher
2022-09-13 2:47 ` Xiaoming Ni
2022-09-02 9:48 ` [PATCH v3 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-09-09 15:26 ` [PATCH v3 0/2] squashfs: Add the mount parameter "threads=" Phillip Lougher
2022-09-16 8:36 ` [PATCH v4 " Xiaoming Ni
2022-09-16 8:36 ` [PATCH v4 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-09-28 2:20 ` Phillip Lougher
2022-09-28 3:06 ` Xiaoming Ni
2022-09-16 8:36 ` [PATCH v4 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-09-27 1:05 ` ping //Re: [PATCH v4 0/2] squashfs: Add the mount parameter "threads=" Xiaoming Ni
2022-09-30 9:14 ` [PATCH v5 " Xiaoming Ni
2022-09-30 9:14 ` [PATCH v5 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-10-17 21:58 ` Re " Phillip Lougher
2022-09-30 9:14 ` [PATCH v5 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-10-17 0:57 ` ping// Re: [PATCH v5 0/2] squashfs: Add the mount parameter "threads=" Xiaoming Ni
2022-10-17 22:59 ` Phillip Lougher
2022-10-18 6:24 ` Xiaoming Ni
2022-10-19 3:09 ` [PATCH v6 " Xiaoming Ni
2022-10-19 3:09 ` [PATCH v6 1/2] squashfs: add the mount parameter theads=<single|multi|percpu> Xiaoming Ni
2022-10-19 3:09 ` [PATCH v6 2/2] squashfs: Allows users to configure the number of decompression threads Xiaoming Ni
2022-10-27 22:44 ` Phillip Lougher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c8d66ee-af80-1569-69c5-0c28723e148c@squashfs.org.uk \
--to=phillip@squashfs.org.uk \
--cc=akpm@linux-foundation.org \
--cc=chenjianguo3@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
--cc=wangle6@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=zhongjubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).