From: Dan Murphy <dmurphy@ti.com>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
<robh+dt@kernel.org>, <pavel@ucw.cz>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-leds@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add bindings for lm3697 driver
Date: Thu, 16 Aug 2018 13:43:19 -0500 [thread overview]
Message-ID: <0c91fe1f-8ab4-8092-b8c2-a22f89f4b8ea@ti.com> (raw)
In-Reply-To: <aecaa2ff-e75c-2059-684a-908aedc20929@gmail.com>
Jacek
On 08/16/2018 01:37 PM, Jacek Anaszewski wrote:
> Hi Dan,
>
> Thanks for the update.
>
> I have one remark below.
>
> On 08/16/2018 07:20 PM, Dan Murphy wrote:
>> Add the device tree bindings for the lm3697
>> LED driver for backlighting and display.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v4 - Removed HVLED definition in favor of HVLED place definition - https://lore.kernel.org/patchwork/patch/974812/
>> v3 - Updated subject with prefered title - https://lore.kernel.org/patchwork/patch/972337/
>> v2 - Fixed subject and patch commit message - https://lore.kernel.org/patchwork/patch/971326/
>>
>> .../devicetree/bindings/leds/leds-lm3697.txt | 86 +++++++++++++++++++
>> 1 file changed, 86 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/leds/leds-lm3697.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3697.txt b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
>> new file mode 100644
>> index 000000000000..bcd67d53c889
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-lm3697.txt
>> @@ -0,0 +1,86 @@
>> +* Texas Instruments - LM3697 Highly Efficient White LED Driver
>> +
>> +The LM3697 11-bit LED driver provides high-
>> +performance backlight dimming for 1, 2, or 3 series
>> +LED strings while delivering up to 90% efficiency.
>> +
>> +This device is suitable for Display and Keypad Lighting
>> +
>> +Required properties:
>> + - compatible:
>> + "ti,lm3967"
>> + - reg : I2C slave address
>> + - #address-cells : 1
>> + - #size-cells : 0
>> +
>> +Optional properties:
>> + - enable-gpios : gpio pin to enable/disable the device.
>> + - vled-supply : LED supply
>> +
>> +Required child properties:
>> + - reg : 0 - LED is Controlled by bank A
>> + 1 - LED is Controlled by bank B
>> + - led-sources : Indicates which HVLED string is associated to which
>> + control bank. Each element in the array is associated
>> + with a specific HVLED string. Element 0 is HVLED1,
>> + element 1 is HVLED2 and element 2 HVLED3.
>> + Additional information is contained
>> + in Documentation/devicetree/bindings/leds/common.txt
>> + 0 - HVLED is not active in this control bank
>> + 1 - HVLED string is controlled by this control bank
>> +
>> +Optional child properties:
>> + - label : see Documentation/devicetree/bindings/leds/common.txt
>> + - linux,default-trigger :
>> + see Documentation/devicetree/bindings/leds/common.txt
>> +
>> +Example:
>> +
>> +HVLED string 1 and 2 controlled by control bank A and HVLED string controlled by
>
> s/1 and 2/1 and 3/
> s/HVLED string controller/HVLED string 2 controlled/
>
Thanks I will fix this up in v5 after the code review.
Dan
>> +control bank B.
>> +
>> +led-controller@36 {
>> + compatible = "ti,lm3967";
>> + reg = <0x36>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + led-sources = <1 0 1>;
>> + label = "white:first_backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +
>> + led@1 {
>> + reg = <1>;
>> + led-sources = <0 1 0>;
>> + label = "white:second_backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +}
>> +
>> +All HVLED strings controlled by control bank A
>> +
>> +led-controller@36 {
>> + compatible = "ti,lm3967";
>> + reg = <0x36>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>> + vled-supply = <&vbatt>;
>> +
>> + led@0 {
>> + reg = <0>;
>> + led-sources = <1 1 1>;
>> + label = "white:backlight_cluster";
>> + linux,default-trigger = "backlight";
>> + };
>> +}
>> +
>> +For more product information please see the link below:
>> +http://www.ti.com/lit/ds/symlink/lm3697.pdf
>>
>
--
------------------
Dan Murphy
prev parent reply other threads:[~2018-08-16 18:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 17:20 [PATCH v4 1/2] dt-bindings: leds: Add bindings for lm3697 driver Dan Murphy
2018-08-16 17:20 ` [PATCH v4 2/2] leds: lm3697: Introduce the " Dan Murphy
2018-08-16 19:58 ` Jacek Anaszewski
2018-08-16 20:44 ` Dan Murphy
2018-08-17 19:37 ` Jacek Anaszewski
2018-08-17 19:55 ` Dan Murphy
2018-08-16 18:37 ` [PATCH v4 1/2] dt-bindings: leds: Add bindings for " Jacek Anaszewski
2018-08-16 18:43 ` Dan Murphy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c91fe1f-8ab4-8092-b8c2-a22f89f4b8ea@ti.com \
--to=dmurphy@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).