From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5013FECAAD3 for ; Mon, 5 Sep 2022 10:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237620AbiIEKSS (ORCPT ); Mon, 5 Sep 2022 06:18:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237434AbiIEKRz (ORCPT ); Mon, 5 Sep 2022 06:17:55 -0400 Received: from out30-43.freemail.mail.aliyun.com (out30-43.freemail.mail.aliyun.com [115.124.30.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A40CC193D3 for ; Mon, 5 Sep 2022 03:16:47 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046051;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VOR5yVU_1662373002; Received: from 30.97.48.66(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VOR5yVU_1662373002) by smtp.aliyun-inc.com; Mon, 05 Sep 2022 18:16:43 +0800 Message-ID: <0c9d9774-77dd-fd93-b5b6-fc63f3d01b7f@linux.alibaba.com> Date: Mon, 5 Sep 2022 18:16:52 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] mm: gup: fix the fast GUP race against THP collapse To: David Hildenbrand , John Hubbard , Yang Shi , peterx@redhat.com, kirill.shutemov@linux.intel.com, jgg@nvidia.com, hughd@google.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20220901222707.477402-1-shy828301@gmail.com> From: Baolin Wang In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/5/2022 3:59 PM, David Hildenbrand wrote: > On 05.09.22 00:29, John Hubbard wrote: >> On 9/1/22 15:27, Yang Shi wrote: >>> Since general RCU GUP fast was introduced in commit 2667f50e8b81 ("mm: >>> introduce a general RCU get_user_pages_fast()"), a TLB flush is no >>> longer >>> sufficient to handle concurrent GUP-fast in all cases, it only handles >>> traditional IPI-based GUP-fast correctly.  On architectures that send >>> an IPI broadcast on TLB flush, it works as expected.  But on the >>> architectures that do not use IPI to broadcast TLB flush, it may have >>> the below race: >>> >>>     CPU A                                          CPU B >>> THP collapse                                     fast GUP >>>                                                gup_pmd_range() <-- >>> see valid pmd >>>                                                    gup_pte_range() >>> <-- work on pte >>> pmdp_collapse_flush() <-- clear pmd and flush >>> __collapse_huge_page_isolate() >>>      check page pinned <-- before GUP bump refcount >>>                                                        pin the page >>>                                                        check PTE <-- >>> no change >>> __collapse_huge_page_copy() >>>      copy data to huge page >>>      ptep_clear() >>> install huge pmd for the huge page >>>                                                        return the >>> stale page >>> discard the stale page >> >> Hi Yang, >> >> Thanks for taking the trouble to write down these notes. I always >> forget which race we are dealing with, and this is a great help. :) >> >> More... >> >>> >>> The race could be fixed by checking whether PMD is changed or not after >>> taking the page pin in fast GUP, just like what it does for PTE.  If the >>> PMD is changed it means there may be parallel THP collapse, so GUP >>> should back off. >>> >>> Also update the stale comment about serializing against fast GUP in >>> khugepaged. >>> >>> Fixes: 2667f50e8b81 ("mm: introduce a general RCU >>> get_user_pages_fast()") >>> Signed-off-by: Yang Shi >>> --- >>>   mm/gup.c        | 30 ++++++++++++++++++++++++------ >>>   mm/khugepaged.c | 10 ++++++---- >>>   2 files changed, 30 insertions(+), 10 deletions(-) >>> >>> diff --git a/mm/gup.c b/mm/gup.c >>> index f3fc1f08d90c..4365b2811269 100644 >>> --- a/mm/gup.c >>> +++ b/mm/gup.c >>> @@ -2380,8 +2380,9 @@ static void __maybe_unused undo_dev_pagemap(int >>> *nr, int nr_start, >>>   } >>>   #ifdef CONFIG_ARCH_HAS_PTE_SPECIAL >>> -static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned >>> long end, >>> -             unsigned int flags, struct page **pages, int *nr) >>> +static int gup_pte_range(pmd_t pmd, pmd_t *pmdp, unsigned long addr, >>> +             unsigned long end, unsigned int flags, >>> +             struct page **pages, int *nr) >>>   { >>>       struct dev_pagemap *pgmap = NULL; >>>       int nr_start = *nr, ret = 0; >>> @@ -2423,7 +2424,23 @@ static int gup_pte_range(pmd_t pmd, unsigned >>> long addr, unsigned long end, >>>               goto pte_unmap; >>>           } >>> -        if (unlikely(pte_val(pte) != pte_val(*ptep))) { >>> +        /* >>> +         * THP collapse conceptually does: >>> +         *   1. Clear and flush PMD >>> +         *   2. Check the base page refcount >>> +         *   3. Copy data to huge page >>> +         *   4. Clear PTE >>> +         *   5. Discard the base page >>> +         * >>> +         * So fast GUP may race with THP collapse then pin and >>> +         * return an old page since TLB flush is no longer sufficient >>> +         * to serialize against fast GUP. >>> +         * >>> +         * Check PMD, if it is changed just back off since it >>> +         * means there may be parallel THP collapse. >>> +         */ >> >> As I mentioned in the other thread, it would be a nice touch to move >> such discussion into the comment header. >> >>> +        if (unlikely(pmd_val(pmd) != pmd_val(*pmdp)) || >>> +            unlikely(pte_val(pte) != pte_val(*ptep))) { >> >> >> That should be READ_ONCE() for the *pmdp and *ptep reads. Because this >> whole lockless house of cards may fall apart if we try reading the >> page table values without READ_ONCE(). > > I came to the conclusion that the implicit memory barrier when grabbing > a reference on the page is sufficient such that we don't need READ_ONCE > here. IMHO the compiler may optimize the code 'pte_val(*ptep)' to be always get from a register, then we can get an old value if other thread did set_pte(). I am not sure how the implicit memory barrier can pervent the compiler optimization? Please correct me if I missed something. > If we still intend to change that code, we should fixup all GUP-fast > functions in a similar way. But again, I don't think we need a change here. > > >>> -     * After this gup_fast can't run anymore. This also removes >>> -     * any huge TLB entry from the CPU so we won't allow >>> -     * huge and small TLB entries for the same virtual address >>> -     * to avoid the risk of CPU bugs in that area. >>> +     * This removes any huge TLB entry from the CPU so we won't allow >>> +     * huge and small TLB entries for the same virtual address to >>> +     * avoid the risk of CPU bugs in that area. >>> +     * >>> +     * Parallel fast GUP is fine since fast GUP will back off when >>> +     * it detects PMD is changed. >>>        */ >>>       _pmd = pmdp_collapse_flush(vma, address, pmd); >> >> To follow up on David Hildenbrand's note about this in the nearby >> thread... >> I'm also not sure if pmdp_collapse_flush() implies a memory barrier on >> all arches. It definitely does do an atomic op with a return value on >> x86, >> but that's just one arch. >> > > I think a ptep/pmdp clear + TLB flush really has to imply a memory > barrier, otherwise TLB flushing code might easily mess up with > surrounding code. But we should better double-check. > > s390x executes an IDTE instruction, which performs serialization (-> > memory barrier). arm64 seems to use DSB instructions to enforce memory > ordering. >