* [PATCH net] bpf: sockmap remove dead check
@ 2018-04-20 16:16 Jann Horn
2018-04-20 20:13 ` Daniel Borkmann
0 siblings, 1 reply; 2+ messages in thread
From: Jann Horn @ 2018-04-20 16:16 UTC (permalink / raw)
To: ast, daniel, netdev, linux-kernel, john.fastabend, jannh
Cc: linux-kernel, John Fastabend
Remove dead code that bails on `attr->value_size > KMALLOC_MAX_SIZE` - the
previous check already bails on `attr->value_size != 4`.
Signed-off-by: Jann Horn <jannh@google.com>
---
kernel/bpf/sockmap.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/bpf/sockmap.c b/kernel/bpf/sockmap.c
index 8dd9210d7db7..a3b21385e947 100644
--- a/kernel/bpf/sockmap.c
+++ b/kernel/bpf/sockmap.c
@@ -1442,9 +1442,6 @@ static struct bpf_map *sock_map_alloc(union bpf_attr *attr)
attr->value_size != 4 || attr->map_flags & ~SOCK_CREATE_FLAG_MASK)
return ERR_PTR(-EINVAL);
- if (attr->value_size > KMALLOC_MAX_SIZE)
- return ERR_PTR(-E2BIG);
-
err = bpf_tcp_ulp_register();
if (err && err != -EEXIST)
return ERR_PTR(err);
--
2.17.0.484.g0c8726318c-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net] bpf: sockmap remove dead check
2018-04-20 16:16 [PATCH net] bpf: sockmap remove dead check Jann Horn
@ 2018-04-20 20:13 ` Daniel Borkmann
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Borkmann @ 2018-04-20 20:13 UTC (permalink / raw)
To: Jann Horn, ast, netdev, linux-kernel, john.fastabend
On 04/20/2018 06:16 PM, Jann Horn wrote:
> Remove dead code that bails on `attr->value_size > KMALLOC_MAX_SIZE` - the
> previous check already bails on `attr->value_size != 4`.
>
> Signed-off-by: Jann Horn <jannh@google.com>
Applied to bpf tree, thanks Jann!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-20 20:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20 16:16 [PATCH net] bpf: sockmap remove dead check Jann Horn
2018-04-20 20:13 ` Daniel Borkmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).