From: Lakshmi Ramasubramanian <nramas@linux.microsoft.com>
To: Mimi Zohar <zohar@linux.ibm.com>, linux-integrity@vger.kernel.org
Cc: eric.snowberg@oracle.com, dhowells@redhat.com,
mathew.j.martineau@linux.intel.com, matthewgarrett@google.com,
sashal@kernel.org, jamorris@linux.microsoft.com,
linux-kernel@vger.kernel.org, keyrings@vger.kernel.org
Subject: Re: [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements
Date: Thu, 12 Dec 2019 08:57:19 -0800 [thread overview]
Message-ID: <0cc15a43-8e1b-9819-33fe-8325068f8df2@linux.microsoft.com> (raw)
In-Reply-To: <1576138743.4579.147.camel@linux.ibm.com>
On 12/12/19 12:19 AM, Mimi Zohar wrote:
>>> + ima_process_keys = true;
>> +
>> + INIT_LIST_HEAD(&temp_ima_keys);
>> +
>> + mutex_lock(&ima_keys_mutex);
>> +
>> + list_for_each_entry_safe(entry, tmp, &ima_keys, list)
>> + list_move_tail(&entry->list, &temp_ima_keys);
>> +
>> + mutex_unlock(&ima_keys_mutex);
>
>
> The v1 comment, which explained the need for using a temporary
> keyring, is an example of an informative comment. If you don't
> object, instead of re-posting this patch, I can insert it.
>
> Mimi
Sure Mimi. Thanks for including the comment in the patch.
thanks,
-lakshmi
next prev parent reply other threads:[~2019-12-12 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 18:51 [PATCH v2 0/2] IMA: Deferred measurement of keys Lakshmi Ramasubramanian
2019-12-11 18:51 ` [PATCH v2 1/2] IMA: Define workqueue for early boot "key" measurements Lakshmi Ramasubramanian
2019-12-12 8:19 ` Mimi Zohar
2019-12-12 16:57 ` Lakshmi Ramasubramanian [this message]
2019-12-12 21:13 ` Mimi Zohar
2019-12-12 21:59 ` Lakshmi Ramasubramanian
2019-12-12 22:54 ` Mimi Zohar
2019-12-12 22:58 ` Lakshmi Ramasubramanian
2019-12-11 18:51 ` [PATCH v2 2/2] IMA: Call workqueue functions to measure queued keys Lakshmi Ramasubramanian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc15a43-8e1b-9819-33fe-8325068f8df2@linux.microsoft.com \
--to=nramas@linux.microsoft.com \
--cc=dhowells@redhat.com \
--cc=eric.snowberg@oracle.com \
--cc=jamorris@linux.microsoft.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathew.j.martineau@linux.intel.com \
--cc=matthewgarrett@google.com \
--cc=sashal@kernel.org \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).