linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Sameer Pujar <spujar@nvidia.com>,
	tglx@linutronix.de, jason@lakedaemon.net, will.deacon@arm.com,
	catalin.marinas@arm.com, heiko@sntech.de,
	horms+renesas@verge.net.au, maxime.ripard@bootlin.com,
	andy.gross@linaro.org, olof@lixom.net,
	bjorn.andersson@linaro.org, jagan@amarulasolutions.com,
	enric.balletbo@collabora.com, stefan.wahren@i2se.com,
	ezequiel@collabora.com, marc.w.gonzalez@free.fr,
	christoffer.dall@arm.com, drjones@redhat.com,
	julien.thierry@arm.com
Cc: treding@nvidia.com, jonathanh@nvidia.com,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] irqchip/gic-pm: add driver remove support
Date: Wed, 13 Mar 2019 11:22:50 +0000	[thread overview]
Message-ID: <0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com> (raw)
In-Reply-To: <1552474956-25513-1-git-send-email-spujar@nvidia.com>

First things first:

- Where is the cover letter?
- This series should be flagged as v2, as it not the same as the one you
sent last week.

On 13/03/2019 11:02, Sameer Pujar wrote:
> This is a preparatory patch for using irq-gic-pm driver as module and thus
> implement remove() call for the driver. Details of remove() are as below,
> 
>  * pm_runtime_force_suspend() is added to balance runtime PM, otherwise
>    following is seen: "agic-controller: Unbalanced pm_runtime_enable!"
>  * Function gic_teardown() is exported from gic driver and called in remove
>    to perform io unmap.
>  * pm_clk_destroy() to free clock resources
>  * irq is unmapped and freed with irq_dispose_mapping()
> 

Let's be clear, I have no desire to export any GIC symbol at all. Why
should we do this? This "driver" is the tiniest thing, and making it
modular doesn't get us anything.

So what's the rational for doing so?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...

  parent reply	other threads:[~2019-03-13 11:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-13 11:02 [PATCH 1/5] irqchip/gic-pm: add driver remove support Sameer Pujar
2019-03-13 11:02 ` [PATCH 2/5] irqchip/gic: allow gic-pm driver to be used as module Sameer Pujar
2019-03-13 11:02 ` [PATCH 3/5] arm64: defconfig: build gic-pm driver " Sameer Pujar
2019-03-13 11:02 ` [PATCH 4/5] irqchip/gic-pm: use devm_clk_*() helpers Sameer Pujar
2019-03-13 11:02 ` [PATCH 5/5] irqchip/gic-pm: fix suspend handling Sameer Pujar
2019-03-13 11:22 ` Marc Zyngier [this message]
2019-03-13 13:50   ` [PATCH 1/5] irqchip/gic-pm: add driver remove support Sameer Pujar
2019-03-13 14:20     ` Marc Zyngier
2019-03-13 16:34       ` Thierry Reding
2019-03-13 17:57         ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0cd78fb7-4bcb-b735-54ca-24a179b9ff72@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=catalin.marinas@arm.com \
    --cc=christoffer.dall@arm.com \
    --cc=drjones@redhat.com \
    --cc=enric.balletbo@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=heiko@sntech.de \
    --cc=horms+renesas@verge.net.au \
    --cc=jagan@amarulasolutions.com \
    --cc=jason@lakedaemon.net \
    --cc=jonathanh@nvidia.com \
    --cc=julien.thierry@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.w.gonzalez@free.fr \
    --cc=maxime.ripard@bootlin.com \
    --cc=olof@lixom.net \
    --cc=spujar@nvidia.com \
    --cc=stefan.wahren@i2se.com \
    --cc=tglx@linutronix.de \
    --cc=treding@nvidia.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).