From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
clang-built-linux@googlegroups.com, x86@kernel.org,
catalin.marinas@arm.com, will.deacon@arm.com, arnd@arndb.de,
linux@armlinux.org.uk, paul.burton@mips.com, tglx@linutronix.de,
luto@kernel.org, mingo@redhat.com, bp@alien8.de,
sboyd@kernel.org, salyzyn@android.com, pcc@google.com,
0x7f454c46@gmail.com, ndesaulniers@google.com, avagin@openvz.org
Subject: Re: [PATCH 19/19] arm64: vdso32: Enable Clang Compilation
Date: Mon, 17 Feb 2020 12:26:16 +0000 [thread overview]
Message-ID: <0cee3707-d526-3766-3dde-543c8dbd8e68@arm.com> (raw)
In-Reply-To: <20200213184454.GA4663@ubuntu-m2-xlarge-x86>
[-- Attachment #1: Type: text/plain, Size: 1251 bytes --]
Hi Nathan,
On 13/02/2020 18:44, Nathan Chancellor wrote:
> On Thu, Feb 13, 2020 at 04:16:14PM +0000, Vincenzo Frascino wrote:
>> Enable Clang Compilation for the vdso32 library.
[...]
>> +LD_COMPAT ?= $(CROSS_COMPILE_COMPAT)gcc
>
> Well this is unfortunate :/
>
> It looks like adding the --target flag to VDSO_LDFLAGS allows
> clang to link the vDSO just fine although it does warn that -nostdinc
> is unused:
>
> clang-11: warning: argument unused during compilation: '-nostdinc'
> [-Wunused-command-line-argument]
>
This is why ended up in this "unfortunate" situation :) I wanted to avoid the
warning.
> It would be nice if the logic of commit fe00e50b2db8 ("ARM: 8858/1:
> vdso: use $(LD) instead of $(CC) to link VDSO") could be adopted here
> but I get that this Makefile is its own beast :) at the very least, I
> think that the --target flag should be added to VDSO_LDFLAGS so that gcc
> is not a requirement for this but I am curious if you tried that already
> and noticed any issues with it.
>
--target is my preferred way as well, I can try to play another little bit with
the flags and see what I can come up with in the next version.
> Cheers,
> Nathan
[...]
--
Regards,
Vincenzo
[-- Attachment #2: pEpkey.asc --]
[-- Type: application/pgp-keys, Size: 14291 bytes --]
next prev parent reply other threads:[~2020-02-17 12:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 16:15 [PATCH 00/19] Introduce common headers Vincenzo Frascino
2020-02-13 16:15 ` [PATCH 01/19] linux/const.h: Extract common header for vDSO Vincenzo Frascino
2020-02-13 16:15 ` [PATCH 02/19] linux/bits.h: " Vincenzo Frascino
2020-02-13 16:15 ` [PATCH 03/19] linux/limits.h: " Vincenzo Frascino
2020-02-13 16:15 ` [PATCH 04/19] linux/math64.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 05/19] linux/time.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 06/19] linux/time32.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 07/19] linux/time64.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 08/19] linux/jiffies.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 09/19] linux/ktime.h: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 10/19] common: Introduce processor.h Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 11/19] linux/elfnote.h: Replace elf.h with UAPI equivalent Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 12/19] arm64: Introduce asm/common/processor.h Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 13/19] arm64: vdso: Include common headers in the vdso library Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 14/19] arm64: vdso32: " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 15/19] mips: vdso: Enable mips to use common headers Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 16/19] x86: vdso: Enable x86 " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 17/19] arm: vdso: Enable arm " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 18/19] lib: vdso: Enable " Vincenzo Frascino
2020-02-13 16:16 ` [PATCH 19/19] arm64: vdso32: Enable Clang Compilation Vincenzo Frascino
2020-02-13 18:44 ` Nathan Chancellor
2020-02-17 12:26 ` Vincenzo Frascino [this message]
2020-02-17 16:46 ` Will Deacon
2020-02-17 22:39 ` Ard Biesheuvel
2020-02-18 13:03 ` Vincenzo Frascino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cee3707-d526-3766-3dde-543c8dbd8e68@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=0x7f454c46@gmail.com \
--cc=arnd@arndb.de \
--cc=avagin@openvz.org \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=natechancellor@gmail.com \
--cc=ndesaulniers@google.com \
--cc=paul.burton@mips.com \
--cc=pcc@google.com \
--cc=salyzyn@android.com \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).