From: "Moger, Babu" <Babu.Moger@amd.com>
To: Borislav Petkov <bp@suse.de>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"reinette.chatre@intel.com" <reinette.chatre@intel.com>,
"fenghua.yu@intel.com" <fenghua.yu@intel.com>,
"james.morse@arm.com" <james.morse@arm.com>,
"vikas.shivappa@linux.intel.com" <vikas.shivappa@linux.intel.com>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"x86@kernel.org" <x86@kernel.org>,
"peterz@infradead.org" <peterz@infradead.org>,
"pombredanne@nexb.com" <pombredanne@nexb.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"kstewart@linuxfoundation.org" <kstewart@linuxfoundation.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"ak@linux.intel.com" <ak@linux.intel.com>,
"kirill.shutemov@linux.intel.com"
<kirill.shutemov@linux.intel.com>,
"xiaochen.shen@intel.com" <xiaochen.shen@intel.com>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"Hurwitz, Sherry" <sherry.hurwitz@amd.com>,
"Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>,
"dwmw@amazon.co.uk" <dwmw@amazon.co.uk>,
"luto@kernel.org" <luto@kernel.org>,
"jroedel@suse.de" <jroedel@suse.de>,
"jannh@google.com" <jannh@google.com>,
"dima@arista.com" <dima@arista.com>,
"jpoimboe@redhat.com" <jpoimboe@redhat.com>,
"vkuznets@redhat.com" <vkuznets@redhat.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 09/11] arch/x86: Introduce new config parameter AMD_QOS
Date: Fri, 12 Oct 2018 14:40:50 +0000 [thread overview]
Message-ID: <0cf1ea65-0528-b133-2b89-2e04644ea2e6@amd.com> (raw)
In-Reply-To: <20181011220255.GB21876@zn.tnic>
Boris,
On 10/11/2018 05:02 PM, Borislav Petkov wrote:
> On Thu, Oct 11, 2018 at 08:33:35PM +0000, Moger, Babu wrote:
>> Introduces the new config parameter AMD_QOS. This parameter will be
>> used to enable cache and memory bandwidth allocation and monitoring
>> features on AMD processors. This will enable common config parameter
>> RESCTRL if selected.
>>
>> Signed-off-by: Babu Moger <babu.moger@amd.com>
>> ---
>> arch/x86/Kconfig | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
>> index 91a703ebdc04..5cef55935a5a 100644
>> --- a/arch/x86/Kconfig
>> +++ b/arch/x86/Kconfig
>> @@ -458,9 +458,24 @@ config INTEL_RDT
>>
>> Say N if unsure.
>>
>> +config AMD_QOS
>> + bool "AMD Quality of Service support"
>> + default n
>> + depends on X86 && CPU_SUP_AMD
>
> Why the X86 dependency too? CPU_SUP_AMD is x86-specific and indirectly
> implies X86, I'd say.
That is correct. CPU_SUP_AMD implicitly means x86.
To be more specific, I will change it to
"depends on X86_64 && CPU_SUP_AMD" as this feature is for X86_64 only.
Thanks
next prev parent reply other threads:[~2018-10-12 14:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-11 20:32 [PATCH v3 00/11] arch/x86: AMD QoS support Moger, Babu
2018-10-11 20:33 ` [PATCH v3 01/11] arch/x86: Start renaming the rdt files to more generic names Moger, Babu
2018-10-12 19:07 ` Reinette Chatre
2018-10-12 20:11 ` Moger, Babu
2018-10-11 20:33 ` [PATCH v3 02/11] arch/x86: Rename the RDT functions and definitions Moger, Babu
2018-10-12 19:40 ` Reinette Chatre
2018-10-12 20:12 ` Moger, Babu
2018-10-11 20:33 ` [PATCH v3 03/11] arch/x86: Re-arrange RDT init code Moger, Babu
2018-10-11 20:33 ` [PATCH v3 04/11] arch/x86: Bring all the macros to resctrl.h Moger, Babu
2018-10-11 20:33 ` [PATCH v3 05/11] arch/x86: Introduce a new config parameter RESCTRL Moger, Babu
2018-10-11 20:33 ` [PATCH v3 06/11] arch/x86: Use new config parameter RESCTRL for compilation Moger, Babu
2018-10-11 20:33 ` [PATCH v3 07/11] arch/x86: Initialize the resource functions that are different Moger, Babu
2018-10-11 20:33 ` [PATCH v3 08/11] arch/x86: Bring few more functions into the resource structure Moger, Babu
2018-10-11 20:33 ` [PATCH v3 09/11] arch/x86: Introduce new config parameter AMD_QOS Moger, Babu
2018-10-11 22:02 ` Borislav Petkov
2018-10-12 14:40 ` Moger, Babu [this message]
2018-10-12 14:43 ` Borislav Petkov
2018-10-12 18:32 ` Moger, Babu
2018-10-11 20:33 ` [PATCH v3 10/11] arch/x86: Add AMD feature bit X86_FEATURE_MBA in cpuid bits array Moger, Babu
2018-10-11 20:33 ` [PATCH v3 11/11] arch/x86: Introduce QOS feature for AMD Moger, Babu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cf1ea65-0528-b133-2b89-2e04644ea2e6@amd.com \
--to=babu.moger@amd.com \
--cc=Thomas.Lendacky@amd.com \
--cc=ak@linux.intel.com \
--cc=bp@suse.de \
--cc=colin.king@canonical.com \
--cc=dima@arista.com \
--cc=dwmw@amazon.co.uk \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=james.morse@arm.com \
--cc=jannh@google.com \
--cc=jpoimboe@redhat.com \
--cc=jroedel@suse.de \
--cc=kirill.shutemov@linux.intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sherry.hurwitz@amd.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=vikas.shivappa@linux.intel.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xiaochen.shen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).