From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbdAOP4m (ORCPT ); Sun, 15 Jan 2017 10:56:42 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:34899 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751223AbdAOP4j (ORCPT ); Sun, 15 Jan 2017 10:56:39 -0500 Subject: Re: [PATCHSET v6] blk-mq scheduling framework To: Paolo Valente References: <1484170803-9311-1-git-send-email-axboe@fb.com> CC: Linux-Kernal , , Omar Sandoval , From: Jens Axboe Message-ID: <0cf80fa9-f8e9-5cdb-80b0-f277452e5ab1@fb.com> Date: Sun, 15 Jan 2017 08:55:18 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [66.29.164.166] X-ClientProxiedBy: DM5PR1601CA0035.namprd16.prod.outlook.com (10.174.111.48) To MWHPR15MB1198.namprd15.prod.outlook.com (10.175.2.140) X-MS-Office365-Filtering-Correlation-Id: d4038966-ff19-4785-4a08-08d43d5eec37 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1198; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;3:b2KMFwxd6+wD/nvzkJoSexCpEsokSMTnJc59j9/nj86PFCWpD43T5oEZg5gN4h4wrMY2EA+rKvXJVeRn+DjotlsH67doFGG8zYn7HrYRnsQRuSmNaHwLu772JDfDeJ2jp6+/8Q8btZrqBYK9o5RlCt0AJ6leVzCtgeKfIzW3oly99R3w1MxU3BulZMQHy0R+6A6tAy4ubs2QFpuuuxvokf5Hkqn4cXwF7I7vyR0rIA+ACk6/t5KWeo5WYJ1JAlAkLimeevMJ5sJMSw7p+lAcGg== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;25:+Se+S+ArBQlOIHuOf+usQPz1LZC507Hg7ffRSfpRGNYjKJNOph2XU6OADLhBuKzYTfaGO55paOhM4XeQNbIftqth/iXj1aRMLDtBe48hqVTbvmfab/YOwQ5z8peEUtThXAtNeItm4y39rMpF9EnovvSwL9M4KXyC1DbxNNtpuiIEzvIjcUsRDJ7fJfqUjRQHTcNPFl9AknEAOCWCxgSz3Y7x9adMZvzYQ39dGJF7Zs5x20oEzlpVk03YHapOWirLyvSBSFUkzNKpJywnm4fjI3buxtEc93t9XNolVDFnyUNnOV/+WzE5zkh22dqw+mXk6tU6dtomCgE8Rpw3Fc9FwgWCAW0/3j5Qvz2RDkQy1gQ4QJ+/t7QYf5BmqB6/Sp+OPR8SyPznlcz2+1FlsGEkbM/TktRKsL470MSwjH5yq8TXThORd6fwTV0IrbZ0oKDX+b6utw8J9JvBhBOaxq0U19zD/N8YxksuLiPysr+FDaj+3ht2JAheipFRYwa448lkq6NXmrjtu72ZKvgY1LhhxbcLrerhCpONvf1he+Aa8nxSClcJCKJogyeR97GuI/YFxqFBqGh926JwHR3rR5Jj0vYQJTNM2V+7vGUCI5uNPvODYYZIbLpLlGbMehfYhlosdpt+LWXTdowzhPZrkCzFTGXRN1EJtlTB2QmHdzwJ/pxy+NIXUAdVKdHAy74LmEqsF5cabCZ8WGzu8mUeY3SiOqDDvXR7ZngbnshIAC3S0bg7XmCIXSikTNwTPQwbd80Vct0rQxV8PSqvZlSkj6NxhxvEcu5CT7OxL57EQFhUD/w8Tnm8Fm0039YwwcD8sM2X+Wss/JyI0ui9FiGSlc5Aohb3Od3YfTb737e1VEsMTUI= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;31:tkTT39mTCSwJoufWtdZEOhBvsg8XeGVQGYDX/zCVt7EO3rI+/oDKh5oGM4llgS4bWAWjTWZKn0B1yGRseFfiHE9D6mc0D7sW+amZIVUbYqvqP0XXr0pYqPWyi7Q9PgRgRHG1pA4HuO7eUuoPQycGOe2PkzuNQIqNg6sFGOYUxrN1fOoBa+OwpGRKMAIKWtEBKhClJiTBRfggzy+79gxf5NuYYmsCWeVF7xkv6jaNDGuBLpbT3iNDs5I1Wz5uwxNCsfq6wJtoaV+1W7hKs2SBqQ==;20:UtGM2ePQLTvItgAznD37gIcgjkUZtOCv4U55OjCvpgMuaxEx7jrExnJdxBcQWFZtJdK1atKmP6+Q11cy7huBW5AWldzX/Oh1TGoyYKk9e4XpMnhz9L13DYugv541lQXsQiffCsl1wb0bnF4gOOyKPnOLqs6dNyt+A46qLBrOX7Pgb+lEj9ApWN3/yJC8QKbDCmFx36bRWYlnYcB360GEqUnclKpeo77FcboIv9IwFaDjJMRq+5V4CxYH4Buu0kBEHEuduHXq3rhBT1ymEBq7tsnjA9ZNks1X8E7GFCerQCVz08wxgFOIPIkI9BmS9+02boSYTU+MNdhCk9gATbsw0m2p18PE7MU6iB0ISoCBosdnDGhvNFPnJsMB2NP8FMyKx0fGiJld4jNRX+7msxIN3OMcZ5qCuv/ldLqAxLPMyu+LeiKs62L0rsCm4tZK6QvM83lfyHwzq7gdEz5ZrzzEs8f/toIUpuIMqf9nJJ1rEmLVTWrp6l+AJdGs5F55E+uA X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123555025)(20161123560025)(20161123564025)(20161123562025)(6072148);SRVR:MWHPR15MB1198;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1198; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;4:buAygAkYHzw+OrM2p5TNvAauSpPC4g4kOO5xZv62PD4e1WiEpdlIz/Npopi+Z/8GWkw5oQfBwPQ1N9x4fB5HbrWHSMXO5yiRaGfiB62kp0q7yCzEyhLCnUfRJFY1adN9niGCZP0FWvSPs2RbCz+snmeH1DEkKW3br+Z5EpxVWz8spxbfLmuI6nRRwgUkK8LL5zTJBfLdMqJkD6kPIi6Y7XMYGOl6nNEWchjkh9GbCP1bdCqyCyrvWTqGR9WgizpSefB728/1Ahs9oZa0zc/Zu3+q5gngyWd1YXLSDftYy64LwvvYOTJGTqhRh0wCzr1JOHWieX8a3ZuEwMTk3bScfJEW2j4TCvC4UYJQCZk0FbpyxzThoMjbTukEOwF81uKUJy+eoZfpD3plaAcwxeF9d6TdKww5M3WlJANSAxOz8fz6NLURZdAjwf87BzAl0oKOQr+cEwa5WE0Fh6wXgkO6jcoji5uX3kmorSYtcijFg2xgWltP2iX+YNSUbHkfVkhQQV18kNV3FSee8Msq+iQzq6fKnoACYKF2JKH4WdM6n/ocJFhhTHkCfwM/JyAl2vSJRIStka5/k+VaAroJNcO5LJX+lTJELfOiN3RcLHfzfLxbNgcOrWi9Qy4h2YqQ8OCfV22D8LB8+e8ixN/h5wIXSA== X-Forefront-PRVS: 0188D66E61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(6049001)(7916002)(39410400002)(39450400003)(39830400002)(377454003)(199003)(24454002)(189002)(4326007)(101416001)(76176999)(50986999)(305945005)(7736002)(117156001)(65826007)(54356999)(81166006)(31686004)(81156014)(65806001)(65956001)(110136003)(8676002)(47776003)(105586002)(106356001)(64126003)(92566002)(42186005)(66066001)(50466002)(6116002)(3846002)(83506001)(54906002)(2950100002)(25786008)(4001350100001)(2906002)(6666003)(6916009)(8656002)(68736007)(97736004)(189998001)(6306002)(230700001)(77096006)(33646002)(5890100001)(229853002)(6486002)(86362001)(31696002)(23746002)(36756003)(90366009)(5660300001)(38730400001)(27001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1198;H:[192.168.1.176];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;MWHPR15MB1198;23:h8SD8OnvNPGXlp8DzE8HQ6pYKfWcVo7hMXF9K?= =?Windows-1252?Q?YVfmznlCAYXZHYgMaa7jOUidqBIunhsKprpyPqpXk6jeTYksfoVJTsdF?= =?Windows-1252?Q?9MfJymXlu6itnVQmwRzrEJI6lM5AgQ2pJgzxvEItxajYQxvc5FAIvcWL?= =?Windows-1252?Q?ekN5rlhmhRtAd+cWJwi9GjGOPLMIHwjITddTQSBWoYRv84V5B95IA75g?= =?Windows-1252?Q?kl1HcjV8JYm21/bF4ApsrfJ548azbY3W6GTEB6cSUMMvAlROq0Mr9zmW?= =?Windows-1252?Q?oqogDJVACUKsy6Qi3ER9DyaXX8pd2RKSgh3MfAz+fSWgbp5KB2VSIyC3?= =?Windows-1252?Q?rSVDAYihlMsyPvj/CUuxl2dXAWeS8VP5ad50E015BuXBI4rYy/xhaRrP?= =?Windows-1252?Q?FR5v70mQzbEusI/fs5msS0hgBEdLEJzcQkCWW8QG7aSJ4gsGN23y2biU?= =?Windows-1252?Q?rXXJpzd2DX5nLqe5Z4dRI+T4bH+tcYWVsW1zGfwTmEGWALEp7FkHRl3l?= =?Windows-1252?Q?QN15mAWfbB3AZwqQsR/zZtlHbBsoa3qk8ZM3bhsv4EGdAyu9kjJGj9k3?= =?Windows-1252?Q?M2r6guNgT+QNUn6Tf7U1lO6LN6cg54jeX6iBGppHhEGhOw/UUYo9duNL?= =?Windows-1252?Q?PwEVYhGcIQk/wmlG+WhBv9byHiLSygRFG7m9Rxtxp3k1/Zy+9lWjZFGP?= =?Windows-1252?Q?TjJMuzHPeZr/8EhIjzL/huagVEClDb88rQmJSkWGeK9BcKC9Ejf303to?= =?Windows-1252?Q?sqDfk4WxB/qPokAYHU0DwnXoE8di+PR5yIYgLY99PSMlCLL3KJLn/jht?= =?Windows-1252?Q?Jzl65JB3PfpBYo4rr3VOm4Mpm33FAy4PYkZ6S56lvq5uBE7q1SYeLrIt?= =?Windows-1252?Q?Vg2NF7v1bPxTz5SDCXh7IwO/PFQutBOA8IfSrGzUKWbAEjDYQ3jt7hxU?= =?Windows-1252?Q?IuRwcGkLIJ2yMXZ44GEwoDcSH+EMK0WcaTtfW2lMsxW80FbgkzXADXAf?= =?Windows-1252?Q?WSZ0M4WZtcb/eIa2Lsf4V486TWxsZPbvfz5Nljn5v4Dn05pBjVOJA8Ls?= =?Windows-1252?Q?MZqxJr0qyceJ3XX/JtM9rjPBmvETsrtXzNXfLYjL1qXvu82BVRhuJ1E9?= =?Windows-1252?Q?ZCIfSh+yyx0myO5YYvQeNJQMT2C4orc6YlDAcIxAESxQfTNkO1cgWu6F?= =?Windows-1252?Q?Si9KlscocZnWkSl5BVqpos8K4LEBjn8RGx01dGy3l0igbPUEksPK/i9i?= =?Windows-1252?Q?xOI7Df1yzZ4bXz8sDDlB5W3B7ba1RzQ9Y7bN7L278u/xpo5ApiSPNBdb?= =?Windows-1252?Q?2pJzC6n6WWjAszkvcuJpTEGWRF3H3Jdyr9l4GqwEWB9XlLsM0xQ/pO9P?= =?Windows-1252?Q?ydltc2FRp2jl7DHh9pBnUB6a/ACBwxdI1sgv/Ily3adSrIrJH1PDGJ3N?= =?Windows-1252?Q?KBkQ5sPJJDAoSdN1Ki0Ps9fcxap52SEJxvWDDrRUQddwgUOwRiRAAm8y?= =?Windows-1252?Q?ZYcT4BblrF8FY3GYXWCUffs/ibS+Egr3762d4+CD6kXCmvbR3gW6K2Jd?= =?Windows-1252?Q?wkBFVxBTCe3CeVAoAuLqeJLjS+oEJcBlmwfjGIc81u/BFBiPYpkNglRd?= =?Windows-1252?Q?Uj2RmsQLHeMizenqG2ZY5Y=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;6:KELMY2kyNbcX8tDeYM5fCewU3rBn3Z7G+3ca73lT0KqNScgpEL7el23gMiIJHZjA4jIDhKKIcViYVggqoyUHho7Tzl9Q38bDOl5LXqAdoKpKnvKRfeWKe1uFUC6zuAaIDZAT5/ibPZLPvcQJA0cbugCg31RIhhDIJ8S8E6l/qO1TtKflmItEkK/kPJHCtAkOHCpRHOvjM2Q/l3YH4lCPLfFf1wNogbZA/sPgYpbNVbJMbw2c51kmRiU6nzdSU7U/5GwZb2NYaS8ZIw8Q7/KjgM8C6MhqJR71tDzw/EE/zaowgOe/t2zMXurHAMRXV8mOLKNudVWJkUEW7bhBEiWT5IxF2O2ALI+NT0g0PRhqvjutwQ01142jj9rPVYkfhfXYhZqh6z5hik27dQ+f3P/Bz7ffIsCEcwvBQbUIqG50MxY=;5:mzIRrqp7FB+yCOqwD7yL9tkEDXucspAyxHIajZVrBXaFXGt/6bLSqRzdHbx5eqbYJqeU+npksX7ZpPK8EYOCQ3Z2zZGGtFIvdTng2fUgi/Tu7PxHKoiVcx93eRExtxyUuobHf7ZUpNa31IEEIwm9GrC0vBaWY1V+Ea8QHxGtIe8=;24:Qj99ahOdfzpEGz0T/wQ2kwZi4V9zw50wXxo+FVEBKLFkt66niK/0kH3EyCsiXfLh9FiAssJPmAmA7t0LS+R39EATSpiAywwgjS+K4F1XWUc= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1198;7:X4sLSx9NSSHo241tw5wyTDU//1QbI6rQtaZWqx4hvsrMYTLZGEi28KzML4DAZRcSByphblLUPaSWNWThBsiPCVNg6KadmWK8c4//RT6CDDWjqmQKVFUHx+mXsfvR+S5TyVZTlek7IyczYlMyImQ9APqISE/cd+poyfOsB5A1PbNxJGgK+W6A8i0eGpjxQp+zneitrzSDLKOkfKc/kYpgXDrmz1Iokgp8wNw3VvFgGzIBqoRC0bE6U5oCgRY69bIlUABpWYm6nGV5Z8NQXo0P9YoPsI4lkij0pIRf3Bh0G8xMKDis6Hudel2hvfBcNI45XzEFdsX5WJZhYiwLIAjpFALkONVmZoZeQL9N4cCkOf6Lnv6MEaVNfvsKn41UaT/CyndkjtD0wOEs7TcylXTOZ1TedVOI/sI03dJephG2x5uNwS+nCX85YmSCTY4v4hKv9yfD8OPSppltZcahvADPpQ==;20:wmZ8r5eNT3QhiSuBU+eEq/isUX1l4hRAPKYvM9QB7gONofqQAKM+yunNHyXXg97kkI4Bv6q7gcJTm2whrWBXk0OukBOpEYQlRE52cmRX/5U1Ma8eWtvWBaFp5reyw5aF4a2qzmc9IJQU6m+pU1JxRNli2yiPxIN//itgQa5Vyoo= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2017 15:55:25.6291 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1198 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-15_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/15/2017 03:12 AM, Paolo Valente wrote: > >> Il giorno 11 gen 2017, alle ore 22:39, Jens Axboe ha scritto: >> >> Another year, another posting of this patchset. The previous posting >> was here: >> >> https://www.spinics.net/lists/kernel/msg2406106.html >> >> (yes, I've skipped v5, it was fixes on top of v4, not the rework). >> >> I've reworked bits of this to get rid of the shadow requests, thanks >> to Bart for the inspiration. The missing piece, for me, was the fact >> that we have the tags->rqs[] indirection array already. I've done this >> somewhat differently, though, by having the internal scheduler tag >> map be allocated/torn down when an IO scheduler is attached or >> detached. This also means that when we run without a scheduler, we >> don't have to do double tag allocations, it'll work like before. >> >> The patchset applies on top of 4.10-rc3, or can be pulled here: >> >> git://git.kernel.dk/linux-block blk-mq-sched.6 >> >> > > Hi Jens, > I have checked this new version to find solutions to the apparent > errors, mistakes or just unclear parts (to me) that I have pointed out > before Christmas last year. But I have found no changes related to > these problems. > > As I have already written, I'm willing to try to fix those errors > myself, if they really are errors, but I would first need at least > some minimal initial feedback and guidance. If needed, tell me how I > can help you get in sync again with these issues (sending my reports > again, sending a digest of them, ...). Sorry Paolo, but focus has been on getting the framework in both a mergeable and stable state, which it is now. I'll tend to BFQ specific issues next week, so we can get those resolved as well. Do you have a place where you have posted your in-progress conversion? -- Jens Axboe