From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 738B539AF9 for ; Thu, 29 Feb 2024 07:30:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709191808; cv=none; b=XaagliZmA3GMqQ25QsIoQ/JfbduyJFTfFLgrPRJX6AGFtLQk+diOOyW/HHMAPwJeJou7SYCuaXzj4GdKX/YBDe+jT39rgzzH93EDXdmU0hy1aSLj7IoAfzZ6AML+BnoTIbW1DieVDuIjc8pTQasuauOyLSnpbaKGwgFJK+Ovguc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709191808; c=relaxed/simple; bh=rjKQsLKBAzqSr4dtcHw0J7MTGh8WjlmBAOHPzrDr92M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=AxsWeB1LUVJg1AZd8ORvODiR90hCS5b+GSXTd1Uc0rzJeEUAwzIE1N2h+beXljFzTVTaL7UA8aFLl3u+v5aqTX6Q4R/ogfKhEeSorTIQktZgATkPFfLNEaj3VPp2OneI320qXiunsYHzH7K/Rh4Jb0nyxelOzWTFmAEQkOljpkw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rfarW-0000Gw-9K; Thu, 29 Feb 2024 08:29:50 +0100 Message-ID: <0d03e5d4-12d0-4cc5-b17c-692471ee3c2d@pengutronix.de> Date: Thu, 29 Feb 2024 08:29:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/6] PCI: imx6: Rename pci-imx6.c and PCI_IMX6 config Content-Language: en-US To: Frank Li , Bjorn Helgaas Cc: =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , imx@lists.linux.dev, Richard Zhu , Philipp Zabel , Rob Herring , Fabio Estevam , Lorenzo Pieralisi , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , NXP Linux Team , Pengutronix Kernel Team , linux-pci@vger.kernel.org, Bjorn Helgaas , bpf@vger.kernel.org, Shawn Guo , Sascha Hauer , linux-arm-kernel@lists.infradead.org, Lucas Stach References: <20240227-pci2_upstream-v1-2-b952f8333606@nxp.com> <20240228230520.GA314710@bhelgaas> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:900:1d::77 X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Hello Frank, On 29.02.24 00:36, Frank Li wrote: > On Wed, Feb 28, 2024 at 05:05:20PM -0600, Bjorn Helgaas wrote: >> On Tue, Feb 27, 2024 at 04:47:09PM -0500, Frank Li wrote: >>> -config PCI_IMX6 >>> +config PCI_IMX >> >> What does this look like to users who carry an old .config file >> forward? > > I don't think people will use old .config when update to new kernel. I can > keep PCI_IMX6 for config if have to. I'd argue it's the complete opposite. Most users don't use the in-tree defconfig, but use olddefconfig on their customized .config, either explicitly or implicitly via menuconfig and saving. This would result in non-functional PCI after an update. I don't mind renaming the file, but please leave the Kconfig symbol as-is. Thanks, Ahmad > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |