From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932320AbcHBRod (ORCPT ); Tue, 2 Aug 2016 13:44:33 -0400 Received: from smtp65.ord1c.emailsrvr.com ([108.166.43.65]:56637 "EHLO smtp65.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936143AbcHBRmm (ORCPT ); Tue, 2 Aug 2016 13:42:42 -0400 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH 34/34] Staging: comedi: drivers: cd_pcidas: Compression of To: Nadim almas References: <1469909095-15991-1-git-send-email-nadim.902@gmail.com> Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org From: Ian Abbott Message-ID: <0d2f5143-c3c9-f8c1-1bb8-4d5a95ab5b68@mev.co.uk> Date: Tue, 2 Aug 2016 18:42:38 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.1.0 MIME-Version: 1.0 In-Reply-To: <1469909095-15991-1-git-send-email-nadim.902@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/07/16 21:04, Nadim almas wrote: > This patch compresses two lines in to a single line in file > cb_pcidas.c But this patch changes cb_pcidas64.c. Also, the Subject line says 'cd_pcidas'. You can remove the 'drivers:' tag from the subject line to save some space. It is sufficient to tag it as 'Staging: comedi: cb_pcidas64:'. > if immediate return statement is found. It also removes variable > bytes_written as it is no longer needed. The patch does not remove any variables. > It is done using script Coccinelle. And coccinelle uses following > semantic patch for this compression function: > > @@ > expression e, ret; > @@ > > -ret = > +return > e; > -return ret > > Signed-off-by: Nadim Almas > --- > > drivers/staging/comedi/drivers/cb_pcidas64.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c > index 1f9c08a..d30cf3d 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidas64.c > +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c > @@ -1408,9 +1408,7 @@ static int set_ai_fifo_size(struct comedi_device *dev, unsigned int num_samples) > if (retval < 0) > return retval; > > - num_samples = retval * fifo->num_segments * fifo->sample_packing_ratio; > - > - return num_samples; > + return retval * fifo->num_segments * fifo->sample_packing_ratio; > } > > /* query length of fifo */ > -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-