linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Vadym Kochan <vadym.kochan@plvision.eu>
Cc: linux-kernel@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Taras Chornyi <taras.chornyi@plvision.eu>
Subject: Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support
Date: Mon, 1 Jun 2020 10:13:05 +0100	[thread overview]
Message-ID: <0d664272-4ef9-fe2c-02f4-60e9ecb41e20@linaro.org> (raw)
In-Reply-To: <20200601090300.GA21928@plvision.eu>



On 01/06/2020 10:03, Vadym Kochan wrote:
>>> +
>>> +	nvmem = of_nvmem_device_get(np, NULL);
>>> +	if (IS_ERR(nvmem))
>>> +		return PTR_ERR(nvmem);
>>> +
>> TBH, this looks completely incorrect way to do this and misuse of nvmem
>> consumer interface.
>>
>> Ideally nvmem provider driver should populate "cells" in struct nvmem_config
>> after decoding them and then register nvmem provider.
>>
>> That should just work!
>>
>>
>> --srini
> But this is not nvmem provider but just describes the cells for any
> nvmem device, because ONIE uses special TLV structure on the nvmem
> device. So from the nvmem device point it is a consumer but provides the cells
> for the given device.

That still falls under nvmem providers responsibility to parse these 
cells before registering it.

BTW, where is the provider driver for this in kernel?


--srini

> 

  reply	other threads:[~2020-06-01  9:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-29 23:04 [PATCH v2 0/2] nvmem: add ONIE NVMEM cells provider Vadym Kochan
2020-05-29 23:04 ` [PATCH v2 1/2] nvmem: core: allow to register cells for existing device Vadym Kochan
2020-05-29 23:04 ` [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support Vadym Kochan
2020-06-01  8:50   ` Srinivas Kandagatla
2020-06-01  9:03     ` Vadym Kochan
2020-06-01  9:13       ` Srinivas Kandagatla [this message]
2020-06-01 10:27         ` Vadym Kochan
2020-06-05 10:53           ` Vadym Kochan
2020-06-15 11:06             ` Srinivas Kandagatla
2020-08-14 11:56               ` Vadym Kochan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d664272-4ef9-fe2c-02f4-60e9ecb41e20@linaro.org \
    --to=srinivas.kandagatla@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=taras.chornyi@plvision.eu \
    --cc=vadym.kochan@plvision.eu \
    --subject='Re: [PATCH v2 2/2] nvmem: add ONIE NVMEM cells support' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).