From: ivanhu <ivan.hu@canonical.com>
To: Matt Fleming <matt@codeblueprint.co.uk>,
Geliang Tang <geliangtang@gmail.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] efi/efi_test: use memdup_user
Date: Mon, 8 May 2017 16:18:30 +0800 [thread overview]
Message-ID: <0d6b6b9e-de5c-4eb2-f46a-d26ae058fa42@canonical.com> (raw)
In-Reply-To: <20170505205349.GC5225@codeblueprint.co.uk>
On 05/06/2017 04:53 AM, Matt Fleming wrote:
> On Sat, 29 Apr, at 09:42:52AM, Geliang Tang wrote:
>> Use memdup_user() helper instead of open-coding to simplify the code.
>>
>> Signed-off-by: Geliang Tang <geliangtang@gmail.com>
>> ---
>> drivers/firmware/efi/test/efi_test.c | 11 +++--------
>> 1 file changed, 3 insertions(+), 8 deletions(-)
>
> This one looks fine. Ivan, do you want to ACK it?
>
Looks fine to me too, ACK. Thanks!
Ivan
next prev parent reply other threads:[~2017-05-08 8:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-29 1:42 [PATCH 1/2] efi/efi_test: use memdup_user Geliang Tang
2017-04-29 1:42 ` [PATCH 2/2] efi/efi_test: drop useless kfree Geliang Tang
2017-05-02 7:11 ` ivanhu
2017-05-02 14:48 ` Geliang Tang
2017-05-05 20:53 ` [PATCH 1/2] efi/efi_test: use memdup_user Matt Fleming
2017-05-08 8:18 ` ivanhu [this message]
2017-05-10 10:35 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d6b6b9e-de5c-4eb2-f46a-d26ae058fa42@canonical.com \
--to=ivan.hu@canonical.com \
--cc=ard.biesheuvel@linaro.org \
--cc=geliangtang@gmail.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).