From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDAF9C433E0 for ; Sat, 30 Jan 2021 19:02:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA85B64DDD for ; Sat, 30 Jan 2021 19:02:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232109AbhA3TCF (ORCPT ); Sat, 30 Jan 2021 14:02:05 -0500 Received: from smtprelay0235.hostedemail.com ([216.40.44.235]:52208 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S231569AbhA3TCE (ORCPT ); Sat, 30 Jan 2021 14:02:04 -0500 Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay06.hostedemail.com (Postfix) with ESMTP id C861818009FF3; Sat, 30 Jan 2021 19:01:23 +0000 (UTC) X-Session-Marker: 6A6F6540706572636865732E636F6D X-HE-Tag: hen49_5905c85275b3 X-Filterd-Recvd-Size: 1893 Received: from [192.168.1.159] (unknown [47.151.137.21]) (Authenticated sender: joe@perches.com) by omf06.hostedemail.com (Postfix) with ESMTPA; Sat, 30 Jan 2021 19:01:22 +0000 (UTC) Message-ID: <0d72bc0b518c416d32e11abfacda36e6370b8f2c.camel@perches.com> Subject: Re: [PATCH 19/29] s390/tty3270: Avoid comma separated statements From: Joe Perches To: Jiri Kosina , linux-kernel@vger.kernel.org Cc: Heiko Carstens , Vasily Gorbik , Christian Borntraeger , linux-s390@vger.kernel.org Date: Sat, 30 Jan 2021 11:01:21 -0800 In-Reply-To: <9988babd9cca4ac841961d9f0bbf5e49caa87659.1598331149.git.joe@perches.com> References: <9988babd9cca4ac841961d9f0bbf5e49caa87659.1598331149.git.joe@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.38.1-1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-08-24 at 21:56 -0700, Joe Perches wrote: > Use semicolons and braces. ping? > Signed-off-by: Joe Perches > --- >  drivers/s390/char/tty3270.c | 6 ++++-- >  1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/s390/char/tty3270.c b/drivers/s390/char/tty3270.c > index aec996de44d9..6acce975df26 100644 > --- a/drivers/s390/char/tty3270.c > +++ b/drivers/s390/char/tty3270.c > @@ -424,8 +424,10 @@ tty3270_update(struct timer_list *t) >   * last output position matches the start address >   * of this line. >   */ > - if (s->string[1] == sba[0] && s->string[2] == sba[1]) > - str += 3, len -= 3; > + if (s->string[1] == sba[0] && s->string[2] == sba[1]) { > + str += 3; > + len -= 3; > + } >   if (raw3270_request_add_data(wrq, str, len) != 0) >   break; >   list_del_init(&s->update);