From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933442AbcINVrL (ORCPT ); Wed, 14 Sep 2016 17:47:11 -0400 Received: from mx2.mailbox.org ([80.241.60.215]:50877 "EHLO mx2.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933168AbcINVrJ (ORCPT ); Wed, 14 Sep 2016 17:47:09 -0400 Subject: Re: drivers: staging: vme: Fixed some code style warnings To: Andrew Kanner , gregkh@linuxfoundation.org References: <1473719504-14435-1-git-send-email-andrew.kanner@gmail.com> <20160914163122.6131795.78107.2584@gmail.com> Cc: devel@driverdev.osuosl.org, manohar.vanga@gmail.com, egor.ulieiskii@gmail.com, linux-kernel@vger.kernel.org From: =?UTF-8?Q?Markus_B=c3=b6hme?= Message-ID: <0d84d218-4457-1828-d26c-2f354f16e6da@mailbox.org> Date: Wed, 14 Sep 2016 23:46:16 +0200 MIME-Version: 1.0 In-Reply-To: <20160914163122.6131795.78107.2584@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/14/2016 06:31 PM, Andrew Kanner wrote: > ‎Thanks, I understood my fault, but haven't done this changes yet. I > can't understand if I should reply to original message with v2 patch or > send a new email with it? Just send the patch with your revised commit message as a new mail, and be sure to mark it as v2. In future mails, please avoid top-posting. It is frowned upon because it makes it unnecessarily hard to follow a discussion. Thanks, Markus > > > Исходное сообщение > От: Markus Böhme > Отправлено: среда, 14 сентября 2016 г., 15:56 > Кому: Andrew Kanner; gregkh@linuxfoundation.org > Копия: devel@driverdev.osuosl.org; manohar.vanga@gmail.com; egor.ulieiskii@gmail.com; linux-kernel@vger.kernel.org > Тема: Re: drivers: staging: vme: Fixed some code style warnings > > On 09/13/2016 12:31 AM, Andrew Kanner wrote: >> Signed-off-by: Andrew Kanner >> --- >> drivers/staging/vme/devices/vme_pio2_core.c | 12 ++++++------ >> drivers/staging/vme/devices/vme_user.c | 2 +- >> 2 files changed, 7 insertions(+), 7 deletions(-) >> (snip) > > Hello Andrew, > > please be more specific in your subject line, e.g. > "drivers: staging: vme: Convert to octal notation for permission bits". > > Also don't forget to add a commit message to your patch with a short > description what you are fixing and why. In your case it would be good > to mention that you are fixing a checkpatch warning, and to include the > warning message in your description. Then resend as V2. > > Thanks, > Markus >