From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C832DC0650F for ; Mon, 5 Aug 2019 16:51:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9F6DB206A2 for ; Mon, 5 Aug 2019 16:51:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729194AbfHEQvP (ORCPT ); Mon, 5 Aug 2019 12:51:15 -0400 Received: from lhrrgout.huawei.com ([185.176.76.210]:33117 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726691AbfHEQvO (ORCPT ); Mon, 5 Aug 2019 12:51:14 -0400 Received: from LHREML713-CAH.china.huawei.com (unknown [172.18.7.106]) by Forcepoint Email with ESMTP id 9C1E5B6612111EB1A583; Mon, 5 Aug 2019 17:51:13 +0100 (IST) Received: from [10.210.168.118] (10.210.168.118) by smtpsuk.huawei.com (10.201.108.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 5 Aug 2019 17:51:03 +0100 Subject: Re: [PATCH] KEYS: trusted: allow module init if TPM is inactive or deactivated To: Tyler Hicks , Mimi Zohar CC: Jarkko Sakkinen , , , , , , , , , References: <20190705163735.11539-1-roberto.sassu@huawei.com> <20190711194811.rfsohbfc3a7carpa@linux.intel.com> <20190801163215.mfkagoafkxscesne@linux.intel.com> <20190802142721.GA26616@elm> <20190802194226.oiztvme5klkmw6fh@linux.intel.com> <20190802202343.GE26616@elm> <1565020459.11223.179.camel@linux.ibm.com> <20190805160451.GB3449@elm> From: Roberto Sassu Message-ID: <0d9f2f6f-9a69-5169-a92d-9ca7de3c0d18@huawei.com> Date: Mon, 5 Aug 2019 18:51:09 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: <20190805160451.GB3449@elm> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.210.168.118] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/5/2019 6:04 PM, Tyler Hicks wrote: > On 2019-08-05 11:54:19, Mimi Zohar wrote: >> On Mon, 2019-08-05 at 16:50 +0200, Roberto Sassu wrote: >>> Regarding Mimi's proposal to avoid the issue by extending the PCR with >>> zeros, I think it also achieve the goal. >> >> Roberto, removing the following code from init_digests() would be the >> equivalent to the prior code, without needing to make any other >> changes.  Let's keep it simple.  Do you want to post the patch with >> the change, or should I? >> >> ret = tpm_get_random(chip, digest, TPM_MAX_DIGEST_SIZE); >> if (ret < 0) >> return ret; >> if (ret < TPM_MAX_DIGEST_SIZE) >> return -EFAULT; >> >> As I can't duplicate the problem, it would need to be tested by others >> experiencing the problem. > > The bug reporter tested Roberto's last patch: > > https://bugzilla.kernel.org/show_bug.cgi?id=203953#c8 > > We should Cc the reporter on future patches or at least leave another > testing request in the bugzilla. I don't see the reporter's email. Please ask him to test the new patch. Thanks Roberto -- HUAWEI TECHNOLOGIES Duesseldorf GmbH, HRB 56063 Managing Director: Li Peng, Li Jian, Shi Yanli