From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,
	NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D8D04C4338F
	for <linux-kernel@archiver.kernel.org>; Thu,  5 Aug 2021 00:29:51 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id B654E610FC
	for <linux-kernel@archiver.kernel.org>; Thu,  5 Aug 2021 00:29:51 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S236150AbhHEAaD (ORCPT <rfc822;linux-kernel@archiver.kernel.org>);
        Wed, 4 Aug 2021 20:30:03 -0400
Received: from mail.kernel.org ([198.145.29.99]:37906 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S229991AbhHEAaC (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 4 Aug 2021 20:30:02 -0400
Received: by mail.kernel.org (Postfix) with ESMTPSA id DE4D7610FD;
        Thu,  5 Aug 2021 00:29:47 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1628123388;
        bh=fKieLesTCiXaeb8urF0Ymy+tmaf0uoqUENpfp0I62go=;
        h=Subject:To:Cc:References:From:Date:In-Reply-To:From;
        b=Vn5s/oVc4bdLiD2TOHDBnJ22Avzhv08uEdKUm50DR7qHK/EDLsSSNSy39IkNKM/XF
         KNHE01w6CuBc1oOktxPWGegJMb+8pxk117cVipqwomyhISSjn1ZjM3lLwt0Moe3nC4
         ae1wLfe98IFvzSE4/v92+NuWnKEQ83PL9H4EupHvtedjY72NSYBtlRBkpa8mu+kLGw
         aGSYqPm/KGRvPtNyvPNKF3T7JSz9HdXp5HLocRPutOC+Cc8g6RF2C5SWqk9KkOcdKS
         1uPTGhnpsm/YV3DJMSr+Au9nOB17PgrP08CK3oY4//mCOiEJNrxrzEczka7yVKhbsL
         Ev+48jc/QeSbg==
Subject: Re: [f2fs-dev] [RFC v3] f2fs: extent cache: support unaligned extent
To:     Jaegeuk Kim <jaegeuk@kernel.org>
Cc:     Chao Yu <chao.yu@linux.dev>, linux-kernel@vger.kernel.org,
        linux-f2fs-devel@lists.sourceforge.net
References: <20210804022348.1414543-1-chao@kernel.org>
 <YQsIj0wKk6YbN/FJ@google.com> <YQsmfm3ibU6bhvZr@google.com>
From:   Chao Yu <chao@kernel.org>
Message-ID: <0dad9863-4aa2-3ea3-fd97-457aa635ed66@kernel.org>
Date:   Thu, 5 Aug 2021 08:29:46 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <YQsmfm3ibU6bhvZr@google.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Jaegeuk,

On 2021/8/5 7:45, Jaegeuk Kim wrote:
> Chao,
> 
> How about this?
> https://github.com/jaegeuk/f2fs/commit/d6bbe121bc24dfabfedc07ba7cb6e921fb70ece0

Looks more clean, thanks,

> 
> I'm digging one bug in __insert_extent_tree w/ the patch tho.

Shouldn't we initialize @ei in f2fs_update_extent_tree_range(), otherwise,
__try_merge_extent_node(&ei) -> __is_extent_mergeable() will do the check
w/ uninitialized c_len of @ei.

>> On 08/04, Chao Yu wrote:
>>> +	if (from_dnode)
>>> +		goto skip_reading_dnode;

Wrong condition here, thanks for fixing.

Thanks,