From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61326C47096 for ; Thu, 3 Jun 2021 18:54:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B885613EE for ; Thu, 3 Jun 2021 18:54:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230030AbhFCS4n (ORCPT ); Thu, 3 Jun 2021 14:56:43 -0400 Received: from mga04.intel.com ([192.55.52.120]:14410 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229957AbhFCS4m (ORCPT ); Thu, 3 Jun 2021 14:56:42 -0400 IronPort-SDR: 4cxVX1emJECtk7WQibT1LhHTD6MTD7DbTPFxTHs6DgG3B+Z6ew81RVrtjiMPsxcqzn8K0K4zdh ZNVvr3un5PDQ== X-IronPort-AV: E=McAfee;i="6200,9189,10004"; a="202264746" X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="202264746" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 11:54:54 -0700 IronPort-SDR: cX8H+mQzf8xMh4D17tdHxI5UHTCEw0j6FlJsDp0Bgs6WiplOwV1JNv58xNph/YRAXL3Ex1F2w3 XfpvsM9YdyZg== X-IronPort-AV: E=Sophos;i="5.83,246,1616482800"; d="scan'208";a="480338329" Received: from jacobmon-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.212.36.217]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jun 2021 11:54:53 -0700 Subject: Re: [RFC v2-fix-v2 1/1] x86: Introduce generic protected guest abstraction To: Borislav Petkov Cc: Peter Zijlstra , Andy Lutomirski , Dave Hansen , Tony Luck , Andi Kleen , Kirill Shutemov , Kuppuswamy Sathyanarayanan , Dan Williams , Raj Ashok , Sean Christopherson , linux-kernel@vger.kernel.org, Tom Lendacky References: <20210527042356.3983284-2-sathyanarayanan.kuppuswamy@linux.intel.com> <20210601211417.2177598-1-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <0db0402c-390f-2c5b-8fdc-36462b49e029@linux.intel.com> Date: Thu, 3 Jun 2021 11:54:50 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/3/21 11:41 AM, Borislav Petkov wrote: >> Since you are checking for AMD vendor ID, why not use amd_protected_guest_has()? > Because, as Sean already told you, we should either stick to the > technologies: TDX or SEV or to the vendors: Intel or AMD - but not > either or. Ok. We can go with technologies for now. In future, if protected_guest_has() is extended for other technologies like MKTME, then we can generalize it base on vendor. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer