* [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
@ 2017-03-22 18:04 Fathi Boudra
2017-03-30 12:23 ` Naresh Kamboju
2017-04-19 17:31 ` Fathi Boudra
0 siblings, 2 replies; 5+ messages in thread
From: Fathi Boudra @ 2017-03-22 18:04 UTC (permalink / raw)
To: linux-kselftest, Shuah Khan; +Cc: linux-kernel, Pratyush Anand, Fathi Boudra
To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
It covers only the native build because it's computed from uname -m output.
For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
the test.
Fix the test to allow both native and cross-compilation of the test.
Note: glibc is missing several of the TRAP_* constants in the userspace
definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
---
tools/testing/selftests/breakpoints/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
index 72aa103e4141..6b214b7b10fb 100644
--- a/tools/testing/selftests/breakpoints/Makefile
+++ b/tools/testing/selftests/breakpoints/Makefile
@@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
ifeq ($(ARCH),x86)
TEST_GEN_PROGS := breakpoint_test
endif
-ifeq ($(ARCH),aarch64)
+ifneq (,$(filter $(ARCH),aarch64 arm64))
TEST_GEN_PROGS := breakpoint_test_arm64
endif
--
2.11.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
2017-03-22 18:04 [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 Fathi Boudra
@ 2017-03-30 12:23 ` Naresh Kamboju
2017-04-19 17:31 ` Fathi Boudra
1 sibling, 0 replies; 5+ messages in thread
From: Naresh Kamboju @ 2017-03-30 12:23 UTC (permalink / raw)
To: Fathi Boudra; +Cc: linux-kselftest, Shuah Khan, linux-kernel, Pratyush Anand
Hi Fathi,
On 22 March 2017 at 23:34, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
> It covers only the native build because it's computed from uname -m output.
> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
> the test.
> Fix the test to allow both native and cross-compilation of the test.
>
> Note: glibc is missing several of the TRAP_* constants in the userspace
> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..6b214b7b10fb 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> ifeq ($(ARCH),x86)
> TEST_GEN_PROGS := breakpoint_test
> endif
> -ifeq ($(ARCH),aarch64)
> +ifneq (,$(filter $(ARCH),aarch64 arm64))
> TEST_GEN_PROGS := breakpoint_test_arm64
> endif
This patch works.
Tested on arm64 Hikey development board running 4.9 kernel.
Tested-by: Naresh Kamboju <naresh.kamboju@linaro.org>
- Naresh
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
2017-03-22 18:04 [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 Fathi Boudra
2017-03-30 12:23 ` Naresh Kamboju
@ 2017-04-19 17:31 ` Fathi Boudra
2017-04-19 20:22 ` Shuah Khan
2017-04-27 13:44 ` Shuah Khan
1 sibling, 2 replies; 5+ messages in thread
From: Fathi Boudra @ 2017-04-19 17:31 UTC (permalink / raw)
To: Shuah Khan; +Cc: linux-kernel, Pratyush Anand, linux-kselftest
gentle ping
On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
> It covers only the native build because it's computed from uname -m output.
> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
> the test.
> Fix the test to allow both native and cross-compilation of the test.
>
> Note: glibc is missing several of the TRAP_* constants in the userspace
> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>
> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
> ---
> tools/testing/selftests/breakpoints/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
> index 72aa103e4141..6b214b7b10fb 100644
> --- a/tools/testing/selftests/breakpoints/Makefile
> +++ b/tools/testing/selftests/breakpoints/Makefile
> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
> ifeq ($(ARCH),x86)
> TEST_GEN_PROGS := breakpoint_test
> endif
> -ifeq ($(ARCH),aarch64)
> +ifneq (,$(filter $(ARCH),aarch64 arm64))
> TEST_GEN_PROGS := breakpoint_test_arm64
> endif
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
2017-04-19 17:31 ` Fathi Boudra
@ 2017-04-19 20:22 ` Shuah Khan
2017-04-27 13:44 ` Shuah Khan
1 sibling, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2017-04-19 20:22 UTC (permalink / raw)
To: Fathi Boudra; +Cc: linux-kernel, Pratyush Anand, linux-kselftest, Shuah Khan
On 04/19/2017 11:31 AM, Fathi Boudra wrote:
> gentle ping
>
> On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
>> It covers only the native build because it's computed from uname -m output.
>> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
>> the test.
>> Fix the test to allow both native and cross-compilation of the test.
>>
>> Note: glibc is missing several of the TRAP_* constants in the userspace
>> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
I plan to get to it towards the end of this week. Thanks for
the ping.
-- Shuah
>> ---
>> tools/testing/selftests/breakpoints/Makefile | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/breakpoints/Makefile b/tools/testing/selftests/breakpoints/Makefile
>> index 72aa103e4141..6b214b7b10fb 100644
>> --- a/tools/testing/selftests/breakpoints/Makefile
>> +++ b/tools/testing/selftests/breakpoints/Makefile
>> @@ -5,7 +5,7 @@ ARCH ?= $(shell echo $(uname_M) | sed -e s/i.86/x86/ -e s/x86_64/x86/)
>> ifeq ($(ARCH),x86)
>> TEST_GEN_PROGS := breakpoint_test
>> endif
>> -ifeq ($(ARCH),aarch64)
>> +ifneq (,$(filter $(ARCH),aarch64 arm64))
>> TEST_GEN_PROGS := breakpoint_test_arm64
>> endif
>>
>> --
>> 2.11.0
>>
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64
2017-04-19 17:31 ` Fathi Boudra
2017-04-19 20:22 ` Shuah Khan
@ 2017-04-27 13:44 ` Shuah Khan
1 sibling, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2017-04-27 13:44 UTC (permalink / raw)
To: Fathi Boudra; +Cc: linux-kernel, Pratyush Anand, linux-kselftest, shuah Khan
On 04/19/2017 11:31 AM, Fathi Boudra wrote:
> gentle ping
>
> On 22 March 2017 at 20:04, Fathi Boudra <fathi.boudra@linaro.org> wrote:
>> To build breakpoint_test_arm64, ARCH value is only tested for "aarch64".
>> It covers only the native build because it's computed from uname -m output.
>> For cross-compilation, ARCH is set to arm64 and prevent to cross-compile
>> the test.
>> Fix the test to allow both native and cross-compilation of the test.
>>
>> Note: glibc is missing several of the TRAP_* constants in the userspace
>> definitions. Specifically TRAP_BRANCH and TRAP_HWBKPT.
>> See https://sourceware.org/bugzilla/show_bug.cgi?id=21286
>>
>> Signed-off-by: Fathi Boudra <fathi.boudra@linaro.org>
>> ---
Applied to linux-kselftest next.
thanks for the patch.
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-04-27 13:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-22 18:04 [PATCH 1/1] selftests: breakpoints: allow to cross-compile for aarch64/arm64 Fathi Boudra
2017-03-30 12:23 ` Naresh Kamboju
2017-04-19 17:31 ` Fathi Boudra
2017-04-19 20:22 ` Shuah Khan
2017-04-27 13:44 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).