From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Adam Ford <aford173@gmail.com>, Fabio Estevam <festevam@gmail.com>
Cc: DRI mailing list <dri-devel@lists.freedesktop.org>,
David Airlie <airlied@linux.ie>,
Adam Ford-BE <aford@beaconembedded.com>,
stable <stable@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display
Date: Tue, 16 Jun 2020 15:30:45 +0300 [thread overview]
Message-ID: <0df0bf28-dbf7-4d1e-06f0-d545df8dc2d5@ti.com> (raw)
In-Reply-To: <CAHCN7x+=xjFTy6J4Ej61U2jXTez2rLrt=KtEOzbvV7Tzq6XoPQ@mail.gmail.com>
On 15/06/2020 17:53, Adam Ford wrote:
> On Mon, Jun 15, 2020 at 9:46 AM Fabio Estevam <festevam@gmail.com> wrote:
>>
>> On Mon, Jun 15, 2020 at 10:19 AM Adam Ford <aford173@gmail.com> wrote:
>>>
>>> The LogicPD Type28 display used by several Logic PD products has not
>>> worked since v5.5.
>>
>> Maybe you could tell which commit exactly and then put a Fixes tag?
>
> I honestly don't know. I reached out to the omap mailing list,
> because I noted this issue. Tomi V from TI responded with a link that
> he posted which fixes this for another display.
>
> https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg312208.html
>
> I tested that patch and it worked for a different LCD, so I did the
> same thing to the Logic PD Type 28 display as well.
>
> My patch and commit message were modeled after his, and his commit
> CC's stable with a note about being required for v5.5+
>
> I added him to the CC list, so maybe he knows which hash needs to be
> referenced from a fixes tag. I was hoping to not have to go back and
> bisect if it's not required, but I will if necessary.
No, I didn't check when exactly it broke. connector_type was added in v5.5, and my patch applies to
v5.5, so I set that as stable version. But the WARN comes from panel bridge. Possibly
89958b7cd9555a5d82556cc9a1f4c62fffda6f96 is the one that adds requirement to have connector_type.
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-06-16 12:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-15 13:19 [PATCH] drm/panel-simple: fix connector type for LogicPD Type28 Display Adam Ford
2020-06-15 14:45 ` Fabio Estevam
2020-06-15 14:53 ` Adam Ford
2020-06-16 12:30 ` Tomi Valkeinen [this message]
2020-06-21 6:22 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0df0bf28-dbf7-4d1e-06f0-d545df8dc2d5@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=festevam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).