From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D20C433DB for ; Thu, 18 Feb 2021 18:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DC74264EB6 for ; Thu, 18 Feb 2021 18:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231129AbhBRSaO (ORCPT ); Thu, 18 Feb 2021 13:30:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233146AbhBRQIu (ORCPT ); Thu, 18 Feb 2021 11:08:50 -0500 Received: from mail.kapsi.fi (mail.kapsi.fi [IPv6:2001:67c:1be8::25]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3E1FC061574 for ; Thu, 18 Feb 2021 08:00:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kapsi.fi; s=20161220; h=Content-Transfer-Encoding:Content-Type:Message-ID:References: In-Reply-To:Subject:Cc:To:From:Date:MIME-Version:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=VLLtZPx/WCVOTnXSsy/JatPvxuCHdJJNlBU9i3LFq9g=; b=S1w2AJl9Qg0k0Ra/KpPo3c83gl RlX5s3YwjMzvXvzCeof48MejpivZbTfHKYq86YuxIDCDZxrIBzUTe9vF9oIwwqRJzrCUQV1BkwV9p 22ev3SvWlfwxMQy3ySPomu2EbQHZrZ01kGIZipiqKn234dYp7eICZOcVJWneh3Nkoj7iDOrqIzX/t jbl7kHeOHdwMO7cbks9B0+LubmOQWAfNH1au2KteOMJoNhN/pYiocemzv+dxV6Od25Liz91cVRTDT lRrLSTW1Pb+OPuJgX0mr/QteqoCxAH2QCpLSw74FS2DBL/pDoWjKdWwLCdtchxXUGIDJ2//AomX2x 4pRn7GUA==; Received: from webng-gw.kapsi.fi ([91.232.154.200] helo=roundcube.kapsi.fi) by mail.kapsi.fi with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lClj9-0002OX-35; Thu, 18 Feb 2021 18:00:27 +0200 MIME-Version: 1.0 Date: Thu, 18 Feb 2021 18:00:23 +0200 From: Jyri Sarha To: Dario Binacchi Cc: linux-kernel@vger.kernel.org, Daniel Vetter , David Airlie , Tomi Valkeinen , dri-devel@lists.freedesktop.org Subject: Re: [RESEND PATCH] drm/tilcdc: fix raster control register setting In-Reply-To: <20210216202225.12861-1-dariobin@libero.it> References: <20210216202225.12861-1-dariobin@libero.it> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <0e1595a66d8539339a5e31927ef59857@iki.fi> X-Sender: jyri.sarha@iki.fi Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 91.232.154.200 X-SA-Exim-Mail-From: jyri.sarha@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-02-16 22:22, Dario Binacchi wrote: > The fdd property of the tilcdc_panel_info structure must set the reqdly > bit field (bit 12 to 19) of the raster control register. The previous > statement set the least significant bit instead. > > Signed-off-by: Dario Binacchi Reviewed-by: Jyri Sarha Tested-by: Jyri Sarha Thanks for a good catch. I'll merge to this drm-misc-next soon. Best regards, Jyri > > --- > > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index 30213708fc99..238068e28729 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -393,7 +393,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc > *crtc) > return; > } > } > - reg |= info->fdd < 12; > + reg |= info->fdd << 12; > tilcdc_write(dev, LCDC_RASTER_CTRL_REG, reg); > > if (info->invert_pxl_clk)