From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752824AbcHZNHj (ORCPT ); Fri, 26 Aug 2016 09:07:39 -0400 Received: from mout.web.de ([212.227.17.12]:61913 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750715AbcHZNHh (ORCPT ); Fri, 26 Aug 2016 09:07:37 -0400 Subject: [PATCH 8/8] cris-cryptocop: Apply another recommendation from "checkpatch.pl" To: linux-cris-kernel@axis.com, Adam Buchbinder , Dave Hansen , Ingo Molnar , Jesper Nilsson , Jiri Kosina , Mikael Starvik , Thomas Gleixner References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Paolo Bonzini From: SF Markus Elfring Message-ID: <0e29d372-ef5f-afa7-50b1-70ddc089ef00@users.sourceforge.net> Date: Fri, 26 Aug 2016 15:00:04 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fuQnfrOF84eRk148EkSjbApQvOyaaJqpCBDgQeDH5J/fWdEw96C h7uiMlb1rVVFMkSgoPEYZALcrKESNwRRMSKMhrrVzDmruK1Y1dRq44W/ulthw2Rtvt+AD+E G9KOxOLWhD7PRaZiJMLi8wMUle0EnKGb4GrOvyHL/84Jt2Pe0syTNZFceJANXqHnElDnty3 a8YWEqtCsSbEc+a2SZPAw== X-UI-Out-Filterresults: notjunk:1;V01:K0:CuVXWsCZE5E=:mxoKhJnO3bH8OPpw2eyIWh 5KFYuFcW8aeKljGbT7o+FI4ju4PBSNK1ibGly/RoOs7lBNPpviTwLUF2JxOmqHfc+vlRTBJ3+ KNbsdqYTwQ1S+O3oN/LXxOyPrygQaBWeOuYX1W/Gk59vkw5iiHE47vFvKNpfbJAZg31/Z9KW+ rkt1kpkIObJizLvy/Ll5/U0ZC3SfeQGmqO17T2ui/BVdhky6bYjURDml7H2VwKN3aNSBPGxzy xr4oSomjpuuiRuUBeynM0SVJryg2bRnXCnvX+ttslL1wZY4/u0ygeugywacxjn8u9NrLq94Y5 QWIWKGEAzPSQCyCMaCZe6yoBl+7lV3ESBeKEycjq2WLl9/tgbZ4S9tw9YQP6+/mZHraFDhDmE ytcJtwptwtzJSC4+3fFAxrTSQcm47NYLqVyhx/2n6NJ+0g6VSY1M1ULZ1iltt+n3c3X9O5+4P gtBV/02BJ1HplgW0uGC3GEk1V+ipJ7Jr8aIGmPfjp+h7ES+UCP0cepgvSQKSRkAcyHsb5hEtH UXA8Ig4kpErnOmJmjzfm22lyEDJ10DHrww36DkJINQqjPfFwUnETBe1Ox6j/BaBGWKp0DCf9+ qcItuXL50DMr6g5WCQhBIjYcj4nlDmIPELr/Os/egLfDFfygrQYLTT3lBfRfQRM/lAceyA+C3 6MFrQxpFc0YiLgaCnM9PaY/HVjrJn1glteZnrI+834FotajghrQNyz2bZRgrXga6rJgfAL3q9 mw0qqrTaqyg5MXmuL1U1B7pWNvY0F2uV5blIdvlUrO6iXgUhejMJ5NXDHymRp6wMEvtssb3az aRUAmj9 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Fri, 26 Aug 2016 14:23:06 +0200 The script "checkpatch.pl" can point out that assignments should usually not be performed within condition checks. Thus move the assignments for a local variable to separate statements in three functions. Signed-off-by: Markus Elfring --- arch/cris/arch-v32/drivers/cryptocop.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/cris/arch-v32/drivers/cryptocop.c b/arch/cris/arch-v32/drivers/cryptocop.c index 1a966dc..00231a7 100644 --- a/arch/cris/arch-v32/drivers/cryptocop.c +++ b/arch/cris/arch-v32/drivers/cryptocop.c @@ -1510,7 +1510,8 @@ int cryptocop_new_session(cryptocop_session_id *sid, struct cryptocop_transform_ while (tfrm_in){ int err; ++no_tfrms; - if ((err = transform_ok(tfrm_in))) { + err = transform_ok(tfrm_in); + if (err) { DEBUG_API(printk("cryptocop_new_session, bad transform\n")); return err; } @@ -2276,7 +2277,10 @@ static int cryptocop_job_setup(struct cryptocop_prio_job **pj, struct cryptocop_ (*pj)->iop->ctx_in.saved_data = operation->list_op.inlist; (*pj)->iop->ctx_in.saved_data_buf = operation->list_op.in_data_buf; } else { - if ((err = cryptocop_setup_dma_list(operation, &(*pj)->iop, alloc_flag))) { + err = cryptocop_setup_dma_list(operation, + &(*pj)->iop, + alloc_flag); + if (err) { DEBUG_API(printk("cryptocop_job_setup: cryptocop_setup_dma_list failed %d\n", err)); kfree(*pj); return err; @@ -2867,7 +2871,8 @@ static int cryptocop_ioctl_process(struct inode *inode, struct file *filp, unsig DEBUG(printk("cryptocop_ioctl_process: inserting job, cb_data=0x%p\n", cop->cb_data)); - if ((err = cryptocop_job_queue_insert_user_job(cop)) != 0) { + err = cryptocop_job_queue_insert_user_job(cop); + if (err) { DEBUG_API(printk("cryptocop_ioctl_process: insert job %d\n", err)); err = -EINVAL; goto mark_outpages_dirty; -- 2.9.3