From: Guenter Roeck <linux@roeck-us.net>
To: Alex Qiu <xqiu@google.com>,
Grant Peltier <grant.peltier.jg@renesas.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Adam Vaughn <adam.vaughn.xh@renesas.com>,
Guenter Roeck <groeck7@gmail.com>
Cc: Jason Ling <jasonling@google.com>
Subject: Re: [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228
Date: Tue, 13 Oct 2020 11:37:54 -0700 [thread overview]
Message-ID: <0e325e4f-bb7c-f2d3-1f16-34a89397df39@roeck-us.net> (raw)
In-Reply-To: <CAA_a9xLcCuR+WFfNtpJgq14rGZfxcqsoVz5aNhL5XCLhV+TwNg@mail.gmail.com>
On 10/13/20 11:18 AM, Alex Qiu wrote:
> (Intercepting the email thread...)
>
> Hi Grant,
>
> Looks like you made a typo in your patch:
>
>> + case raa_dmpvr2_2rail_nontc:
>> + info->func[0] &= ~PMBUS_HAVE_TEMP;
>> + info->func[1] &= ~PMBUS_HAVE_TEMP;
>> + fallthrough;
>
> Did you mean "/* fallthrough */" instead of "fallthrough;"?
>
No, that is the fancy new way to indicate fallthrough in the kernel.
It is converted to either
__attribute__((__fallthrough__))
or to
do {} while (0)
in include/linux/compiler_attributes.h.
Guenter
next prev parent reply other threads:[~2020-10-13 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 18:18 [PATCH] hwmon: (pmbus/isl68137) remove READ_TEMPERATURE_1 telemetry for RAA228228 Alex Qiu
2020-10-13 18:22 ` Alex Qiu
2020-10-13 18:37 ` Guenter Roeck [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-08-10 18:36 Grant Peltier
2020-08-11 17:17 ` Guenter Roeck
2020-08-11 17:24 ` Grant Peltier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e325e4f-bb7c-f2d3-1f16-34a89397df39@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adam.vaughn.xh@renesas.com \
--cc=grant.peltier.jg@renesas.com \
--cc=groeck7@gmail.com \
--cc=jasonling@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xqiu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).