From: Dan Murphy <dmurphy@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: <lgirdwood@gmail.com>, <perex@perex.cz>, <tiwai@suse.com>,
<robh@kernel.org>, <alsa-devel@alsa-project.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property
Date: Fri, 12 Jun 2020 11:18:57 -0500 [thread overview]
Message-ID: <0e482167-71c2-a128-b8b4-a054557d30e9@ti.com> (raw)
In-Reply-To: <20200612160922.GL5396@sirena.org.uk>
Mark
On 6/12/20 11:09 AM, Mark Brown wrote:
> On Fri, Jun 12, 2020 at 11:06:03AM -0500, Dan Murphy wrote:
>
>> - tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shut-down-gpio",
>> + tas2562->sdz_gpio = devm_gpiod_get_optional(dev, "shutdown",
>> GPIOD_OUT_HIGH);
> This also changes the name from shut-down to shutdown which will be
> incompatible (IIRC we do try -gpio as well as -gpios).
Yes the non-standardish name was highlighted by Rob[1].
Also I checked the GPIO library and it looks at both -gpio and gpios as
property suffixes.
Since this is a single GPIO the singular should be used in this case
[1] https://lore.kernel.org/patchwork/patch/1251670/
Dan
next prev parent reply other threads:[~2020-06-12 16:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 16:06 [PATCH v3 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy
2020-06-12 16:06 ` [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property Dan Murphy
2020-06-12 16:09 ` Mark Brown
2020-06-12 16:18 ` Dan Murphy [this message]
2020-06-12 16:22 ` Mark Brown
2020-06-12 16:27 ` Dan Murphy
2020-06-12 16:30 ` Mark Brown
2020-06-12 16:56 ` Dan Murphy
2020-07-23 16:08 [PATCH v3 1/2] dt-bindings: tas2562: Convert the tas2562 binding to yaml Dan Murphy
2020-07-23 16:08 ` [PATCH v3 2/2] ASoC: tas2562: Update shutdown GPIO property Dan Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e482167-71c2-a128-b8b4-a054557d30e9@ti.com \
--to=dmurphy@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).