From: Randy Dunlap <rdunlap@infradead.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Cc: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
sound-open-firmware@alsa-project.org,
"moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER
MANAGEM..." <alsa-devel@alsa-project.org>
Subject: Re: [Sound-open-firmware] linux-next: Tree for Nov 6 (sound/soc/sof/sof-pci-dev.o)
Date: Fri, 6 Nov 2020 14:31:41 -0800 [thread overview]
Message-ID: <0e8f0a8b-60c4-d146-90a2-a972d1748a4c@infradead.org> (raw)
In-Reply-To: <7505ed68-f12b-d1d9-12e5-f8ae34a74ebd@linux.intel.com>
On 11/6/20 12:53 PM, Pierre-Louis Bossart wrote:
>
>> on x86_64:
>>
>> ld: sound/soc/sof/sof-pci-dev.o: in function `sof_pci_probe':
>> sof-pci-dev.c:(.text+0x5c): undefined reference to `snd_intel_dsp_driver_probe'
>>
>>
>> Full randconfig file is attached.
>
> Nice catch, thanks Randy! Looks like we put the select SND_INTEL_DSP_CONFIG in the wrong place, it's not dependent on the HDaudio link being selected. Clearly a bug we've had for a while.
>
> The diff below makes the error go away but I have to run it past folks who are already enjoying their week-end. Will follow-up next week with a proper fix.
Works for me. You can have an Ack if you use this patch.
Thanks.
Acked-by: Randy Dunlap <rdunlap@infradead.org>
> diff --git a/sound/soc/sof/intel/Kconfig b/sound/soc/sof/intel/Kconfig
> index a066e08860cb..5bfc2f8b13b9 100644
> --- a/sound/soc/sof/intel/Kconfig
> +++ b/sound/soc/sof/intel/Kconfig
> @@ -271,6 +271,7 @@ config SND_SOC_SOF_JASPERLAKE
>
> config SND_SOC_SOF_HDA_COMMON
> tristate
> + select SND_INTEL_DSP_CONFIG
> select SND_SOC_SOF_INTEL_COMMON
> select SND_SOC_SOF_HDA_LINK_BASELINE
> help
> @@ -330,7 +331,6 @@ config SND_SOC_SOF_HDA
> tristate
> select SND_HDA_EXT_CORE if SND_SOC_SOF_HDA_LINK
> select SND_SOC_HDAC_HDA if SND_SOC_SOF_HDA_AUDIO_CODEC
> - select SND_INTEL_DSP_CONFIG
> help
> This option is not user-selectable but automagically handled by
> 'select' statements at a higher level
>
>
--
~Randy
prev parent reply other threads:[~2020-11-06 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 6:18 linux-next: Tree for Nov 6 Stephen Rothwell
2020-11-06 17:22 ` linux-next: Tree for Nov 6 (sound/soc/sof/sof-pci-dev.o) Randy Dunlap
2020-11-06 20:53 ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-11-06 22:31 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e8f0a8b-60c4-d146-90a2-a972d1748a4c@infradead.org \
--to=rdunlap@infradead.org \
--cc=alsa-devel@alsa-project.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sfr@canb.auug.org.au \
--cc=sound-open-firmware@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).