From: Jacek Anaszewski <jacek.anaszewski@gmail.com>
To: "Krzysztof Kozlowski" <krzk@kernel.org>,
"Rafał Miłecki" <rafal@milecki.pl>, "Pavel Machek" <pavel@ucw.cz>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: gpio: Drop unneeded manual of_node assignment
Date: Sat, 8 Dec 2018 19:02:42 +0100 [thread overview]
Message-ID: <0e918f62-a210-bcba-416a-db2178eade08@gmail.com> (raw)
In-Reply-To: <1544177406-24752-1-git-send-email-krzk@kernel.org>
Hi Krzysztof,
Thank you for the patch.
On 12/7/18 11:10 AM, Krzysztof Kozlowski wrote:
> This reverts the main change of commit bff23714bc36 ("leds: leds-gpio:
> Set of_node for created LED devices") because of_node assignment is
> handled by core since commit 7ea79ae86c28 ("leds: gpio: use OF variant
> of LED registering function"). Basically the code was overwriting the
> of_node with same value.
>
> No functional change expected.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/leds/leds-gpio.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/leds/leds-gpio.c b/drivers/leds/leds-gpio.c
> index 45e012093865..998f2ff6914d 100644
> --- a/drivers/leds/leds-gpio.c
> +++ b/drivers/leds/leds-gpio.c
> @@ -190,7 +190,6 @@ static struct gpio_leds_priv *gpio_leds_create(struct platform_device *pdev)
> fwnode_handle_put(child);
> return ERR_PTR(ret);
> }
> - led_dat->cdev.dev->of_node = np;
> priv->num_leds++;
> }
>
>
Applied.
--
Best regards,
Jacek Anaszewski
prev parent reply other threads:[~2018-12-08 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-07 10:10 [PATCH] leds: gpio: Drop unneeded manual of_node assignment Krzysztof Kozlowski
2018-12-07 11:24 ` Rafał Miłecki
2018-12-08 18:02 ` Jacek Anaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0e918f62-a210-bcba-416a-db2178eade08@gmail.com \
--to=jacek.anaszewski@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rafal@milecki.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).