From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760727AbdCVQM0 (ORCPT ); Wed, 22 Mar 2017 12:12:26 -0400 Received: from mail-eopbgr00137.outbound.protection.outlook.com ([40.107.0.137]:49177 "EHLO EUR02-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759100AbdCVQMS (ORCPT ); Wed, 22 Mar 2017 12:12:18 -0400 Authentication-Results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=virtuozzo.com; Subject: Re: [PATCH] x86: remove unused atomic_inc_short() To: Dmitry Vyukov , , References: <20170322141044.19049-1-dvyukov@google.com> CC: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Peter Zijlstra , , Mark Rutland From: Andrey Ryabinin Message-ID: <0ea4124d-28f8-bf54-03f0-ceee60f3cf8d@virtuozzo.com> Date: Wed, 22 Mar 2017 19:13:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170322141044.19049-1-dvyukov@google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.6] X-ClientProxiedBy: AM4P190CA0019.EURP190.PROD.OUTLOOK.COM (10.172.213.157) To HE1PR0801MB2060.eurprd08.prod.outlook.com (10.168.95.136) X-MS-Office365-Filtering-Correlation-Id: 4d88485d-33b3-4dfd-3adb-08d4713e3481 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:HE1PR0801MB2060; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2060;3:fpmINEcB4mAm4zjI/2HA9aeb//IjZZJ6Z0bGOAmvGzNXQDyG8O45KVfZl434j9HzdUgslCdFsSHJhV4f7ScDTDmeOIm8SG/YUewd3MBrGXDWi09Gy3F9F3x+m5RBnGBoAxBJubgh5cCr9vn3jtgjjcNWrdSgDQpeTSRxqmNHDACI9itZV+Bl3NsyCjC6tXE0OSvLo/rC2ZsNTH2bs+gTVjRVxhZ8a5QmfeabPcVgh2zwz1CbwdEhiyzw6ogWhUnFBNjMcOep/5hDbXkZkYBg0Q==;25:AqUO/5aouo65ay+/6xRIfnIWZJHogQCM1ao7wE72IXkd4wc8GSovpiMTNrHvlHNdy6P+HQGC6X+Jmf/h2kEJaBBAH08NeUdVpXZztUfX5V9YuaYPbEPyI2hdLbUif1nAir14aM38HM+frrJFuW4QI1i/v1ne5SBDt1q+yaV/+u87c84/tfrO4bXiwEEPedVB3AxFy4lBALiQQ1yZEWs2aXhu3IGXj373MWeXDv0qcOdPsF1tPr42zSv4U/cVScGkH48J7VXL9WayEXDBnWM/XFySxGxNrCRADk7LewUKKxw4ZrtxhDUGYtVC4pnYkhFEP4UOo4utc2Y5G9qR9U4RbYVA7XZ6Pqba/kTAaT8WPhNdTseO93FHvE3a3RXScxky/NIfJV6aVJD82nZqby0i+2JCMpcq9ZkVlss5FxpiovE+nk/kcrjTYl3mbV5o9ghRdHgJwpltl9gbda9nQDAGog== X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2060;31:bVJGC19g3j8kSDzCytvln7U+10gQpR2o5ebaYUd6RgtkfAsKc5l9DioxMOCEY94K2nn64CVo3ckpfrrNe6tzl6sU3wy54ezSHd8ckWH2BU+GExnsa1uBBuXT3hbhvEA25HDIbl+UxuvuhILfawNM1BjAL6N1BFTb+qYK73ofVOSVi1F6YPWiNoa3KQBhBYpFS8g3yarjPz5i+Xit2sGB5mQlYOgNRoWmn3dtvyQBG2RX4xAs7vEp3KIKukA7DyogO+s9iNtUzk879TeJQtwkSg==;20:ptNP2qNVPuIxcoip9KYG7GgeGPVh+re1s4DGUFUZaE5WexS1wFxc/dEfy9jBeBeUy31dCcWEMRz5/HY4k6oY8St2RnOdWsrmWbmJB9wI0PNgNDMz+o6L+wVvadu8Z3pEv+XiPtxiSFmko3S3hkU34MLBdvt0zqGwp/j/pjAtHjqM358vHjzCXsmxgMs/2dSIFLv2dNb+jXWLBosokjWA6zXD35tslWUdRdx81VslweCMMuqnK199ZTB2BkJymyrQuG/Ljuj3uoV1I4IHGGpC7B57QDBL+iFAIFInEC2A7pyby92mlr8tKdVBOpI6jyC90fF3RK78botPcOhJyOBi9CFMBqR282hgOUFsRHa4ubWB+VDK5CoS9NLkBdwoqU0tLg3dlC8DDhVRHysOAo+XsfmcF7HbQ9LyQ3z6R19bLdU= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917)(9452136761055)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123558025)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:HE1PR0801MB2060;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB2060; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2060;4:+ESkBcPKkxDm/+CzQBS4a47MyNjmbk2/D8UWoGVhtb2GIdAwP08YLPLQFsMmL9XqbleLOP8MzQJYlTsapSSZM27LxCCXdbalTvLI+9sKADKC8g6fov/e1ILm0qadLnqWGAsgXnL1sIB3BPc7vR51vrJ915RhMT1dqurVLt15+dePmDNj3F8frPdYXXhF/OCDQ6PgQdxzZ4YuCcU88A2mDAw97Nghf+0/++8BZXT8GlDxn9KjHFhsqsrwf/DAg9dURVvGCOLdPvc4jwfjeZfYeRbjQ+k2RZkvRx+RRby1Q6Zht8u5QXnmwOoSvhNLzfd+7rONmH801OjABNABGudw0D2jZyy/F48vsh0ixm/+lzrAk3iw41LneLOZQaR1zJ3SheB/PT+T7ZWudr1S6jm8ux7eQOay47oeg/hEo643zwfE3vTkz7cmg4/Div/PVX6wfcxC1YJjVU49nJZrqhmoTdwKEDp7k7hnMN/JFZDZ/LVtjXY9cew/dwCE8iZWsCkjwGsd8fw8cF8ULfzUefrQF3OikEAztq691ewu/z4SU70znF41Ga1+twWbOmHm+j7gg6gJVqtRgLj6gsmz3qg1LFcxC9c54/sW6TJKlPGQxjMn+GEw3Fw7WlSyGVqlBDpeTxjb3hKSTKxb8SXjhkxJAfSSn3xsoQes4kxCKGDIv0lXDKpMXRFElbtq6DO+jq/2c3JpLjHVRrLuiZnPkDVEnw== X-Forefront-PRVS: 02543CD7CD X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(979002)(6049001)(6009001)(39410400002)(39830400002)(39450400003)(24454002)(377454003)(38730400002)(77096006)(6486002)(31696002)(229853002)(86362001)(2906002)(6116002)(33646002)(3846002)(4001350100001)(53936002)(230700001)(81166006)(76176999)(36756003)(53546009)(65806001)(2201001)(47776003)(25786009)(6666003)(54356999)(2950100002)(50986999)(64126003)(54906002)(6246003)(4326008)(50466002)(83506001)(42186005)(31686004)(66066001)(65956001)(575784001)(5660300001)(23746002)(8676002)(90366009)(305945005)(189998001)(65826007)(7736002)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB2060;H:[172.16.25.12];FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0801MB2060;23:h4Z3Dig5Lm5iV0ByaxofZ5K6apHrfWj0Cn1?= =?Windows-1252?Q?rQxaq7ozkmyoEraeJrUnzWNdswLsO+8AfVdp5Dfz1LosLHqxN3sczCJl?= =?Windows-1252?Q?bgqAocaN8YoHP8NHQeBbHYIu/55obNHwyDtX27/+whVL9rKqstKsSvP3?= =?Windows-1252?Q?3NPo29fbK/JcbpOZDS3K0kNLNN+voonlvQytOf1eICnKj69QoAWzIWWH?= =?Windows-1252?Q?VjH5NJCG9WNhhEQ6jkYSzLj1zcXD6YHGX8IS4EFabRwBClbpIqEZ0nZW?= =?Windows-1252?Q?LaF6U8mn7z12j3wO+sVlWCJbWf92kmciaY/KudsnwNimXiVwULGFBRQD?= =?Windows-1252?Q?QGZT/fBM2ho8kFyK8OhepnAPi3y10QRfI4nc9l5bIkro3Lp5AcVLIQ/W?= =?Windows-1252?Q?H5gMRyTU+XTeKJ46j6CZ2Bh3VYYgb3YzbmOKumhNHWujsoZGa8ievp4C?= =?Windows-1252?Q?il99gDHsMdjqFJs1HW27cia1RfKlbeoz7LqOmg3/dYkEUJ/6cTi44F/j?= =?Windows-1252?Q?kcaZZOC/VD3zTgkgyRUoLCDydFBe+e/KeLerkcuMg6Uv4cnPkSluvErM?= =?Windows-1252?Q?TeR9F1j33rCRU+FiIdYCv1/k48zvUy+ESDuXEp19rG0CI9DJQkEOljHi?= =?Windows-1252?Q?EqNA7zeGOFDEoEgforYbAQ1AjeYJahYC2Cvc0/14adCa+vBPnQrclB5j?= =?Windows-1252?Q?wgmnPz9XeQTfqYFIazAobT81J+PjJhnj5pQ37DF5t/6avOxjekv0tZO/?= =?Windows-1252?Q?H4vjEkm5fnT2fFKmABOLgnagWDBXwJpQCKbT0p6AP1D3hl4YdZwhN7C2?= =?Windows-1252?Q?KdNWj8f6oWzGBk/H7MPxl98o4kAAtSwvdFOJti7WDxHynSe1a6Aa1iKC?= =?Windows-1252?Q?6Sjx3X//AU52a0JzIoi2T09kwAO7E/x30ActzwPaNseLMaKDpOOLD8aU?= =?Windows-1252?Q?RrZ7PtYTAdMzmdCtHvWrlc/1iHcQGBdPiQDO5JY+1B8TiZzLMH71Hxui?= =?Windows-1252?Q?eOWrguBhe/ilsJ37+Wh3RwnflmCsUH9VcvK390sbn7eNSPDvYaxgWWdQ?= =?Windows-1252?Q?4HMKPu/cpi6b5a0KXLVtyTRg2C2GA0tQmZ572FRFOe0g75Ih2nHcfL5U?= =?Windows-1252?Q?YkC7Vd48fI5VRtqBr5oPEK/l3FrAYBSHnqdrPQNNeW5mDpy3A900j0Vh?= =?Windows-1252?Q?dk2JJ1KUGPGW5U0FBY9EWqxn/wn/kdjypF0gI7USEOkd5RusRMTzQLYN?= =?Windows-1252?Q?S6x740cGYP4XjcVcyRLthCDy4vHSXoHyWdV3wDUSsBCtvB0Tju4kra08?= =?Windows-1252?Q?lG2ghXEeRbGmwYU7w3QD55efkjEe1Q7k2QJBGdQHTwxxHvZWIGaICOuD?= =?Windows-1252?Q?E7Ipy3lLe+8Xo/oZpsylMFYTbk3XeKUdWC9SLcmHJA1HVzSCZDkKNJcf?= =?Windows-1252?Q?WpD84bkIfzWHq174A7/ffKINOHR9PXPRuBxC2hfyfpXrdgX28lcu+0aD?= =?Windows-1252?Q?Oe/OvUiE=3D?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2060;6:Yl+C38JoJraBLD8EL2caj0jImQ3EUuyGL/8B/o4SOcUHJp5MxsGU7tRe4jE+xZ+gkMlr84gBNfmcmbAmyu3va+NIinsybKxyswg1CXkb3aOJEjZP+fAfaysZi2bQwkiL130NbiUwBiAOkiz1eKFBnkTxBxvpKKQpwh/R2nmHFsQs/SeSyLjpCRxVHVfSxEmyhlaGOpGQpTSvh1Z8QE0Mrsl6d3Pvx2B+24igCOU++7C3wMx8N7HpdY3cR2Uss75xahg/ZmYBdhrRzPzrehAPuLn6NTieTitwsAOrC4zuzcxCwVoFIxmOpUSeG2OE2z23THgz7JGuH1+oGI0PM88xlQYIfn1ruDm5TeVtIeShPtAUMRHeUPcaSaAmbSmQe6X6wu55QZAPyLL2E6vQ/8hvww==;5:Lnd59raKHT9ruarVcRzqgO5awk8/E5nWlTU9MnNe5vwtjfJQsg4G/2/1jCeAutl4pPt5yPf7RfDVWtsx88EjfDb2xCxFU6Yw0rToHRcS0N7YkT0rijuB0/PECwMYVjaesmvP719paaipPCVvwpqu/Q==;24:8xyOIHYMHRtuFwkICztyAIln1xuB24S1WVqwNnaf17FX5THvQuw3rAzM5/aDK2VSaV/JVa4CSaxOWCFMF1to4u0mH3B4bD8P73F5cfI8v0o= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB2060;7:uHpZSDdQVLlZ3GB8iP/LMDzTSmIRTQPHkhsCr7+M5j9UOc0OcgixXTd4/tLjTebx4Ns890v6H6ZpT67HNsPVKjeVSuWeNwJv4+qelUwnlJ1jUSXb3HSGiOD1RC6TQsUSM2sOMMIwUXnnr2LlhsgbKo/v8ogoWcHdgeJtRTfIQUDs/qGJr1PAt8gldoNx9HadAo9D7PIR1S6GRVDmy/RQXkSx1YlAlI/O7R5ol9bmR0OXAd8nf4X6i/ynxDnSTkWR4TvzuPKb4wQ8PjfhLNvGtfzyvpwSCF6TcI+/3uuGKNMCTEbPSLQjrMY3sABmXoRjsqcPtk7uewFJWHvjNdcWCw==;20:/etQM3nBvRIteHbSzz3yLUxuMpa/o7u9I8Iw28Awqbcb6Z7+Y5V0tw2nWif8yIfSWwvy6gsA/89Ah0YAdVKIt6y/DmIN7ra7YAs+GS5nf8PA7pCLkVDGhijF07/bxHO6Bc9wt78ShkDkWbQSh6hX2D/KqaGe7iewVL3Ia+gdI+A= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Mar 2017 16:12:14.0390 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB2060 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/22/2017 05:10 PM, Dmitry Vyukov wrote: > It is completely unused and implemented only on x86. > Remove it. > > Signed-off-by: Dmitry Vyukov > Suggested-by: Andrey Ryabinin Not me, it was Mark Rutland > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Peter Zijlstra > Cc: Andrew Morton > Cc: linux-kernel@vger.kernel.org > Cc: x86@kernel.org > > --- > > Andrew, I think it needs to go into mm as > the atomic-instrumented.h patch is in mm. > --- > arch/tile/lib/atomic_asm_32.S | 3 +-- > arch/x86/include/asm/atomic.h | 13 ------------- > include/asm-generic/atomic-instrumented.h | 6 ------ > 3 files changed, 1 insertion(+), 21 deletions(-) > > diff --git a/arch/tile/lib/atomic_asm_32.S b/arch/tile/lib/atomic_asm_32.S > index 1a70e6c0f259..94709ab41ed8 100644 > --- a/arch/tile/lib/atomic_asm_32.S > +++ b/arch/tile/lib/atomic_asm_32.S > @@ -24,8 +24,7 @@ > * has an opportunity to return -EFAULT to the user if needed. > * The 64-bit routines just return a "long long" with the value, > * since they are only used from kernel space and don't expect to fault. > - * Support for 16-bit ops is included in the framework but we don't provide > - * any (x86_64 has an atomic_inc_short(), so we might want to some day). > + * Support for 16-bit ops is included in the framework but we don't provide any. > * > * Note that the caller is advised to issue a suitable L1 or L2 > * prefetch on the address being manipulated to avoid extra stalls. > diff --git a/arch/x86/include/asm/atomic.h b/arch/x86/include/asm/atomic.h > index 0cde164f058a..9ff8738103eb 100644 > --- a/arch/x86/include/asm/atomic.h > +++ b/arch/x86/include/asm/atomic.h > @@ -237,19 +237,6 @@ ATOMIC_OPS(xor, ^) > > int __arch_atomic_add_unless(atomic_t *v, int a, int u); > > -/** > - * arch_atomic_inc_short - increment of a short integer > - * @v: pointer to type int > - * > - * Atomically adds 1 to @v > - * Returns the new value of @u > - */ > -static __always_inline short int arch_atomic_inc_short(short int *v) > -{ > - asm(LOCK_PREFIX "addw $1, %0" : "+m" (*v)); > - return *v; > -} > - > #ifdef CONFIG_X86_32 > # include > #else > diff --git a/include/asm-generic/atomic-instrumented.h b/include/asm-generic/atomic-instrumented.h > index 951bcd083925..70742da13087 100644 > --- a/include/asm-generic/atomic-instrumented.h > +++ b/include/asm-generic/atomic-instrumented.h > @@ -78,12 +78,6 @@ static __always_inline bool atomic64_add_unless(atomic64_t *v, long long a, > return arch_atomic64_add_unless(v, a, u); > } > > -static __always_inline short int atomic_inc_short(short int *v) > -{ > - kasan_check_write(v, sizeof(*v)); > - return arch_atomic_inc_short(v); > -} > - > #define __INSTR_VOID1(op, sz) \ > static __always_inline void atomic##sz##_##op(atomic##sz##_t *v) \ > { \ >