From: peter enderborg <peter.enderborg@sony.com>
To: Michal Hocko <mhocko@kernel.org>, Roman Gushchin <guro@fb.com>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<kernel-team@fb.com>, Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>
Subject: Re: [PATCH RFC] mm: don't raise MEMCG_OOM event due to failed high-order allocation
Date: Tue, 11 Sep 2018 14:41:04 +0200 [thread overview]
Message-ID: <0ea4cdbd-dc3f-1b66-8a5f-8d67ab0e2bc9@sony.com> (raw)
In-Reply-To: <20180911121141.GS10951@dhcp22.suse.cz>
On 09/11/2018 02:11 PM, Michal Hocko wrote:
> Why is this a problem though? IIRC this event was deliberately placed
> outside of the oom path because we wanted to count allocation failures
> and this is also documented that way
>
> oom
> The number of time the cgroup's memory usage was
> reached the limit and allocation was about to fail.
>
> Depending on context result could be invocation of OOM
> killer and retrying allocation or failing a
>
> One could argue that we do not apply the same logic to GFP_NOWAIT
> requests but in general I would like to see a good reason to change
> the behavior and if it is really the right thing to do then we need to
> update the documentation as well.
>
Why not introduce a MEMCG_ALLOC_FAIL in to memcg_memory_event?
next prev parent reply other threads:[~2018-09-11 12:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 21:56 [PATCH RFC] mm: don't raise MEMCG_OOM event due to failed high-order allocation Roman Gushchin
2018-09-11 0:40 ` David Rientjes
2018-09-11 12:11 ` Michal Hocko
2018-09-11 12:41 ` peter enderborg [this message]
2018-09-11 12:47 ` Michal Hocko
2018-09-11 15:34 ` Roman Gushchin
2018-09-11 15:27 ` Roman Gushchin
2018-09-12 12:35 ` Michal Hocko
2018-09-12 16:25 ` Roman Gushchin
2018-09-11 12:43 ` Johannes Weiner
2018-09-11 15:47 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ea4cdbd-dc3f-1b66-8a5f-8d67ab0e2bc9@sony.com \
--to=peter.enderborg@sony.com \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).